From 0c4f2d042c7cff14209d9ece39a09ca90dfa135d Mon Sep 17 00:00:00 2001
From: Maxim Kadushkin <maxim.kadushkin@onlyoffice.com>
Date: Fri, 16 Oct 2020 11:12:02 +0300
Subject: [PATCH] [DE] refactoring for Settings view

---
 .../src/components/settings/Settings.jsx      | 72 +++++++++++--------
 apps/documenteditor/mobile/src/js/routes.js   | 20 ------
 2 files changed, 44 insertions(+), 48 deletions(-)

diff --git a/apps/documenteditor/mobile/src/components/settings/Settings.jsx b/apps/documenteditor/mobile/src/components/settings/Settings.jsx
index 6cb4fddb8..fb406ceae 100644
--- a/apps/documenteditor/mobile/src/components/settings/Settings.jsx
+++ b/apps/documenteditor/mobile/src/components/settings/Settings.jsx
@@ -4,8 +4,31 @@ import { withTranslation } from 'react-i18next';
 import {f7} from 'framework7-react';
 import {Device} from '../../../../../common/mobile/utils/device'
 
+import DocumentSettingsController from "../settings/controller/DocumentSettings.jsx";
+import Margins from "../settings/document-settings/Margins.jsx";
+import DocumentFormats from "../settings/document-settings/DocumentFormats.jsx";
 
-const SettingsView = props => {
+const routes = [
+    {
+        path: '/',
+        component: 'TSettingsView'
+    },
+    {
+        path: '/document-settings/',
+        component: DocumentSettingsController,
+    },
+    {
+        path: '/margins/',
+        component: Margins,
+    },
+    {
+        path: '/document-formats/',
+        component: DocumentFormats,
+    },
+];
+
+
+const SettingsList = withTranslation()(props => {
     const {t} = props;
     const _t = t('ViewSettings', {returnObjects: true});
     const navbar = <Navbar title={t('ViewSettings.textSettings')}>
@@ -17,8 +40,11 @@ const SettingsView = props => {
             props.onOptionClick(page)
     };
 
+    useEffect(() => {
+    });
+
     return (
-        <View style={props.style}>
+        <View style={props.style} stackPages={true} routes={routes}>
             <Page>
                 {navbar}
                 <List>
@@ -27,7 +53,7 @@ const SettingsView = props => {
                             <Icon slot="media" icon="icon-search"></Icon>
                         </ListItem>
                     }
-                    <ListItem title={_t.textDocumentSettings} link="/document-settings/" onClick={onoptionclick.bind(this, '/document-settings/')}>
+                    <ListItem link="#" title={_t.textDocumentSettings} onClick={onoptionclick.bind(this, '/document-settings/')}>
                         <Icon slot="media" icon="icon-doc-setup"></Icon>
                     </ListItem>
                     <ListItem title={_t.textApplicationSettings} link="#">
@@ -52,24 +78,9 @@ const SettingsView = props => {
             </Page>
         </View>
     )
-};
+});
 
-const TSettingsView = withTranslation()(SettingsView);
-
-class SettingsPopup extends Component {
-    constructor(props) {
-        super(props);
-    }
-    render() {
-        return (
-            <Popup className="settings-popup" onPopupClosed={() => this.props.onclosed()}>
-                <TSettingsView />
-            </Popup>
-        )
-    }
-}
-
-class SettingsPopover extends Component {
+class SettingsView extends Component {
     constructor(props) {
         super(props)
 
@@ -81,10 +92,15 @@ class SettingsPopover extends Component {
     }
 
     render() {
+        const show_popover = this.props.usePopover;
         return (
-            <Popover className="settings__popover" onPopoverClosed={() => this.props.onclosed()}>
-                <TSettingsView inPopover={true} onOptionClick={this.onoptionclick} style={{height: '430px', width: '360px'}} />
-            </Popover>
+            show_popover ?
+                <Popover id="settings-popover" className="popover__titled" onPopoverClosed={() => this.props.onclosed()}>
+                    <SettingsList inPopover={true} onOptionClick={this.onoptionclick} style={{height: '410px'}} />
+                </Popover> :
+                <Popup className="settings-popup" onPopupClosed={() => this.props.onclosed()}>
+                    <SettingsList onOptionClick={this.onoptionclick} />
+                </Popup>
         )
     }
 }
@@ -93,7 +109,7 @@ const Settings = props => {
     useEffect(() => {
         if ( Device.phone )
             f7.popup.open('.settings-popup');
-        else f7.popover.open('.settings__popover', '#btn-settings');
+        else f7.popover.open('#settings-popover', '#btn-settings');
 
         return () => {
             // component will unmount
@@ -106,11 +122,11 @@ const Settings = props => {
             props.onclosed();
     };
 
-    if ( Device.phone ) {
-        return <SettingsPopup onclosed={onviewclosed} />
-    }
+    // if ( Device.phone ) {
+    //     return <SettingsPopup onclosed={onviewclosed} />
+    // }
 
-    return <SettingsPopover onclosed={onviewclosed} />
+    return <SettingsView usePopover={!Device.phone} onclosed={onviewclosed} />
 };
 
 export default Settings;
diff --git a/apps/documenteditor/mobile/src/js/routes.js b/apps/documenteditor/mobile/src/js/routes.js
index a36db2d33..9c75def19 100644
--- a/apps/documenteditor/mobile/src/js/routes.js
+++ b/apps/documenteditor/mobile/src/js/routes.js
@@ -1,9 +1,5 @@
 
 import HomePage from '../pages/home.jsx';
-// import DocumentSettings from "../components/settings/document-settings/DocumentSettings.jsx";
-import Margins from "../components/settings/document-settings/Margins.jsx";
-import DocumentFormats from "../components/settings/document-settings/DocumentFormats.jsx";
-import DocumentSettingsController from "../components/settings/controller/DocumentSettings.jsx";
 
 import LeftPage1 from '../pages/left-page-1.jsx';
 import LeftPage2 from '../pages/left-page-2.jsx';
@@ -41,26 +37,10 @@ var routes = [
     path: '/edit-text-line-spacing/',
     component: PageLineSpacing,
   },
-  {
-    path: '/document-settings/',
-    component: DocumentSettingsController,
-  },
   {
     path: '/users/',
     component: PageUsers
   },
-  // {
-  //   path: '/collab-main/',
-  //   component: PageCollaboration
-  // },
-  {
-    path: '/margins/',
-    component: Margins,
-  },
-  {
-    path: '/document-formats/',
-    component: DocumentFormats,
-  },
   {
     path: '/left-page-1/',
     component: LeftPage1,