From 7d9f2d22b3090509080a13363f1b3819f12f9239 Mon Sep 17 00:00:00 2001 From: Julia Radzhabova Date: Wed, 8 Nov 2017 14:19:44 +0300 Subject: [PATCH] Bug with creating several synchronize tips. --- .../main/lib/component/SynchronizeTip.js | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/apps/common/main/lib/component/SynchronizeTip.js b/apps/common/main/lib/component/SynchronizeTip.js index a6c3f24ed..c8146b1cc 100644 --- a/apps/common/main/lib/component/SynchronizeTip.js +++ b/apps/common/main/lib/component/SynchronizeTip.js @@ -39,8 +39,6 @@ define([ 'use strict'; Common.UI.SynchronizeTip = Common.UI.BaseView.extend(_.extend((function() { - var tipEl; - return { options : { target : $(document.body), @@ -71,36 +69,38 @@ define([ }, render: function() { - tipEl = $(this.template({ scope: this })); - tipEl.find('.close').on('click', _.bind(function() { this.trigger('closeclick');}, this)); - tipEl.find('.show-link label').on('click', _.bind(function() { this.trigger('dontshowclick');}, this)); + if (!this.cmpEl) { + this.cmpEl = $(this.template({ scope: this })); + $(document.body).append(this.cmpEl); + this.cmpEl.find('.close').on('click', _.bind(function() { this.trigger('closeclick');}, this)); + this.cmpEl.find('.show-link label').on('click', _.bind(function() { this.trigger('dontshowclick');}, this)); + } - $(document.body).append(tipEl); this.applyPlacement(); return this; }, show: function(){ - if (tipEl) { + if (this.cmpEl) { this.applyPlacement(); - tipEl.show() + this.cmpEl.show() } else this.render(); }, hide: function() { - if (tipEl) tipEl.hide(); + if (this.cmpEl) this.cmpEl.hide(); }, applyPlacement: function () { var showxy = this.target.offset(); - (this.placement == 'top') ? tipEl.css({bottom : Common.Utils.innerHeight() - showxy.top + 'px', right: Common.Utils.innerWidth() - showxy.left - this.target.width()/2 + 'px'}) - : tipEl.css({top : showxy.top + this.target.height()/2 + 'px', left: showxy.left + this.target.width() + 'px'}); + (this.placement == 'top') ? this.cmpEl.css({bottom : Common.Utils.innerHeight() - showxy.top + 'px', right: Common.Utils.innerWidth() - showxy.left - this.target.width()/2 + 'px'}) + : this.cmpEl.css({top : showxy.top + this.target.height()/2 + 'px', left: showxy.left + this.target.width() + 'px'}); }, isVisible: function() { - return tipEl && tipEl.is(':visible'); + return this.cmpEl && this.cmpEl.is(':visible'); }, textDontShow : 'Don\'t show this message again',