From a35e5207999b47e95a238e2863a952b617bc96d4 Mon Sep 17 00:00:00 2001
From: Julia Radzhabova <julia.radzhabova@onlyoffice.com>
Date: Mon, 20 Apr 2020 19:14:48 +0300
Subject: [PATCH] [SSE] Show function arguments

---
 .../main/app/view/FormulaWizard.js            | 131 +++++++++++++-----
 1 file changed, 98 insertions(+), 33 deletions(-)

diff --git a/apps/spreadsheeteditor/main/app/view/FormulaWizard.js b/apps/spreadsheeteditor/main/app/view/FormulaWizard.js
index 150a23f0d..0656d210a 100644
--- a/apps/spreadsheeteditor/main/app/view/FormulaWizard.js
+++ b/apps/spreadsheeteditor/main/app/view/FormulaWizard.js
@@ -45,7 +45,8 @@ define([
 
     SSE.Views.FormulaWizard = Common.UI.Window.extend(_.extend({
         options: {
-            width: 400,
+            width: 420,
+            height: 460,
             header: true,
             style: 'min-width: 350px;',
             cls: 'modal-dlg',
@@ -58,39 +59,14 @@ define([
             }, options || {});
 
             this.template = [
-                '<div class="box" style="height: 350px;">',
-                    '<div>',
-                    '<table cols="2" style="width: 100%;margin-bottom: 10px;">',
-                        '<tr>',
-                            '<td colspan="2" style="">',
-                                '<label id="formula-wizard-lbl-name-arg1" class="input-label">Argument1</label>',
-                            '</td>',
-                        '</tr>',
-                        '<tr>',
-                            '<td style="padding-right: 10px;padding-bottom: 8px;width: 70%;vertical-align: middle;">',
-                                '<div id="formula-wizard-txt-arg1"></div>',
-                            '</td>',
-                            '<td style="padding-bottom: 8px;vertical-align: middle;">',
-                                '<label id="formula-wizard-lbl-val-arg1" class="input-label">= 0</label>',
-                            '</td>',
-                        '</tr>',
-                        '<tr>',
-                            '<td colspan="2" style="">',
-                                '<label id="formula-wizard-lbl-name-arg2" class="input-label">Argument2</label>',
-                            '</td>',
-                        '</tr>',
-                        '<tr>',
-                            '<td style="padding-right: 10px;padding-bottom: 8px;width: 70%;vertical-align: middle;">',
-                                '<div id="formula-wizard-txt-arg2"></div>',
-                            '</td>',
-                            '<td style="padding-bottom: 8px;vertical-align: middle;">',
-                                '<label id="formula-wizard-lbl-val-arg2" class="input-label">= 234234</label>',
-                            '</td>',
-                        '</tr>',
+                '<div class="box" style="height:' + (this.options.height-103) + 'px;">',
+                    '<label id="formula-wizard-name" style="display: block;margin-bottom: 8px"></label>',
+                    '<div style="height: 220px; overflow: hidden;position: relative; margin-bottom: 8px;">',
+                    '<table cols="2" id="formula-wizard-tbl-args" style="width: 100%;margin-bottom: 8px;">',
                     '</table>',
                     '</div>',
-                    '<label id="formula-wizard-value" style="display: block;margin-bottom: 16px"><b>Value:</b> 24123</label>',
-                    '<label id="formula-wizard-arg-desc" style="display: block;margin-bottom: 16px"><b>Argument 1:</b> some argument description</label>',
+                    '<label id="formula-wizard-value" style="display: block;margin-bottom: 8px"></label>',
+                    '<label id="formula-wizard-arg-desc" style="display: block;margin-bottom: 8px"><b>Argument 1:</b> some argument description</label>',
                     '<label id="formula-wizard-args" style="display: block;margin-bottom: 4px"></label>',
                     '<label id="formula-wizard-desc" style="display: block;"></label>',
                 '</div>',
@@ -100,7 +76,9 @@ define([
             this.options.tpl = _.template(this.template)(this.options);
             this.props = this.options.props;
             this.funcprops = this.options.funcprops;
+            this.api = this.options.api;
             this._noApply = false;
+            this.args = [];
 
             Common.UI.Window.prototype.initialize.call(this, this.options);
         },
@@ -126,6 +104,13 @@ define([
             $window.find('.dlg-btn').on('click', _.bind(this.onBtnClick, this));
             $window.find('input').on('keypress', _.bind(this.onKeyPress, this));
 
+            this.scrollerY = new Common.UI.Scroller({
+                el: $window.find('#formula-wizard-tbl-args').parent(),
+                minScrollbarLength  : 20,
+                alwaysVisibleY: this.scrollAlwaysVisible
+            });
+            this.scrollerY.scrollTop(0);
+
             this.afterRender();
         },
 
@@ -157,19 +142,99 @@ define([
                 props.desc ? $('#formula-wizard-desc').text(props.desc) : $('#formula-wizard-desc').addClass('hidden');
             }
             if (this.props) {
+                var me = this;
+
                 // fill arguments
                 var props = this.props;
                 var result = props.asc_getFormulaResult();
                 $('#formula-wizard-value').html('<b>' + this.textValue + ': </b>' + ((result!==undefined && result!==null)? result : ''));
+                $('#formula-wizard-name').html('<b>' + this.textFunction + ': </b>' + props.name);
+
+                var tbl = this.$window.find('#formula-wizard-tbl-args');
+                var argtpl = '<tr><td colspan="2" style=""><label id="formula-wizard-lbl-name-arg{0}" class="input-label"></label></td></tr>' +
+                            '<tr><td style="padding-right: 10px;padding-bottom: 8px;width: 100%;vertical-align: middle;"><div id="formula-wizard-txt-arg{0}"></div></td>' +
+                            '<td style="padding-bottom: 8px;vertical-align: middle;"><div id="formula-wizard-lbl-val-arg{0}" class="input-label" style="margin-top: 1px;width: 150px;overflow: hidden;text-overflow: ellipsis;white-space: nowrap;"></div></td></tr>';
+                var argmin = props.asc_getArgumentMin(),
+                    argmax = props.asc_getArgumentMax(),
+                    argres = props.asc_getArgumentsResult(),
+                    argtype = props.asc_getArgumentsType(),
+                    argcount = 0,
+                    lasttype;
+                for (var i=0; i<argmax; i++) {
+                    var type = (argtype[i]==undefined) ? lasttype : argtype[i],
+                        types = [];
+                    if (type==undefined) break;
+                    lasttype = type;
+
+                    if (typeof type == 'object')
+                        types = type;
+                    else
+                        types.push(type);
+                    for (var j=0; j<types.length; j++) {
+                        var div = $(Common.Utils.String.format(argtpl, argcount));
+                        tbl.append(div);
+                        var txt = new Common.UI.InputFieldBtn({
+                            el          : div.find('#formula-wizard-txt-arg'+argcount),
+                            validateOnBlur: false
+                        }).on('changed:after', function(input, newValue, oldValue, e) {
+                            if (newValue == oldValue) return;
+                        });
+                        this.args.push({
+                            index: argcount,
+                            lblName: div.find('#formula-wizard-lbl-name-arg'+argcount),
+                            lblValue: div.find('#formula-wizard-lbl-val-arg'+argcount),
+                            argInput: txt,
+                            argName: 'Argument ' + (argcount+1),
+                            argType: this.getArgType(types[j])
+                        });
+                        if (i<argmin)
+                            this.args[argcount].lblName.html('<b>' + this.args[argcount].argName + '</b>');
+                        else
+                            this.args[argcount].lblName.html(this.args[argcount].argName);
+                        this.args[argcount].lblValue.text(' = '+ (argres && (argres.length>argcount) && argres[argcount]!==null ? argres[argcount] : this.args[argcount].argType));
+                        argcount++;
+                    }
+                    if (i>=argmin && (typeof type == 'object')) // show only one repeatable argument
+                        break;
+                }
+                this.scrollerY.update();
             }
         },
 
+        getArgType: function(type) {
+            var str = '';
+            switch (type) {
+                case Asc.c_oAscFormulaArgumentType.number:
+                    str = 'number';
+                    break;
+                case Asc.c_oAscFormulaArgumentType.text:
+                    str = 'text';
+                    break;
+                case Asc.c_oAscFormulaArgumentType.reference:
+                    str = 'reference';
+                    break;
+                case Asc.c_oAscFormulaArgumentType.any:
+                    str = 'any';
+                    break;
+                case Asc.c_oAscFormulaArgumentType.logical:
+                    str = 'logical';
+                    break;
+            }
+            return str;
+        },
+
         getSettings: function() {
             return {};
         },
 
+        close: function () {
+            Common.UI.Window.prototype.close.call(this);
+            this.api.asc_closeCellEditor(true);
+        },
+
         textTitle: 'Function Argumens',
-        textValue: 'Value'
+        textValue: 'Formula result',
+        textFunction: 'Function'
 
     }, SSE.Views.FormulaWizard || {}))
 });
\ No newline at end of file