From b06f78acc0bd0173a7bf471656bf236ee6661642 Mon Sep 17 00:00:00 2001 From: Julia Radzhabova Date: Tue, 22 Dec 2020 15:37:05 +0300 Subject: [PATCH] Fix show collaboration tab --- apps/documenteditor/main/app/controller/Toolbar.js | 4 +++- apps/presentationeditor/main/app/controller/Toolbar.js | 4 +++- apps/presentationeditor/main/app/controller/Viewport.js | 2 +- apps/spreadsheeteditor/main/app/controller/Toolbar.js | 4 +++- apps/spreadsheeteditor/main/app/controller/Viewport.js | 2 +- 5 files changed, 11 insertions(+), 5 deletions(-) diff --git a/apps/documenteditor/main/app/controller/Toolbar.js b/apps/documenteditor/main/app/controller/Toolbar.js index 75a0df6ee..d959ba97f 100644 --- a/apps/documenteditor/main/app/controller/Toolbar.js +++ b/apps/documenteditor/main/app/controller/Toolbar.js @@ -3065,8 +3065,10 @@ define([ var tab = {action: 'review', caption: me.toolbar.textTabCollaboration}; var $panel = me.application.getController('Common.Controllers.ReviewChanges').createToolbarPanel(); - if ( $panel ) + if ( $panel ) { me.toolbar.addTab(tab, $panel, 5); + me.toolbar.setVisible('review', config.isEdit || config.canViewReview || config.canCoAuthoring && config.canComments); + } if ( config.isEdit ) { me.toolbar.setMode(config); diff --git a/apps/presentationeditor/main/app/controller/Toolbar.js b/apps/presentationeditor/main/app/controller/Toolbar.js index 726edf11f..af5345706 100644 --- a/apps/presentationeditor/main/app/controller/Toolbar.js +++ b/apps/presentationeditor/main/app/controller/Toolbar.js @@ -2206,8 +2206,10 @@ define([ var tab = {action: 'review', caption: me.toolbar.textTabCollaboration}; var $panel = me.getApplication().getController('Common.Controllers.ReviewChanges').createToolbarPanel(); - if ( $panel ) + if ( $panel ) { me.toolbar.addTab(tab, $panel, 3); + me.toolbar.setVisible('review', config.isEdit || config.canViewReview || config.canCoAuthoring && config.canComments); + } if ( config.isEdit ) { me.toolbar.setMode(config); diff --git a/apps/presentationeditor/main/app/controller/Viewport.js b/apps/presentationeditor/main/app/controller/Viewport.js index b8e4dbe30..ae8e2f1b7 100644 --- a/apps/presentationeditor/main/app/controller/Viewport.js +++ b/apps/presentationeditor/main/app/controller/Viewport.js @@ -226,7 +226,7 @@ define([ if (!config.isEdit) { me.header.mnuitemCompactToolbar.hide(); Common.NotificationCenter.on('tab:visible', _.bind(function(action, visible){ - if (action=='plugins' && visible) { + if ((action=='plugins' || action=='review') && visible) { me.header.mnuitemCompactToolbar.show(); } }, this)); diff --git a/apps/spreadsheeteditor/main/app/controller/Toolbar.js b/apps/spreadsheeteditor/main/app/controller/Toolbar.js index e22940957..1889bb2ba 100644 --- a/apps/spreadsheeteditor/main/app/controller/Toolbar.js +++ b/apps/spreadsheeteditor/main/app/controller/Toolbar.js @@ -3357,8 +3357,10 @@ define([ if ( !config.isEditDiagram && !config.isEditMailMerge ) { var tab = {action: 'review', caption: me.toolbar.textTabCollaboration}; var $panel = me.getApplication().getController('Common.Controllers.ReviewChanges').createToolbarPanel(); - if ($panel) + if ($panel) { me.toolbar.addTab(tab, $panel, 6); + me.toolbar.setVisible('review', config.isEdit || config.canViewReview || config.canCoAuthoring && config.canComments); + } } if ( config.isEdit ) { diff --git a/apps/spreadsheeteditor/main/app/controller/Viewport.js b/apps/spreadsheeteditor/main/app/controller/Viewport.js index 0a90ed4f9..685e1c6e1 100644 --- a/apps/spreadsheeteditor/main/app/controller/Viewport.js +++ b/apps/spreadsheeteditor/main/app/controller/Viewport.js @@ -204,7 +204,7 @@ define([ if (!config.isEdit && !config.isEditDiagram && !config.isEditMailMerge) { me.header.mnuitemCompactToolbar.hide(); Common.NotificationCenter.on('tab:visible', _.bind(function(action, visible){ - if (action=='plugins' && visible) { + if ((action=='plugins' || action=='review') && visible) { me.header.mnuitemCompactToolbar.show(); } }, this));