From 952d4347ab5a1e94ba9d88e38bbda08c0f9ea402 Mon Sep 17 00:00:00 2001
From: Julia Radzhabova <Julia.Radzhabova@onlyoffice.com>
Date: Wed, 4 Mar 2020 10:28:12 +0300
Subject: [PATCH 01/12] [SSE] Add hyperlink to named ranges

---
 .../main/app/controller/DocumentHolder.js     |   3 +-
 .../main/app/controller/Toolbar.js            |   3 +-
 .../main/app/view/HyperlinkSettingsDialog.js  | 123 ++++++++++++++----
 apps/spreadsheeteditor/main/locale/en.json    |   2 +-
 .../main/resources/less/app.less              |   1 +
 5 files changed, 103 insertions(+), 29 deletions(-)

diff --git a/apps/spreadsheeteditor/main/app/controller/DocumentHolder.js b/apps/spreadsheeteditor/main/app/controller/DocumentHolder.js
index c62edcc75..82cd8e62b 100644
--- a/apps/spreadsheeteditor/main/app/controller/DocumentHolder.js
+++ b/apps/spreadsheeteditor/main/app/controller/DocumentHolder.js
@@ -512,7 +512,7 @@ define([
 
                 while (++i < wc) {
                     if (!this.api.asc_isWorksheetHidden(i)) {
-                        items.push({displayValue: me.api.asc_getWorksheetName(i), value: me.api.asc_getWorksheetName(i)});
+                        items.push(me.api.asc_getWorksheetName(i));
                     }
                 }
 
@@ -536,6 +536,7 @@ define([
                 win.show();
                 win.setSettings({
                     sheets  : items,
+                    ranges  : me.api.asc_getDefinedNames(Asc.c_oAscGetDefinedNamesList.All),
                     currentSheet: me.api.asc_getWorksheetName(me.api.asc_getActiveWorksheetIndex()),
                     props   : props,
                     text    : cell.asc_getText(),
diff --git a/apps/spreadsheeteditor/main/app/controller/Toolbar.js b/apps/spreadsheeteditor/main/app/controller/Toolbar.js
index e49aed615..b70ded600 100644
--- a/apps/spreadsheeteditor/main/app/controller/Toolbar.js
+++ b/apps/spreadsheeteditor/main/app/controller/Toolbar.js
@@ -881,7 +881,7 @@ define([
 
                 while (++i < wc) {
                     if (!this.api.asc_isWorksheetHidden(i)) {
-                        items.push({displayValue: me.api.asc_getWorksheetName(i), value: me.api.asc_getWorksheetName(i)});
+                        items.push(me.api.asc_getWorksheetName(i));
                     }
                 }
 
@@ -905,6 +905,7 @@ define([
                 win.show();
                 win.setSettings({
                     sheets  : items,
+                    ranges  : me.api.asc_getDefinedNames(Asc.c_oAscGetDefinedNamesList.All),
                     currentSheet: me.api.asc_getWorksheetName(me.api.asc_getActiveWorksheetIndex()),
                     props   : props,
                     text    : cell.asc_getText(),
diff --git a/apps/spreadsheeteditor/main/app/view/HyperlinkSettingsDialog.js b/apps/spreadsheeteditor/main/app/view/HyperlinkSettingsDialog.js
index 7e8b4b140..ff1ad9e0a 100644
--- a/apps/spreadsheeteditor/main/app/view/HyperlinkSettingsDialog.js
+++ b/apps/spreadsheeteditor/main/app/view/HyperlinkSettingsDialog.js
@@ -46,7 +46,8 @@ define([
     'common/main/lib/util/utils',
     'common/main/lib/component/ComboBox',
     'common/main/lib/component/InputField',
-    'common/main/lib/component/Window'
+    'common/main/lib/component/Window',
+    'common/main/lib/component/TreeView'
 ], function () { 'use strict';
 
     SSE.Views.HyperlinkSettingsDialog = Common.UI.Window.extend(_.extend({
@@ -63,7 +64,7 @@ define([
             }, options || {});
 
             this.template = [
-                '<div class="box">',
+                '<div class="box" style="height: 290px;">',
                     '<div class="input-row" style="margin-bottom: 10px;">',
                         '<button type="button" class="btn btn-text-default auto" id="id-dlg-hyperlink-external" style="border-top-right-radius: 0;border-bottom-right-radius: 0;">', this.textExternalLink,'</button>',
                         '<button type="button" class="btn btn-text-default auto" id="id-dlg-hyperlink-internal" style="border-top-left-radius: 0;border-bottom-left-radius: 0;">', this.textInternalLink,'</button>',
@@ -76,13 +77,10 @@ define([
                     '</div>',
                     '<div id="id-internal-link" class="hidden">',
                         '<div class="input-row">',
-                            '<label style="width: 50%;">' + this.strSheet + '</label>',
-                            '<label style="width: 50%;">' + this.strRange + ' *</label>',
-                        '</div>',
-                        '<div class="input-row" style="margin-bottom: 5px;">',
-                            '<div id="id-dlg-hyperlink-sheet" style="display: inline-block; width: 50%; padding-right: 10px; float: left;"></div>',
-                            '<div id="id-dlg-hyperlink-range" style="display: inline-block; width: 50%;"></div>',
+                            '<label>' + this.strRange + ' *</label>',
                         '</div>',
+                        '<div id="id-dlg-hyperlink-range" class="input-row" style="margin-bottom: 5px;"></div>',
+                        '<div id="id-dlg-hyperlink-list" style="width:100%; height: 115px;border: 1px solid #cfcfcf;"></div>',
                     '</div>',
                     '<div class="input-row">',
                         '<label>' + this.strDisplay + '</label>',
@@ -124,13 +122,6 @@ define([
             });
             me.btnInternal.on('click', _.bind(me.onLinkTypeClick, me, Asc.c_oAscHyperlinkType.RangeLink));
 
-            me.cmbSheets = new Common.UI.ComboBox({
-                el      : $('#id-dlg-hyperlink-sheet'),
-                cls     : 'input-group-nr',
-                editable: false,
-                menuStyle: 'min-width: 100%;max-height: 150px;'
-            });
-
             me.inputUrl = new Common.UI.InputField({
                 el          : $('#id-dlg-hyperlink-url'),
                 allowBlank  : false,
@@ -175,8 +166,19 @@ define([
                 maxLength   : Asc.c_oAscMaxTooltipLength
             });
 
-            $window.find('.dlg-btn').on('click', _.bind(this.onBtnClick, this));
+            me.internalList = new Common.UI.TreeView({
+                el: $('#id-dlg-hyperlink-list'),
+                store: new Common.UI.TreeViewStore(),
+                enableKeyEvents: true
+            });
+            me.internalList.on('item:select', _.bind(this.onSelectItem, this));
 
+            me.btnOk = new Common.UI.Button({
+                el: $window.find('.primary')
+            });
+
+            $window.find('.dlg-btn').on('click', _.bind(this.onBtnClick, this));
+            me.internalList.on('entervalue', _.bind(me.onPrimary, me));
             me.externalPanel = $window.find('#id-external-link');
             me.internalPanel = $window.find('#id-internal-link');
         },
@@ -193,32 +195,32 @@ define([
         setSettings: function(settings) {
             if (settings) {
                 var me = this;
+                me.settings = settings;
 
-                this.cmbSheets.setData(settings.sheets);
                 var type = (settings.props) ? settings.props.asc_getType() : Asc.c_oAscHyperlinkType.WebLink;
                 (type == Asc.c_oAscHyperlinkType.WebLink) ? me.btnExternal.toggle(true) : me.btnInternal.toggle(true);
                 me.ShowHideElem(type);
                 me.btnInternal.setDisabled(!settings.allowInternal && (type == Asc.c_oAscHyperlinkType.WebLink));
                 me.btnExternal.setDisabled(!settings.allowInternal && (type == Asc.c_oAscHyperlinkType.RangeLink));
 
+                var sheet = settings.currentSheet;
                 if (!settings.props) {
                     this.inputDisplay.setValue(settings.isLock ? this.textDefault : settings.text);
                     this.focusedInput = this.inputUrl.cmpEl.find('input');
-                    this.cmbSheets.setValue(settings.currentSheet);
                 } else {
                     if (type == Asc.c_oAscHyperlinkType.RangeLink) {
-                        this.cmbSheets.setValue(settings.props.asc_getSheet());
+                        sheet = settings.props.asc_getSheet();
                         this.inputRange.setValue(settings.props.asc_getRange());
                         this.focusedInput = this.inputRange.cmpEl.find('input');
                     } else {
                         this.inputUrl.setValue(settings.props.asc_getHyperlinkUrl().replace(new RegExp(" ",'g'), "%20"));
                         this.focusedInput = this.inputUrl.cmpEl.find('input');
-                        this.cmbSheets.setValue(settings.currentSheet);
                     }
                     this.inputDisplay.setValue(settings.isLock ? this.textDefault : settings.props.asc_getText());
                     this.inputTip.setValue(settings.props.asc_getTooltip());
                 }
-
+                var rec = this.internalList.store.findWhere({name: sheet });
+                rec && this.internalList.scrollToRecord(this.internalList.selectRecord(rec));
                 this.inputDisplay.setDisabled(settings.isLock);
             }
         },
@@ -229,9 +231,12 @@ define([
             props.asc_setType(this.btnInternal.isActive() ? Asc.c_oAscHyperlinkType.RangeLink : Asc.c_oAscHyperlinkType.WebLink);
 
             if (this.btnInternal.isActive()) {
-                props.asc_setSheet(this.cmbSheets.getValue());
-                props.asc_setRange(this.inputRange.getValue());
-                def_display = this.cmbSheets.getValue() + '!' + this.inputRange.getValue();
+                var rec = this.internalList.getSelectedRec();
+                if (rec) {
+                    props.asc_setSheet(rec.get('name'));
+                    props.asc_setRange(this.inputRange.getValue());
+                    def_display = rec.get('name') + '!' + this.inputRange.getValue();
+                }
             } else {
                 var url = this.inputUrl.getValue().replace(/^\s+|\s+$/g,'');
                 if (! /(((^https?)|(^ftp)):\/\/)|(^mailto:)/i.test(url) )
@@ -292,14 +297,78 @@ define([
         ShowHideElem: function(value) {
             this.externalPanel.toggleClass('hidden', value !== Asc.c_oAscHyperlinkType.WebLink);
             this.internalPanel.toggleClass('hidden', value !== Asc.c_oAscHyperlinkType.RangeLink);
+            var store = this.internalList.store;
+            if (value==Asc.c_oAscHyperlinkType.RangeLink) {
+                if (store.length<1 && this.settings) {
+                    var sheets = this.settings.sheets,
+                        count = sheets.length,
+                        arr = [];
+                    arr.push(new Common.UI.TreeViewModel({
+                        name : this.textSheets,
+                        level: 0,
+                        index: 0,
+                        hasParent: false,
+                        isEmptyItem: false,
+                        isNotHeader: true,
+                        hasSubItems: true
+                    }));
+                    for (var i=0; i<count; i++) {
+                        arr.push(new Common.UI.TreeViewModel({
+                            name : sheets[i],
+                            level: 1,
+                            index: i+1,
+                            type: 0, // sheet
+                            hasParent: true
+                        }));
+                    }
+                    arr.push(new Common.UI.TreeViewModel({
+                        name : this.textNames,
+                        level: 0,
+                        index: arr.length,
+                        hasParent: false,
+                        isEmptyItem: false,
+                        isNotHeader: false,
+                        hasSubItems: false
+                    }));
+                    var ranges = this.settings.ranges,
+                        prev_level = 0;
+                    count = ranges.length;
+                    for (var i=0; i<count; i++) {
+                        var range = ranges[i];
+                        if (!range.asc_getIsTable()) {
+                            if (prev_level<1)
+                                arr[arr.length-1].set('hasSubItems', true);
+                            arr.push(new Common.UI.TreeViewModel({
+                                name : range.asc_getName(),
+                                level: 1,
+                                index: arr.length,
+                                type: 1, // defined name
+                                hasParent: true
+                            }));
+                            prev_level = 1;
+                        }
+                    }
+                    store.reset(arr);
+                }
+                var rec = this.internalList.store.findWhere({name: this.settings.currentSheet });
+                rec && this.internalList.scrollToRecord(this.internalList.selectRecord(rec));
+                this.btnOk.setDisabled(!rec || rec.get('level')==0);
+
+            } else
+                this.btnOk.setDisabled(false);
         },
 
         onLinkTypeClick: function(type, btn, event) {
             this.ShowHideElem(type);
         },
 
+        onSelectItem: function(picker, item, record, e){
+            this.btnOk.setDisabled(record.get('level')==0);
+            this.inputRange.setDisabled(record.get('type')==1 || record.get('level')==0);
+        },
+
         textTitle:          'Hyperlink Settings',
-        textInternalLink:   'Internal Data Range',
+        textInternalLink:   'Place in Document',
         textExternalLink:   'Web Link',
         textEmptyLink:      'Enter link here',
         textEmptyDesc:      'Enter caption here',
@@ -312,6 +381,8 @@ define([
         txtEmpty:           'This field is required',
         textInvalidRange:   'ERROR! Invalid cells range',
         txtNotUrl:          'This field should be a URL in the format \"http://www.example.com\"',
-        textDefault:        'Selected range'
+        textDefault:        'Selected range',
+        textSheets:         'Sheets',
+        textNames:          'Defined names'
     }, SSE.Views.HyperlinkSettingsDialog || {}))
 });
\ No newline at end of file
diff --git a/apps/spreadsheeteditor/main/locale/en.json b/apps/spreadsheeteditor/main/locale/en.json
index 5e92d56e4..982878ee4 100644
--- a/apps/spreadsheeteditor/main/locale/en.json
+++ b/apps/spreadsheeteditor/main/locale/en.json
@@ -1709,7 +1709,7 @@
   "SSE.Views.HyperlinkSettingsDialog.textEmptyLink": "Enter link here",
   "SSE.Views.HyperlinkSettingsDialog.textEmptyTooltip": "Enter tooltip here",
   "SSE.Views.HyperlinkSettingsDialog.textExternalLink": "External Link",
-  "SSE.Views.HyperlinkSettingsDialog.textInternalLink": "Internal Data Range",
+  "SSE.Views.HyperlinkSettingsDialog.textInternalLink": "Place in Document",
   "SSE.Views.HyperlinkSettingsDialog.textInvalidRange": "ERROR! Invalid cells range",
   "SSE.Views.HyperlinkSettingsDialog.textTipText": "ScreenTip Text",
   "SSE.Views.HyperlinkSettingsDialog.textTitle": "Hyperlink Settings",
diff --git a/apps/spreadsheeteditor/main/resources/less/app.less b/apps/spreadsheeteditor/main/resources/less/app.less
index e96f88b7c..53715491d 100644
--- a/apps/spreadsheeteditor/main/resources/less/app.less
+++ b/apps/spreadsheeteditor/main/resources/less/app.less
@@ -88,6 +88,7 @@
 @import "../../../../common/main/resources/less/radiobox.less";
 @import "../../../../common/main/resources/less/dataview.less";
 @import "../../../../common/main/resources/less/listview.less";
+@import "../../../../common/main/resources/less/treeview.less";
 @import "../../../../common/main/resources/less/colorpalette.less";
 @import "../../../../common/main/resources/less/theme-colorpalette.less";
 @import "../../../../common/main/resources/less/dimension-picker.less";

From b8439d88fd26e31780d7a86e5f128f4beb71c785 Mon Sep 17 00:00:00 2001
From: Julia Radzhabova <Julia.Radzhabova@onlyoffice.com>
Date: Wed, 4 Mar 2020 14:45:42 +0300
Subject: [PATCH 02/12] [DE][SSE] Change hyperlink settings: disable Ok button
 when no url or data range

---
 .../main/app/view/HyperlinkSettingsDialog.js   | 15 +++++++++++----
 .../main/app/view/HyperlinkSettingsDialog.js   | 18 +++++++++++++-----
 2 files changed, 24 insertions(+), 9 deletions(-)

diff --git a/apps/documenteditor/main/app/view/HyperlinkSettingsDialog.js b/apps/documenteditor/main/app/view/HyperlinkSettingsDialog.js
index 0d7f8c0c2..680f99917 100644
--- a/apps/documenteditor/main/app/view/HyperlinkSettingsDialog.js
+++ b/apps/documenteditor/main/app/view/HyperlinkSettingsDialog.js
@@ -67,19 +67,22 @@ define([
             }, options || {});
 
             this.template = [
-                '<div class="box" style="height: 260px;">',
+                '<div class="box" style="height: 263px;">',
                     '<div class="input-row" style="margin-bottom: 10px;">',
                         '<button type="button" class="btn btn-text-default auto" id="id-dlg-hyperlink-external" style="border-top-right-radius: 0;border-bottom-right-radius: 0;">', this.textExternal,'</button>',
                         '<button type="button" class="btn btn-text-default auto" id="id-dlg-hyperlink-internal" style="border-top-left-radius: 0;border-bottom-left-radius: 0;">', this.textInternal,'</button>',
                     '</div>',
                     '<div id="id-external-link">',
                         '<div class="input-row">',
-                            '<label>' + this.textUrl + ' *</label>',
+                            '<label>' + this.textUrl + '</label>',
                         '</div>',
                         '<div id="id-dlg-hyperlink-url" class="input-row" style="margin-bottom: 5px;"></div>',
                     '</div>',
                     '<div id="id-internal-link">',
-                        '<div id="id-dlg-hyperlink-list" style="width:100%; height: 130px;border: 1px solid #cfcfcf;"></div>',
+                        '<div class="input-row">',
+                            '<label>' + this.textUrl + '</label>',
+                        '</div>',
+                        '<div id="id-dlg-hyperlink-list" style="width:100%; height: 115px;border: 1px solid #cfcfcf;"></div>',
                     '</div>',
                     '<div class="input-row">',
                         '<label>' + this.textDisplay + '</label>',
@@ -134,6 +137,9 @@ define([
                     return (urltype>0) ? true : me.txtNotUrl;
                 }
             });
+            me.inputUrl._input.on('input', function (e) {
+                me.btnOk.setDisabled($.trim($(e.target).val())=='');
+            });
 
             me.inputDisplay = new Common.UI.InputField({
                 el          : $('#id-dlg-hyperlink-display'),
@@ -247,12 +253,13 @@ define([
                         }
                     }
                     store.reset(arr);
+                    this.internalList.collapseAll();
                 }
                 var rec = this.internalList.getSelectedRec();
                 this.btnOk.setDisabled(!rec || rec.get('level')==0 && rec.get('index')>0);
 
             } else
-                this.btnOk.setDisabled(false);
+                this.btnOk.setDisabled($.trim(this.inputUrl.getValue())=='');
         },
 
         onLinkTypeClick: function(type, btn, event) {
diff --git a/apps/spreadsheeteditor/main/app/view/HyperlinkSettingsDialog.js b/apps/spreadsheeteditor/main/app/view/HyperlinkSettingsDialog.js
index ff1ad9e0a..3dc4764a5 100644
--- a/apps/spreadsheeteditor/main/app/view/HyperlinkSettingsDialog.js
+++ b/apps/spreadsheeteditor/main/app/view/HyperlinkSettingsDialog.js
@@ -71,13 +71,13 @@ define([
                     '</div>',
                     '<div id="id-external-link">',
                         '<div class="input-row">',
-                            '<label>' + this.strLinkTo + ' *</label>',
+                            '<label>' + this.strLinkTo + '</label>',
                         '</div>',
                         '<div id="id-dlg-hyperlink-url" class="input-row" style="margin-bottom: 5px;"></div>',
                     '</div>',
                     '<div id="id-internal-link" class="hidden">',
                         '<div class="input-row">',
-                            '<label>' + this.strRange + ' *</label>',
+                            '<label>' + this.strRange + '</label>',
                         '</div>',
                         '<div id="id-dlg-hyperlink-range" class="input-row" style="margin-bottom: 5px;"></div>',
                         '<div id="id-dlg-hyperlink-list" style="width:100%; height: 115px;border: 1px solid #cfcfcf;"></div>',
@@ -134,6 +134,9 @@ define([
                     return (urltype>0) ? true : me.txtNotUrl;
                 }
             });
+            me.inputUrl._input.on('input', function (e) {
+                me.btnOk.setDisabled($.trim($(e.target).val())=='');
+            });
 
             me.inputRange = new Common.UI.InputField({
                 el          : $('#id-dlg-hyperlink-range'),
@@ -152,6 +155,9 @@ define([
                     }
                 }
             });
+            me.inputRange._input.on('input', function (e) {
+                me.btnOk.setDisabled($.trim($(e.target).val())=='');
+            });
 
             me.inputDisplay = new Common.UI.InputField({
                 el          : $('#id-dlg-hyperlink-display'),
@@ -328,6 +334,7 @@ define([
                         hasParent: false,
                         isEmptyItem: false,
                         isNotHeader: false,
+                        isExpanded: false,
                         hasSubItems: false
                     }));
                     var ranges = this.settings.ranges,
@@ -343,6 +350,7 @@ define([
                                 level: 1,
                                 index: arr.length,
                                 type: 1, // defined name
+                                isVisible: false,
                                 hasParent: true
                             }));
                             prev_level = 1;
@@ -352,10 +360,10 @@ define([
                 }
                 var rec = this.internalList.store.findWhere({name: this.settings.currentSheet });
                 rec && this.internalList.scrollToRecord(this.internalList.selectRecord(rec));
-                this.btnOk.setDisabled(!rec || rec.get('level')==0);
+                this.btnOk.setDisabled(!rec || rec.get('level')==0 || rec.get('type')==0 && $.trim(this.inputRange.getValue())=='');
 
             } else
-                this.btnOk.setDisabled(false);
+                this.btnOk.setDisabled($.trim(this.inputUrl.getValue())=='');
         },
 
         onLinkTypeClick: function(type, btn, event) {
@@ -363,7 +371,7 @@ define([
         },
 
         onSelectItem: function(picker, item, record, e){
-            this.btnOk.setDisabled(record.get('level')==0);
+            this.btnOk.setDisabled(record.get('level')==0 || record.get('type')==0 && $.trim(this.inputRange.getValue())=='');
             this.inputRange.setDisabled(record.get('type')==1 || record.get('level')==0);
         },
 

From c1d4c5291a4fd744bbf7afe1b8f7ddee9bcd9655 Mon Sep 17 00:00:00 2001
From: Julia Radzhabova <Julia.Radzhabova@onlyoffice.com>
Date: Wed, 4 Mar 2020 16:19:05 +0300
Subject: [PATCH 03/12] [SSE] Update translation

---
 apps/spreadsheeteditor/main/locale/en.json | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/apps/spreadsheeteditor/main/locale/en.json b/apps/spreadsheeteditor/main/locale/en.json
index a752333f9..a237ad277 100644
--- a/apps/spreadsheeteditor/main/locale/en.json
+++ b/apps/spreadsheeteditor/main/locale/en.json
@@ -1716,6 +1716,8 @@
   "SSE.Views.HyperlinkSettingsDialog.textTitle": "Hyperlink Settings",
   "SSE.Views.HyperlinkSettingsDialog.txtEmpty": "This field is required",
   "SSE.Views.HyperlinkSettingsDialog.txtNotUrl": "This field should be a URL in the \"http://www.example.com\" format",
+  "SSE.Views.HyperlinkSettingsDialog.textSheets": "Sheets",
+  "SSE.Views.HyperlinkSettingsDialog.textNames": "Defined names",
   "SSE.Views.ImageSettings.textAdvanced": "Show advanced settings",
   "SSE.Views.ImageSettings.textCrop": "Crop",
   "SSE.Views.ImageSettings.textCropFill": "Fill",

From 0598d3a61ad44c22b2698967bff90c4d0b0f301f Mon Sep 17 00:00:00 2001
From: Julia Radzhabova <Julia.Radzhabova@onlyoffice.com>
Date: Fri, 6 Mar 2020 15:33:28 +0300
Subject: [PATCH 04/12] [SSE] Add hyperlink to named range

---
 .../main/app/view/HyperlinkSettingsDialog.js  |  1 -
 .../main/app/view/HyperlinkSettingsDialog.js  | 30 +++++++++++++------
 2 files changed, 21 insertions(+), 10 deletions(-)

diff --git a/apps/documenteditor/main/app/view/HyperlinkSettingsDialog.js b/apps/documenteditor/main/app/view/HyperlinkSettingsDialog.js
index 680f99917..2cfb377bd 100644
--- a/apps/documenteditor/main/app/view/HyperlinkSettingsDialog.js
+++ b/apps/documenteditor/main/app/view/HyperlinkSettingsDialog.js
@@ -257,7 +257,6 @@ define([
                 }
                 var rec = this.internalList.getSelectedRec();
                 this.btnOk.setDisabled(!rec || rec.get('level')==0 && rec.get('index')>0);
-
             } else
                 this.btnOk.setDisabled($.trim(this.inputUrl.getValue())=='');
         },
diff --git a/apps/spreadsheeteditor/main/app/view/HyperlinkSettingsDialog.js b/apps/spreadsheeteditor/main/app/view/HyperlinkSettingsDialog.js
index 3dc4764a5..5010d1568 100644
--- a/apps/spreadsheeteditor/main/app/view/HyperlinkSettingsDialog.js
+++ b/apps/spreadsheeteditor/main/app/view/HyperlinkSettingsDialog.js
@@ -180,7 +180,8 @@ define([
             me.internalList.on('item:select', _.bind(this.onSelectItem, this));
 
             me.btnOk = new Common.UI.Button({
-                el: $window.find('.primary')
+                el: $window.find('.primary'),
+                disabled: true
             });
 
             $window.find('.dlg-btn').on('click', _.bind(this.onBtnClick, this));
@@ -216,17 +217,23 @@ define([
                 } else {
                     if (type == Asc.c_oAscHyperlinkType.RangeLink) {
                         sheet = settings.props.asc_getSheet();
-                        this.inputRange.setValue(settings.props.asc_getRange());
+                        if (sheet) {
+                            this.inputRange.setValue(settings.props.asc_getRange());
+                        } else {// named range
+                            sheet = settings.props.asc_getRange();
+                            this.inputRange.setDisabled(true);
+                        }
                         this.focusedInput = this.inputRange.cmpEl.find('input');
+                        var rec = this.internalList.store.findWhere({name: sheet });
+                        rec && this.internalList.scrollToRecord(this.internalList.selectRecord(rec));
                     } else {
                         this.inputUrl.setValue(settings.props.asc_getHyperlinkUrl().replace(new RegExp(" ",'g'), "%20"));
                         this.focusedInput = this.inputUrl.cmpEl.find('input');
+                        this.btnOk.setDisabled($.trim(this.inputUrl.getValue())=='');
                     }
                     this.inputDisplay.setValue(settings.isLock ? this.textDefault : settings.props.asc_getText());
                     this.inputTip.setValue(settings.props.asc_getTooltip());
                 }
-                var rec = this.internalList.store.findWhere({name: sheet });
-                rec && this.internalList.scrollToRecord(this.internalList.selectRecord(rec));
                 this.inputDisplay.setDisabled(settings.isLock);
             }
         },
@@ -238,10 +245,16 @@ define([
 
             if (this.btnInternal.isActive()) {
                 var rec = this.internalList.getSelectedRec();
-                if (rec) {
-                    props.asc_setSheet(rec.get('name'));
-                    props.asc_setRange(this.inputRange.getValue());
-                    def_display = rec.get('name') + '!' + this.inputRange.getValue();
+                if (rec && rec.get('level')>0) {
+                    if (rec.get('type')) {// named range
+                        props.asc_setSheet(null);
+                        props.asc_setRange(rec.get('name'));
+                        def_display = rec.get('name');
+                    } else {
+                        props.asc_setSheet(rec.get('name'));
+                        props.asc_setRange(this.inputRange.getValue());
+                        def_display = rec.get('name') + '!' + this.inputRange.getValue();
+                    }
                 }
             } else {
                 var url = this.inputUrl.getValue().replace(/^\s+|\s+$/g,'');
@@ -361,7 +374,6 @@ define([
                 var rec = this.internalList.store.findWhere({name: this.settings.currentSheet });
                 rec && this.internalList.scrollToRecord(this.internalList.selectRecord(rec));
                 this.btnOk.setDisabled(!rec || rec.get('level')==0 || rec.get('type')==0 && $.trim(this.inputRange.getValue())=='');
-
             } else
                 this.btnOk.setDisabled($.trim(this.inputUrl.getValue())=='');
         },

From b1269c3677c7e3d4700dab6754f00f13635d834c Mon Sep 17 00:00:00 2001
From: Julia Radzhabova <Julia.Radzhabova@onlyoffice.com>
Date: Fri, 6 Mar 2020 15:52:48 +0300
Subject: [PATCH 05/12] [PE] Change adding internal link

---
 .../main/app/view/HyperlinkSettingsDialog.js  | 264 +++++++++++-------
 1 file changed, 163 insertions(+), 101 deletions(-)

diff --git a/apps/presentationeditor/main/app/view/HyperlinkSettingsDialog.js b/apps/presentationeditor/main/app/view/HyperlinkSettingsDialog.js
index 47fe2fda7..795ba0a1f 100644
--- a/apps/presentationeditor/main/app/view/HyperlinkSettingsDialog.js
+++ b/apps/presentationeditor/main/app/view/HyperlinkSettingsDialog.js
@@ -50,9 +50,8 @@ var c_oHyperlinkType = {
 define([
     'common/main/lib/util/utils',
     'common/main/lib/component/InputField',
-    'common/main/lib/component/ComboBox',
-    'common/main/lib/component/RadioBox',
-    'common/main/lib/component/Window'
+    'common/main/lib/component/Window',
+    'common/main/lib/component/TreeView'
 ], function () { 'use strict';
 
     PE.Views.HyperlinkSettingsDialog = Common.UI.Window.extend(_.extend({
@@ -70,7 +69,7 @@ define([
             }, options || {});
 
             this.template = [
-                '<div class="box" style="height: 250px;">',
+                '<div class="box" style="height: 263px;">',
                     '<div class="input-row" style="margin-bottom: 10px;">',
                         '<button type="button" class="btn btn-text-default auto" id="id-dlg-hyperlink-external" style="border-top-right-radius: 0;border-bottom-right-radius: 0;">', this.textExternalLink,'</button>',
                         '<button type="button" class="btn btn-text-default auto" id="id-dlg-hyperlink-internal" style="border-top-left-radius: 0;border-bottom-left-radius: 0;">', this.textInternalLink,'</button>',
@@ -81,13 +80,11 @@ define([
                         '</div>',
                         '<div id="id-dlg-hyperlink-url" class="input-row" style="margin-bottom: 5px;"></div>',
                     '</div>',
-                    '<div id="id-internal-link" class="hidden" style="margin-top: 15px;">',
-                        '<div id="id-dlg-hyperlink-radio-next" style="display: block;margin-bottom: 5px;"></div>',
-                        '<div id="id-dlg-hyperlink-radio-prev" style="display: block;margin-bottom: 5px;"></div>',
-                        '<div id="id-dlg-hyperlink-radio-first" style="display: block;margin-bottom: 5px;"></div>',
-                        '<div id="id-dlg-hyperlink-radio-last"  style="display: block;margin-bottom: 5px;"></div>',
-                        '<div id="id-dlg-hyperlink-radio-slide" style="display: inline-block;margin-bottom: 5px;margin-right: 10px;"></div>',
-                        '<div id="id-dlg-hyperlink-slide" style="display: inline-block;margin-bottom: 10px;"></div>',
+                    '<div id="id-internal-link" class="hidden">',
+                        '<div class="input-row">',
+                            '<label>' + this.strLinkTo + ' *</label>',
+                        '</div>',
+                        '<div id="id-dlg-hyperlink-list" style="width:100%; height: 115px;border: 1px solid #cfcfcf;"></div>',
                     '</div>',
                     '<div class="input-row">',
                         '<label>' + this.strDisplay + '</label>',
@@ -142,6 +139,9 @@ define([
                     return (urltype>0) ? true : me.txtNotUrl;
                 }
             });
+            me.inputUrl._input.on('input', function (e) {
+                me.btnOk.setDisabled($.trim($(e.target).val())=='');
+            });
 
             me.inputDisplay = new Common.UI.InputField({
                 el          : $('#id-dlg-hyperlink-display'),
@@ -158,59 +158,72 @@ define([
                 maxLength   : Asc.c_oAscMaxTooltipLength
             });
 
-            me.radioNext = new Common.UI.RadioBox({
-                el: $('#id-dlg-hyperlink-radio-next'),
-                labelText: this.txtNext,
-                name: 'asc-radio-slide',
-                checked: true
-            });
+            // me.radioNext = new Common.UI.RadioBox({
+            //     el: $('#id-dlg-hyperlink-radio-next'),
+            //     labelText: this.txtNext,
+            //     name: 'asc-radio-slide',
+            //     checked: true
+            // });
+            //
+            // me.radioPrev = new Common.UI.RadioBox({
+            //     el: $('#id-dlg-hyperlink-radio-prev'),
+            //     labelText: this.txtPrev,
+            //     name: 'asc-radio-slide'
+            // });
+            //
+            // me.radioFirst = new Common.UI.RadioBox({
+            //     el: $('#id-dlg-hyperlink-radio-first'),
+            //     labelText: this.txtFirst,
+            //     name: 'asc-radio-slide'
+            // });
+            //
+            // me.radioLast = new Common.UI.RadioBox({
+            //     el: $('#id-dlg-hyperlink-radio-last'),
+            //     labelText: this.txtLast,
+            //     name: 'asc-radio-slide'
+            // });
+            //
+            // me.radioSlide = new Common.UI.RadioBox({
+            //     el: $('#id-dlg-hyperlink-radio-slide'),
+            //     labelText: this.txtSlide,
+            //     name: 'asc-radio-slide'
+            // });
+            //
+            // me.cmbSlides = new Common.UI.ComboBox({
+            //     el: $('#id-dlg-hyperlink-slide'),
+            //     cls: 'input-group-nr',
+            //     style: 'width: 50px;',
+            //     menuStyle: 'min-width: 50px; max-height: 200px;',
+            //     data: this.slides
+            // });
+            // me.cmbSlides.setValue(0);
+            // me.cmbSlides.on('selected', _.bind(function(combo, record) {
+            //     me.radioSlide.setValue(true);
+            // }, me))
+            // .on('changed:after', _.bind(function(combo, record) {
+            //     me.radioSlide.setValue(true);
+            //     if (record.value>me.slides.length)
+            //         combo.setValue(me.slides.length-1);
+            //     else if (record.value<1)
+            //         combo.setValue(0);
+            //     else
+            //         combo.setValue(record.value-1);
+            // }, me));
 
-            me.radioPrev = new Common.UI.RadioBox({
-                el: $('#id-dlg-hyperlink-radio-prev'),
-                labelText: this.txtPrev,
-                name: 'asc-radio-slide'
+            me.internalList = new Common.UI.TreeView({
+                el: $('#id-dlg-hyperlink-list'),
+                store: new Common.UI.TreeViewStore(),
+                enableKeyEvents: true
             });
+            me.internalList.on('item:select', _.bind(this.onSelectItem, this));
 
-            me.radioFirst = new Common.UI.RadioBox({
-                el: $('#id-dlg-hyperlink-radio-first'),
-                labelText: this.txtFirst,
-                name: 'asc-radio-slide'
+            me.btnOk = new Common.UI.Button({
+                el: $window.find('.primary'),
+                disabled: true
             });
 
-            me.radioLast = new Common.UI.RadioBox({
-                el: $('#id-dlg-hyperlink-radio-last'),
-                labelText: this.txtLast,
-                name: 'asc-radio-slide'
-            });
-
-            me.radioSlide = new Common.UI.RadioBox({
-                el: $('#id-dlg-hyperlink-radio-slide'),
-                labelText: this.txtSlide,
-                name: 'asc-radio-slide'
-            });
-
-            me.cmbSlides = new Common.UI.ComboBox({
-                el: $('#id-dlg-hyperlink-slide'),
-                cls: 'input-group-nr',
-                style: 'width: 50px;',
-                menuStyle: 'min-width: 50px; max-height: 200px;',
-                data: this.slides
-            });
-            me.cmbSlides.setValue(0);
-            me.cmbSlides.on('selected', _.bind(function(combo, record) {
-                me.radioSlide.setValue(true);
-            }, me))
-            .on('changed:after', _.bind(function(combo, record) {
-                me.radioSlide.setValue(true);
-                if (record.value>me.slides.length)
-                    combo.setValue(me.slides.length-1);
-                else if (record.value<1)
-                    combo.setValue(0);
-                else
-                    combo.setValue(record.value-1);
-            }, me));
-
             $window.find('.dlg-btn').on('click', _.bind(this.onBtnClick, this));
+            me.internalList.on('entervalue', _.bind(me.onPrimary, me));
             me.externalPanel = $window.find('#id-external-link');
             me.internalPanel = $window.find('#id-internal-link');
         },
@@ -249,21 +262,10 @@ define([
                 var url = "ppaction://hlink";
                 var tip = '';
                 var txttip = me.inputTip.getValue();
-                if (this.radioSlide.getValue()) {
-                    url = url + "sldjumpslide" + (this.cmbSlides.getValue());
-                    tip = this.txtSlide + ' ' + (this.cmbSlides.getValue()+1);
-                } else if (this.radioFirst.getValue()) {
-                    url = url + "showjump?jump=firstslide";
-                    tip = this.txtFirst;
-                } else if (this.radioLast.getValue()) {
-                    url = url + "showjump?jump=lastslide";
-                    tip = this.txtLast;
-                } else if (this.radioNext.getValue()) {
-                    url = url + "showjump?jump=nextslide";
-                    tip = this.txtNext;
-                } else if (this.radioPrev.getValue()) {
-                    url = url + "showjump?jump=previousslide";
-                    tip = this.txtPrev;
+                var rec = this.internalList.getSelectedRec();
+                if (rec) {
+                    url = url + rec.get('type');
+                    tip = rec.get('tiptext');
                 }
                 props.put_Value( url );
                 props.put_ToolTip(_.isEmpty(txttip) ? tip : txttip);
@@ -323,6 +325,11 @@ define([
         ShowHideElem: function(value) {
             this.externalPanel.toggleClass('hidden', value !== c_oHyperlinkType.WebLink);
             this.internalPanel.toggleClass('hidden', value !== c_oHyperlinkType.InternalLink);
+            if (value==c_oHyperlinkType.InternalLink) {
+                var rec = this.internalList.getSelectedRec();
+                this.btnOk.setDisabled(!rec || rec.get('index')==4);
+            } else
+                this.btnOk.setDisabled($.trim(this.inputUrl.getValue())=='');
         },
 
         onLinkTypeClick: function(type, btn, event) {
@@ -333,35 +340,85 @@ define([
             if (url===null || url===undefined || url=='' )
                 return c_oHyperlinkType.WebLink;
 
+            var store = this.internalList.store;
             var indAction = url.indexOf("ppaction://hlink");
             if (0 == indAction)
             {
-                if (url == "ppaction://hlinkshowjump?jump=firstslide")
-                {
-                    this.radioFirst.setValue(true);
-                }
-                else if (url == "ppaction://hlinkshowjump?jump=lastslide")
-                {
-                    this.radioLast.setValue(true);
-                }
-                else if (url == "ppaction://hlinkshowjump?jump=nextslide")
-                {
-                    this.radioNext.setValue(true);
-                }
-                else if (url == "ppaction://hlinkshowjump?jump=previousslide")
-                {
-                    this.radioPrev.setValue(true);
-                }
-                else
-                {
-                    this.radioSlide.setValue(true);
-                    var mask = "ppaction://hlinksldjumpslide";
-                    var indSlide = url.indexOf(mask);
-                    if (0 == indSlide)
-                    {
-                        var slideNum = parseInt(url.substring(mask.length));
-                        if (slideNum >= 0 && slideNum < this.slides.length)
-                            this.cmbSlides.setValue(slideNum);
+                if (store.length<1) {
+                    var arr = [], i = 0;
+                    arr.push(new Common.UI.TreeViewModel({
+                        name : this.txtFirst,
+                        level: 0,
+                        index: i++,
+                        hasParent: false,
+                        isEmptyItem: false,
+                        isNotHeader: true,
+                        hasSubItems: false,
+                        type: "showjump?jump=firstslide",
+                        tiptext: this.txtFirst,
+                        selected: url == "ppaction://hlinkshowjump?jump=firstslide"
+                    }));
+                    arr.push(new Common.UI.TreeViewModel({
+                        name : this.txtLast,
+                        level: 0,
+                        index: i++,
+                        hasParent: false,
+                        isEmptyItem: false,
+                        isNotHeader: true,
+                        hasSubItems: false,
+                        type: "showjump?jump=lastslide",
+                        tiptext: this.txtLast,
+                        selected: url == "ppaction://hlinkshowjump?jump=lastslide"
+                    }));
+                    arr.push(new Common.UI.TreeViewModel({
+                        name : this.txtNext,
+                        level: 0,
+                        index: i++,
+                        hasParent: false,
+                        isEmptyItem: false,
+                        isNotHeader: true,
+                        hasSubItems: false,
+                        type: "showjump?jump=nextslide",
+                        tiptext: this.txtNext,
+                        selected: url == "ppaction://hlinkshowjump?jump=nextslide"
+                    }));
+                    arr.push(new Common.UI.TreeViewModel({
+                        name : this.txtPrev,
+                        level: 0,
+                        index: i++,
+                        hasParent: false,
+                        isEmptyItem: false,
+                        isNotHeader: true,
+                        hasSubItems: false,
+                        type: "showjump?jump=previousslide",
+                        tiptext: this.txtPrev,
+                        selected: url == "ppaction://hlinkshowjump?jump=previousslide"
+                    }));
+                    arr.push(new Common.UI.TreeViewModel({
+                        name : this.textSlides,
+                        level: 0,
+                        index: i++,
+                        hasParent: false,
+                        isEmptyItem: false,
+                        isNotHeader: true,
+                        hasSubItems: this.api.getCountPages()>0
+                    }));
+                    var mask = "ppaction://hlinksldjumpslide",
+                        indSlide = url.indexOf(mask),
+                        slideNum = (0 == indSlide) ? parseInt(url.substring(mask.length)) : -1;
+                    for (var i=0; i<this.api.getCountPages(); i++) {
+                        arr.push(new Common.UI.TreeViewModel({
+                            name : this.txtSlide + ' ' + (i+1),
+                            level: 1,
+                            index: arr.length,
+                            hasParent: false,
+                            isEmptyItem: false,
+                            isNotHeader: true,
+                            hasSubItems: false,
+                            type: 'sldjumpslide' + i,
+                            tiptext: this.txtSlide + ' ' + (i+1),
+                            selected: i==slideNum
+                        }));
                     }
                 }
                 return c_oHyperlinkType.InternalLink;
@@ -371,8 +428,12 @@ define([
             }
         },
 
+        onSelectItem: function(picker, item, record, e){
+            this.btnOk.setDisabled(record.get('index')==4);
+        },
+
         textTitle:          'Hyperlink Settings',
-        textInternalLink:   'Slide In This Presentation',
+        textInternalLink:   'Place in Document',
         textExternalLink:   'External Link',
         textEmptyLink:      'Enter link here',
         textEmptyDesc:      'Enter caption here',
@@ -388,6 +449,7 @@ define([
         txtPrev:            'Previous Slide',
         txtFirst:           'First Slide',
         txtLast:            'Last Slide',
-        textDefault:        'Selected text'
+        textDefault:        'Selected text',
+        textSlides: 'Slides'
     }, PE.Views.HyperlinkSettingsDialog || {}))
 });
\ No newline at end of file

From 77ab8c41bcc286e834e3067b58ecc655fa216d0d Mon Sep 17 00:00:00 2001
From: Julia Radzhabova <Julia.Radzhabova@onlyoffice.com>
Date: Fri, 6 Mar 2020 16:14:08 +0300
Subject: [PATCH 06/12] [PE] Fix applying hyperlink settings

---
 .../main/app/view/HyperlinkSettingsDialog.js  | 43 ++++++++++---------
 .../main/resources/less/app.less              |  1 +
 2 files changed, 24 insertions(+), 20 deletions(-)

diff --git a/apps/presentationeditor/main/app/view/HyperlinkSettingsDialog.js b/apps/presentationeditor/main/app/view/HyperlinkSettingsDialog.js
index 795ba0a1f..c2cf38d00 100644
--- a/apps/presentationeditor/main/app/view/HyperlinkSettingsDialog.js
+++ b/apps/presentationeditor/main/app/view/HyperlinkSettingsDialog.js
@@ -234,7 +234,7 @@ define([
 
                 var type = me.parseUrl(props.get_Value());
                 (type == c_oHyperlinkType.WebLink) ? me.btnExternal.toggle(true) : me.btnInternal.toggle(true);
-                me.ShowHideElem(type);
+                me.ShowHideElem(type, props.get_Value());
                 
                 if (props.get_Text()!==null) {
                     me.inputDisplay.setValue(props.get_Text());
@@ -322,28 +322,13 @@ define([
             this.close();
         },
 
-        ShowHideElem: function(value) {
+        ShowHideElem: function(value, url) {
             this.externalPanel.toggleClass('hidden', value !== c_oHyperlinkType.WebLink);
             this.internalPanel.toggleClass('hidden', value !== c_oHyperlinkType.InternalLink);
             if (value==c_oHyperlinkType.InternalLink) {
-                var rec = this.internalList.getSelectedRec();
-                this.btnOk.setDisabled(!rec || rec.get('index')==4);
-            } else
-                this.btnOk.setDisabled($.trim(this.inputUrl.getValue())=='');
-        },
-
-        onLinkTypeClick: function(type, btn, event) {
-            this.ShowHideElem(type);
-        },
-
-        parseUrl: function(url) {
-            if (url===null || url===undefined || url=='' )
-                return c_oHyperlinkType.WebLink;
-
-            var store = this.internalList.store;
-            var indAction = url.indexOf("ppaction://hlink");
-            if (0 == indAction)
-            {
+                if (url===null || url===undefined || url=='' )
+                    url = "ppaction://hlinkshowjump?jump=firstslide";
+                var store = this.internalList.store;
                 if (store.length<1) {
                     var arr = [], i = 0;
                     arr.push(new Common.UI.TreeViewModel({
@@ -420,7 +405,25 @@ define([
                             selected: i==slideNum
                         }));
                     }
+                    store.reset(arr);
                 }
+                var rec = this.internalList.getSelectedRec();
+                this.btnOk.setDisabled(!rec || rec.get('index')==4);
+            } else
+                this.btnOk.setDisabled($.trim(this.inputUrl.getValue())=='');
+        },
+
+        onLinkTypeClick: function(type, btn, event) {
+            this.ShowHideElem(type);
+        },
+
+        parseUrl: function(url) {
+            if (url===null || url===undefined || url=='' )
+                return c_oHyperlinkType.WebLink;
+
+            var indAction = url.indexOf("ppaction://hlink");
+            if (0 == indAction)
+            {
                 return c_oHyperlinkType.InternalLink;
             } else  {
                 this.inputUrl.setValue(url ? url.replace(new RegExp(" ",'g'), "%20") : '');
diff --git a/apps/presentationeditor/main/resources/less/app.less b/apps/presentationeditor/main/resources/less/app.less
index ba083683e..c62b1ab3b 100644
--- a/apps/presentationeditor/main/resources/less/app.less
+++ b/apps/presentationeditor/main/resources/less/app.less
@@ -88,6 +88,7 @@
 @import "../../../../common/main/resources/less/radiobox.less";
 @import "../../../../common/main/resources/less/dataview.less";
 @import "../../../../common/main/resources/less/listview.less";
+@import "../../../../common/main/resources/less/treeview.less";
 @import "../../../../common/main/resources/less/colorpalette.less";
 @import "../../../../common/main/resources/less/theme-colorpalette.less";
 @import "../../../../common/main/resources/less/dimension-picker.less";

From 4c9592350ce6556b536a49a331bc59e4f6520798 Mon Sep 17 00:00:00 2001
From: Julia Radzhabova <Julia.Radzhabova@onlyoffice.com>
Date: Tue, 10 Mar 2020 17:49:42 +0300
Subject: [PATCH 07/12] Fix editing hyperlinks

---
 apps/common/main/lib/component/TreeView.js    | 16 ++++++
 .../main/app/view/HyperlinkSettingsDialog.js  | 16 ++++--
 .../main/app/view/HyperlinkSettingsDialog.js  | 53 +------------------
 .../main/app/view/HyperlinkSettingsDialog.js  | 49 ++++++++---------
 4 files changed, 54 insertions(+), 80 deletions(-)

diff --git a/apps/common/main/lib/component/TreeView.js b/apps/common/main/lib/component/TreeView.js
index d8b645e2c..8f32ea245 100644
--- a/apps/common/main/lib/component/TreeView.js
+++ b/apps/common/main/lib/component/TreeView.js
@@ -264,6 +264,22 @@ define([
             expandToLevel: function(expandLevel) {
                 this.store.expandToLevel(expandLevel);
                 this.scroller.update({minScrollbarLength: 40, alwaysVisibleY: this.scrollAlwaysVisible});
+            },
+
+            expandRecord: function(record) {
+                if (record) {
+                    record.set('isExpanded', true);
+                    this.store.expandSubItems(record);
+                    this.scroller.update({minScrollbarLength: 40, alwaysVisibleY: this.scrollAlwaysVisible});
+                }
+            },
+
+            collapseRecord: function(record) {
+                if (record) {
+                    record.set('isExpanded', false);
+                    this.store.collapseSubItems(record);
+                    this.scroller.update({minScrollbarLength: 40, alwaysVisibleY: this.scrollAlwaysVisible});
+                }
             }
         }
     })());
diff --git a/apps/documenteditor/main/app/view/HyperlinkSettingsDialog.js b/apps/documenteditor/main/app/view/HyperlinkSettingsDialog.js
index 2cfb377bd..643fc3839 100644
--- a/apps/documenteditor/main/app/view/HyperlinkSettingsDialog.js
+++ b/apps/documenteditor/main/app/view/HyperlinkSettingsDialog.js
@@ -200,6 +200,7 @@ define([
                         hasParent: false,
                         isEmptyItem: false,
                         isNotHeader: false,
+                        type: Asc.c_oAscHyperlinkAnchor.Heading,
                         hasSubItems: false
                     }));
 
@@ -232,6 +233,7 @@ define([
                         hasParent: false,
                         isEmptyItem: false,
                         isNotHeader: false,
+                        type: Asc.c_oAscHyperlinkAnchor.Bookmark,
                         hasSubItems: false
                     }));
 
@@ -294,19 +296,25 @@ define([
                     } else {
                         me.inputUrl.setValue('');
                     }
+                    this.btnOk.setDisabled($.trim(this.inputUrl.getValue())=='');
                 } else {
                     if (props.is_TopOfDocument())
                         this.internalList.selectByIndex(0);
                     else if (props.is_Heading()) {
-                        var heading = props.get_Heading(),
-                            rec = this.internalList.store.findWhere({type: Asc.c_oAscHyperlinkAnchor.Heading, headingParagraph: heading });
-                        if (rec)
+                        var rec = this.internalList.store.findWhere({type: Asc.c_oAscHyperlinkAnchor.Heading, headingParagraph: props.get_Heading() });
+                        if (rec) {
+                            this.internalList.expandRecord(this.internalList.store.at(1));
                             this.internalList.scrollToRecord(this.internalList.selectRecord(rec));
+                        }
                     } else {
                         var rec = this.internalList.store.findWhere({type: Asc.c_oAscHyperlinkAnchor.Bookmark, name: bookmark});
-                        if (rec)
+                        if (rec) {
+                            this.internalList.expandRecord(this.internalList.store.findWhere({type: Asc.c_oAscHyperlinkAnchor.Bookmark, level: 0}));
                             this.internalList.scrollToRecord(this.internalList.selectRecord(rec));
+                        }
                     }
+                    var rec = this.internalList.getSelectedRec();
+                    this.btnOk.setDisabled(!rec || rec.get('level')==0 && rec.get('index')>0);
                 }
 
                 if (props.get_Text() !== null) {
diff --git a/apps/presentationeditor/main/app/view/HyperlinkSettingsDialog.js b/apps/presentationeditor/main/app/view/HyperlinkSettingsDialog.js
index c2cf38d00..04bcfab52 100644
--- a/apps/presentationeditor/main/app/view/HyperlinkSettingsDialog.js
+++ b/apps/presentationeditor/main/app/view/HyperlinkSettingsDialog.js
@@ -158,58 +158,6 @@ define([
                 maxLength   : Asc.c_oAscMaxTooltipLength
             });
 
-            // me.radioNext = new Common.UI.RadioBox({
-            //     el: $('#id-dlg-hyperlink-radio-next'),
-            //     labelText: this.txtNext,
-            //     name: 'asc-radio-slide',
-            //     checked: true
-            // });
-            //
-            // me.radioPrev = new Common.UI.RadioBox({
-            //     el: $('#id-dlg-hyperlink-radio-prev'),
-            //     labelText: this.txtPrev,
-            //     name: 'asc-radio-slide'
-            // });
-            //
-            // me.radioFirst = new Common.UI.RadioBox({
-            //     el: $('#id-dlg-hyperlink-radio-first'),
-            //     labelText: this.txtFirst,
-            //     name: 'asc-radio-slide'
-            // });
-            //
-            // me.radioLast = new Common.UI.RadioBox({
-            //     el: $('#id-dlg-hyperlink-radio-last'),
-            //     labelText: this.txtLast,
-            //     name: 'asc-radio-slide'
-            // });
-            //
-            // me.radioSlide = new Common.UI.RadioBox({
-            //     el: $('#id-dlg-hyperlink-radio-slide'),
-            //     labelText: this.txtSlide,
-            //     name: 'asc-radio-slide'
-            // });
-            //
-            // me.cmbSlides = new Common.UI.ComboBox({
-            //     el: $('#id-dlg-hyperlink-slide'),
-            //     cls: 'input-group-nr',
-            //     style: 'width: 50px;',
-            //     menuStyle: 'min-width: 50px; max-height: 200px;',
-            //     data: this.slides
-            // });
-            // me.cmbSlides.setValue(0);
-            // me.cmbSlides.on('selected', _.bind(function(combo, record) {
-            //     me.radioSlide.setValue(true);
-            // }, me))
-            // .on('changed:after', _.bind(function(combo, record) {
-            //     me.radioSlide.setValue(true);
-            //     if (record.value>me.slides.length)
-            //         combo.setValue(me.slides.length-1);
-            //     else if (record.value<1)
-            //         combo.setValue(0);
-            //     else
-            //         combo.setValue(record.value-1);
-            // }, me));
-
             me.internalList = new Common.UI.TreeView({
                 el: $('#id-dlg-hyperlink-list'),
                 store: new Common.UI.TreeViewStore(),
@@ -408,6 +356,7 @@ define([
                     store.reset(arr);
                 }
                 var rec = this.internalList.getSelectedRec();
+                rec && this.internalList.scrollToRecord(rec);
                 this.btnOk.setDisabled(!rec || rec.get('index')==4);
             } else
                 this.btnOk.setDisabled($.trim(this.inputUrl.getValue())=='');
diff --git a/apps/spreadsheeteditor/main/app/view/HyperlinkSettingsDialog.js b/apps/spreadsheeteditor/main/app/view/HyperlinkSettingsDialog.js
index 5010d1568..a1a6e11b4 100644
--- a/apps/spreadsheeteditor/main/app/view/HyperlinkSettingsDialog.js
+++ b/apps/spreadsheeteditor/main/app/view/HyperlinkSettingsDialog.js
@@ -206,26 +206,21 @@ define([
 
                 var type = (settings.props) ? settings.props.asc_getType() : Asc.c_oAscHyperlinkType.WebLink;
                 (type == Asc.c_oAscHyperlinkType.WebLink) ? me.btnExternal.toggle(true) : me.btnInternal.toggle(true);
-                me.ShowHideElem(type);
+                me.ShowHideElem(type, settings.props);
                 me.btnInternal.setDisabled(!settings.allowInternal && (type == Asc.c_oAscHyperlinkType.WebLink));
                 me.btnExternal.setDisabled(!settings.allowInternal && (type == Asc.c_oAscHyperlinkType.RangeLink));
 
-                var sheet = settings.currentSheet;
                 if (!settings.props) {
                     this.inputDisplay.setValue(settings.isLock ? this.textDefault : settings.text);
                     this.focusedInput = this.inputUrl.cmpEl.find('input');
                 } else {
                     if (type == Asc.c_oAscHyperlinkType.RangeLink) {
-                        sheet = settings.props.asc_getSheet();
-                        if (sheet) {
+                        if (settings.props.asc_getSheet()) {
                             this.inputRange.setValue(settings.props.asc_getRange());
                         } else {// named range
-                            sheet = settings.props.asc_getRange();
                             this.inputRange.setDisabled(true);
                         }
                         this.focusedInput = this.inputRange.cmpEl.find('input');
-                        var rec = this.internalList.store.findWhere({name: sheet });
-                        rec && this.internalList.scrollToRecord(this.internalList.selectRecord(rec));
                     } else {
                         this.inputUrl.setValue(settings.props.asc_getHyperlinkUrl().replace(new RegExp(" ",'g'), "%20"));
                         this.focusedInput = this.inputUrl.cmpEl.find('input');
@@ -248,7 +243,7 @@ define([
                 if (rec && rec.get('level')>0) {
                     if (rec.get('type')) {// named range
                         props.asc_setSheet(null);
-                        props.asc_setRange(rec.get('name'));
+                        props.asc_setLocation(rec.get('name'));
                         def_display = rec.get('name');
                     } else {
                         props.asc_setSheet(rec.get('name'));
@@ -313,7 +308,7 @@ define([
             this.close();
         },
 
-        ShowHideElem: function(value) {
+        ShowHideElem: function(value, props) {
             this.externalPanel.toggleClass('hidden', value !== Asc.c_oAscHyperlinkType.WebLink);
             this.internalPanel.toggleClass('hidden', value !== Asc.c_oAscHyperlinkType.RangeLink);
             var store = this.internalList.store;
@@ -329,6 +324,7 @@ define([
                         hasParent: false,
                         isEmptyItem: false,
                         isNotHeader: true,
+                        isExpanded: false,
                         hasSubItems: true
                     }));
                     for (var i=0; i<count; i++) {
@@ -337,6 +333,7 @@ define([
                             level: 1,
                             index: i+1,
                             type: 0, // sheet
+                            isVisible: false,
                             hasParent: true
                         }));
                     }
@@ -350,29 +347,33 @@ define([
                         isExpanded: false,
                         hasSubItems: false
                     }));
+                    var definedNames = arr[arr.length-1];
                     var ranges = this.settings.ranges,
                         prev_level = 0;
                     count = ranges.length;
                     for (var i=0; i<count; i++) {
                         var range = ranges[i];
-                        if (!range.asc_getIsTable()) {
-                            if (prev_level<1)
-                                arr[arr.length-1].set('hasSubItems', true);
-                            arr.push(new Common.UI.TreeViewModel({
-                                name : range.asc_getName(),
-                                level: 1,
-                                index: arr.length,
-                                type: 1, // defined name
-                                isVisible: false,
-                                hasParent: true
-                            }));
-                            prev_level = 1;
-                        }
+                        if (prev_level<1)
+                            arr[arr.length-1].set('hasSubItems', true);
+                        arr.push(new Common.UI.TreeViewModel({
+                            name : range.asc_getName(),
+                            level: 1,
+                            index: arr.length,
+                            type: 1, // defined name
+                            isVisible: false,
+                            hasParent: true
+                        }));
+                        prev_level = 1;
                     }
                     store.reset(arr);
+                    var sheet = props ? (props.asc_getSheet() || props.asc_getLocation()) : this.settings.currentSheet,
+                        rec = store.findWhere({name: sheet });
+                    if (rec) {
+                        this.internalList.expandRecord(rec.get('type') ? definedNames : store.at(0));
+                        this.internalList.scrollToRecord(this.internalList.selectRecord(rec));
+                    }
                 }
-                var rec = this.internalList.store.findWhere({name: this.settings.currentSheet });
-                rec && this.internalList.scrollToRecord(this.internalList.selectRecord(rec));
+                var rec = this.internalList.getSelectedRec();
                 this.btnOk.setDisabled(!rec || rec.get('level')==0 || rec.get('type')==0 && $.trim(this.inputRange.getValue())=='');
             } else
                 this.btnOk.setDisabled($.trim(this.inputUrl.getValue())=='');

From 030aaf1768789f1b06e0f92280436c92cd66592c Mon Sep 17 00:00:00 2001
From: Julia Radzhabova <Julia.Radzhabova@onlyoffice.com>
Date: Wed, 11 Mar 2020 13:21:26 +0300
Subject: [PATCH 08/12] InputField: hide error when component is disabled

---
 .../main/resources/less/asc-mixins.less       |  2 +-
 apps/common/main/resources/less/input.less    | 20 +++++++++----------
 2 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/apps/common/main/resources/less/asc-mixins.less b/apps/common/main/resources/less/asc-mixins.less
index 8cf2ee651..cf1530737 100644
--- a/apps/common/main/resources/less/asc-mixins.less
+++ b/apps/common/main/resources/less/asc-mixins.less
@@ -98,7 +98,7 @@
 .button-otherstates-icon(@icon-class, @icon-size) {
     .btn {
         &:active, &.active {
-            &:not(:disabled):not(.disabed) {
+            &:not(:disabled):not(.disabled) {
                 > .@{icon-class} {
                     @iconsize: -1*@icon-size;
 
diff --git a/apps/common/main/resources/less/input.less b/apps/common/main/resources/less/input.less
index ee527b6ab..86e89185a 100644
--- a/apps/common/main/resources/less/input.less
+++ b/apps/common/main/resources/less/input.less
@@ -47,20 +47,20 @@
         position: relative;
     }
 
-    &.error {
-        input {
-            border-color: @brand-danger;
-        }
-
-        .input-error {
-            display: block;
-        }
-    }
-
     &.form-control:focus,
     .form-control:focus {
         border-color: @gray-darker;
     }
+
+    &.error {
+        input:not([disabled]) {
+            border-color: @brand-danger;
+        }
+
+        input:not([disabled]) + .input-error {
+            display: block;
+        }
+    }
 }
 
 input:required:focus:invalid,

From ff8ce10fcd2ddd21468a286cb92df5de533e7d0c Mon Sep 17 00:00:00 2001
From: Julia Radzhabova <Julia.Radzhabova@onlyoffice.com>
Date: Wed, 11 Mar 2020 13:34:37 +0300
Subject: [PATCH 09/12] Hyperlink settings: clear error message

---
 .../main/app/view/HyperlinkSettingsDialog.js           |  3 +++
 .../main/app/view/HyperlinkSettingsDialog.js           |  3 +++
 .../main/app/view/HyperlinkSettingsDialog.js           | 10 +++++++++-
 3 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/apps/documenteditor/main/app/view/HyperlinkSettingsDialog.js b/apps/documenteditor/main/app/view/HyperlinkSettingsDialog.js
index 643fc3839..9fa47a74f 100644
--- a/apps/documenteditor/main/app/view/HyperlinkSettingsDialog.js
+++ b/apps/documenteditor/main/app/view/HyperlinkSettingsDialog.js
@@ -138,6 +138,8 @@ define([
                 }
             });
             me.inputUrl._input.on('input', function (e) {
+                me.isInputFirstChange && me.inputUrl.showError();
+                me.isInputFirstChange = false;
                 me.btnOk.setDisabled($.trim($(e.target).val())=='');
             });
 
@@ -388,6 +390,7 @@ define([
                 if (state == 'ok') {
                     if (this.btnExternal.isActive()) {//WebLink
                         if (this.inputUrl.checkValidate() !== true)  {
+                            this.isInputFirstChange = true;
                             this.inputUrl.cmpEl.find('input').focus();
                             return;
                         }
diff --git a/apps/presentationeditor/main/app/view/HyperlinkSettingsDialog.js b/apps/presentationeditor/main/app/view/HyperlinkSettingsDialog.js
index 04bcfab52..b899adae5 100644
--- a/apps/presentationeditor/main/app/view/HyperlinkSettingsDialog.js
+++ b/apps/presentationeditor/main/app/view/HyperlinkSettingsDialog.js
@@ -140,6 +140,8 @@ define([
                 }
             });
             me.inputUrl._input.on('input', function (e) {
+                me.isInputFirstChange && me.inputUrl.showError();
+                me.isInputFirstChange = false;
                 me.btnOk.setDisabled($.trim($(e.target).val())=='');
             });
 
@@ -255,6 +257,7 @@ define([
                     var checkurl = (this.btnExternal.isActive()) ? this.inputUrl.checkValidate() : true,
                         checkdisp = this.inputDisplay.checkValidate();
                     if (checkurl !== true)  {
+                        this.isInputFirstChange = true;
                         this.inputUrl.cmpEl.find('input').focus();
                         return;
                     }
diff --git a/apps/spreadsheeteditor/main/app/view/HyperlinkSettingsDialog.js b/apps/spreadsheeteditor/main/app/view/HyperlinkSettingsDialog.js
index a1a6e11b4..28d2ca4ec 100644
--- a/apps/spreadsheeteditor/main/app/view/HyperlinkSettingsDialog.js
+++ b/apps/spreadsheeteditor/main/app/view/HyperlinkSettingsDialog.js
@@ -135,6 +135,8 @@ define([
                 }
             });
             me.inputUrl._input.on('input', function (e) {
+                me.isInputFirstChange_url && me.inputUrl.showError();
+                me.isInputFirstChange_url = false;
                 me.btnOk.setDisabled($.trim($(e.target).val())=='');
             });
 
@@ -147,6 +149,8 @@ define([
                 validateOnBlur: false,
                 value: Common.Utils.InternalSettings.get("sse-settings-r1c1") ? 'R1C1' : 'A1',
                 validation  : function(value) {
+                    if (me.inputRange.isDisabled()) // named range
+                        return true;
                     var isvalid = me.api.asc_checkDataRange(Asc.c_oAscSelectionDialogType.FormatTable, value, false);
                     if (isvalid == Asc.c_oAscError.ID.No) {
                         return true;
@@ -156,6 +160,8 @@ define([
                 }
             });
             me.inputRange._input.on('input', function (e) {
+                me.isInputFirstChange_range && me.inputRange.showError();
+                me.isInputFirstChange_range = false;
                 me.btnOk.setDisabled($.trim($(e.target).val())=='');
             });
 
@@ -217,10 +223,10 @@ define([
                     if (type == Asc.c_oAscHyperlinkType.RangeLink) {
                         if (settings.props.asc_getSheet()) {
                             this.inputRange.setValue(settings.props.asc_getRange());
+                            this.focusedInput = this.inputRange.cmpEl.find('input');
                         } else {// named range
                             this.inputRange.setDisabled(true);
                         }
-                        this.focusedInput = this.inputRange.cmpEl.find('input');
                     } else {
                         this.inputUrl.setValue(settings.props.asc_getHyperlinkUrl().replace(new RegExp(" ",'g'), "%20"));
                         this.focusedInput = this.inputUrl.cmpEl.find('input');
@@ -290,10 +296,12 @@ define([
                         checkdisp = this.inputDisplay.checkValidate();
                     if (checkurl !== true)  {
                         this.inputUrl.cmpEl.find('input').focus();
+                        this.isInputFirstChange_url = true;
                         return;
                     }
                     if (checkrange !== true)  {
                         this.inputRange.cmpEl.find('input').focus();
+                        this.isInputFirstChange_range = true;
                         return;
                     }
                     if (checkdisp !== true) {

From 395edff0036fec32ecddeee8c63747356717c211 Mon Sep 17 00:00:00 2001
From: Julia Radzhabova <Julia.Radzhabova@onlyoffice.com>
Date: Wed, 11 Mar 2020 15:39:33 +0300
Subject: [PATCH 10/12] Hyperlink: autofill for display field

---
 .../main/app/view/HyperlinkSettingsDialog.js  | 17 ++++++++-
 .../main/app/view/HyperlinkSettingsDialog.js  | 17 ++++++++-
 .../main/app/view/HyperlinkSettingsDialog.js  | 36 +++++++++++++++++--
 3 files changed, 66 insertions(+), 4 deletions(-)

diff --git a/apps/documenteditor/main/app/view/HyperlinkSettingsDialog.js b/apps/documenteditor/main/app/view/HyperlinkSettingsDialog.js
index 9fa47a74f..d90077177 100644
--- a/apps/documenteditor/main/app/view/HyperlinkSettingsDialog.js
+++ b/apps/documenteditor/main/app/view/HyperlinkSettingsDialog.js
@@ -140,7 +140,9 @@ define([
             me.inputUrl._input.on('input', function (e) {
                 me.isInputFirstChange && me.inputUrl.showError();
                 me.isInputFirstChange = false;
-                me.btnOk.setDisabled($.trim($(e.target).val())=='');
+                var val = $(e.target).val();
+                me.isAutoUpdate && me.inputDisplay.setValue(val);
+                me.btnOk.setDisabled($.trim(val)=='');
             });
 
             me.inputDisplay = new Common.UI.InputField({
@@ -151,6 +153,9 @@ define([
             }).on('changed:after', function() {
                 me.isTextChanged = true;
             });
+            me.inputDisplay._input.on('input', function (e) {
+                me.isAutoUpdate = ($(e.target).val()=='');
+            });
 
             me.inputTip = new Common.UI.InputField({
                 el          : $('#id-dlg-hyperlink-tip'),
@@ -267,10 +272,19 @@ define([
 
         onLinkTypeClick: function(type, btn, event) {
             this.ShowHideElem(type);
+            if (this.isAutoUpdate) {
+                if (type==c_oHyperlinkType.InternalLink) {
+                    var rec = this.internalList.getSelectedRec();
+                    this.inputDisplay.setValue(rec && (rec.get('level') || rec.get('index')==0)? rec.get('name') : '');
+                } else {
+                    this.inputDisplay.setValue(this.inputUrl.getValue());
+                }
+            }
         },
 
         onSelectItem: function(picker, item, record, e){
             this.btnOk.setDisabled(record.get('level')==0 && record.get('index')>0);
+            this.isAutoUpdate && this.inputDisplay.setValue((record.get('level') || record.get('index')==0) ? record.get('name') : '');
         },
 
         show: function() {
@@ -322,6 +336,7 @@ define([
                 if (props.get_Text() !== null) {
                     me.inputDisplay.setValue(props.get_Text());
                     me.inputDisplay.setDisabled(false);
+                    me.isAutoUpdate = (me.inputDisplay.getValue()=='');
                 } else {
                     me.inputDisplay.setValue(this.textDefault);
                     me.inputDisplay.setDisabled(true);
diff --git a/apps/presentationeditor/main/app/view/HyperlinkSettingsDialog.js b/apps/presentationeditor/main/app/view/HyperlinkSettingsDialog.js
index b899adae5..3c50a2b31 100644
--- a/apps/presentationeditor/main/app/view/HyperlinkSettingsDialog.js
+++ b/apps/presentationeditor/main/app/view/HyperlinkSettingsDialog.js
@@ -142,7 +142,9 @@ define([
             me.inputUrl._input.on('input', function (e) {
                 me.isInputFirstChange && me.inputUrl.showError();
                 me.isInputFirstChange = false;
-                me.btnOk.setDisabled($.trim($(e.target).val())=='');
+                var val = $(e.target).val();
+                me.isAutoUpdate && me.inputDisplay.setValue(val);
+                me.btnOk.setDisabled($.trim(val)=='');
             });
 
             me.inputDisplay = new Common.UI.InputField({
@@ -153,6 +155,9 @@ define([
             }).on('changed:after', function() {
                 me.isTextChanged = true;
             });
+            me.inputDisplay._input.on('input', function (e) {
+                me.isAutoUpdate = ($(e.target).val()=='');
+            });
 
             me.inputTip = new Common.UI.InputField({
                 el          : $('#id-dlg-hyperlink-tip'),
@@ -189,6 +194,7 @@ define([
                 if (props.get_Text()!==null) {
                     me.inputDisplay.setValue(props.get_Text());
                     me.inputDisplay.setDisabled(false);
+                    me.isAutoUpdate = (me.inputDisplay.getValue()=='');
                 } else {
                     this.inputDisplay.setValue(this.textDefault);
                     this.inputDisplay.setDisabled(true);
@@ -367,6 +373,14 @@ define([
 
         onLinkTypeClick: function(type, btn, event) {
             this.ShowHideElem(type);
+            if (this.isAutoUpdate) {
+                if (type==c_oHyperlinkType.InternalLink) {
+                    var rec = this.internalList.getSelectedRec();
+                    this.inputDisplay.setValue(rec && (rec.get('level') || rec.get('index')<4) ? rec.get('name') : '');
+                } else {
+                    this.inputDisplay.setValue(this.inputUrl.getValue());
+                }
+            }
         },
 
         parseUrl: function(url) {
@@ -385,6 +399,7 @@ define([
 
         onSelectItem: function(picker, item, record, e){
             this.btnOk.setDisabled(record.get('index')==4);
+            this.isAutoUpdate && this.inputDisplay.setValue((record.get('level') || record.get('index')<4) ? record.get('name') : '');
         },
 
         textTitle:          'Hyperlink Settings',
diff --git a/apps/spreadsheeteditor/main/app/view/HyperlinkSettingsDialog.js b/apps/spreadsheeteditor/main/app/view/HyperlinkSettingsDialog.js
index 28d2ca4ec..3873b34b8 100644
--- a/apps/spreadsheeteditor/main/app/view/HyperlinkSettingsDialog.js
+++ b/apps/spreadsheeteditor/main/app/view/HyperlinkSettingsDialog.js
@@ -137,7 +137,9 @@ define([
             me.inputUrl._input.on('input', function (e) {
                 me.isInputFirstChange_url && me.inputUrl.showError();
                 me.isInputFirstChange_url = false;
-                me.btnOk.setDisabled($.trim($(e.target).val())=='');
+                var val = $(e.target).val();
+                me.isAutoUpdate && me.inputDisplay.setValue(val);
+                me.btnOk.setDisabled($.trim(val)=='');
             });
 
             me.inputRange = new Common.UI.InputField({
@@ -162,7 +164,9 @@ define([
             me.inputRange._input.on('input', function (e) {
                 me.isInputFirstChange_range && me.inputRange.showError();
                 me.isInputFirstChange_range = false;
-                me.btnOk.setDisabled($.trim($(e.target).val())=='');
+                var val = $(e.target).val();
+                me.isAutoUpdate && me.inputDisplay.setValue(me.internalList.getSelectedRec().get('name') + (val!=='' ? '!' + val : ''));
+                me.btnOk.setDisabled($.trim(val)=='');
             });
 
             me.inputDisplay = new Common.UI.InputField({
@@ -171,6 +175,9 @@ define([
                 validateOnBlur: false,
                 style       : 'width: 100%;'
             });
+            me.inputDisplay._input.on('input', function (e) {
+                me.isAutoUpdate = ($(e.target).val()=='');
+            });
 
             me.inputTip = new Common.UI.InputField({
                 el          : $('#id-dlg-hyperlink-tip'),
@@ -236,6 +243,7 @@ define([
                     this.inputTip.setValue(settings.props.asc_getTooltip());
                 }
                 this.inputDisplay.setDisabled(settings.isLock);
+                !settings.isLock && (this.isAutoUpdate = (this.inputDisplay.getValue()==''));
             }
         },
 
@@ -389,11 +397,35 @@ define([
 
         onLinkTypeClick: function(type, btn, event) {
             this.ShowHideElem(type);
+            if (this.isAutoUpdate) {
+                if (type==Asc.c_oAscHyperlinkType.RangeLink) {
+                    var rec = this.internalList.getSelectedRec(),
+                        list = rec && rec.get('level') ? rec.get('name') : '';
+                    if (rec && rec.get('type')==1) {
+                        this.inputDisplay.setValue(list);
+                    } else {
+                        var val = this.inputRange.getValue();
+                        this.inputDisplay.setValue(list + (list!=='' || val!=='' ? '!' : '') + val);
+                    }
+
+                } else {
+                    this.inputDisplay.setValue(this.inputUrl.getValue());
+                }
+            }
         },
 
         onSelectItem: function(picker, item, record, e){
             this.btnOk.setDisabled(record.get('level')==0 || record.get('type')==0 && $.trim(this.inputRange.getValue())=='');
             this.inputRange.setDisabled(record.get('type')==1 || record.get('level')==0);
+            if (this.isAutoUpdate) {
+                var list = record.get('level') ? record.get('name') : '';
+                if (record.get('type')==1) {
+                    this.inputDisplay.setValue(list);
+                } else {
+                    var val = this.inputRange.getValue();
+                    this.inputDisplay.setValue(list + ((list!=='' && val!=='') ? '!' : '') + val);
+                }
+            }
         },
 
         textTitle:          'Hyperlink Settings',

From 5b30dad42b29c72074d42123aea5f252adbf32d9 Mon Sep 17 00:00:00 2001
From: Julia Radzhabova <Julia.Radzhabova@onlyoffice.com>
Date: Wed, 11 Mar 2020 16:56:06 +0300
Subject: [PATCH 11/12] Bug 44386: external link is equal to display field

---
 .../main/app/view/HyperlinkSettingsDialog.js  | 22 +++++++++++++------
 .../main/app/view/HyperlinkSettingsDialog.js  | 20 ++++++++++++-----
 .../main/app/view/HyperlinkSettingsDialog.js  | 11 +++++-----
 3 files changed, 35 insertions(+), 18 deletions(-)

diff --git a/apps/documenteditor/main/app/view/HyperlinkSettingsDialog.js b/apps/documenteditor/main/app/view/HyperlinkSettingsDialog.js
index d90077177..c0a739ef5 100644
--- a/apps/documenteditor/main/app/view/HyperlinkSettingsDialog.js
+++ b/apps/documenteditor/main/app/view/HyperlinkSettingsDialog.js
@@ -141,7 +141,10 @@ define([
                 me.isInputFirstChange && me.inputUrl.showError();
                 me.isInputFirstChange = false;
                 var val = $(e.target).val();
-                me.isAutoUpdate && me.inputDisplay.setValue(val);
+                if (me.isAutoUpdate) {
+                    me.inputDisplay.setValue(val);
+                    me.isTextChanged = true;
+                }
                 me.btnOk.setDisabled($.trim(val)=='');
             });
 
@@ -279,12 +282,16 @@ define([
                 } else {
                     this.inputDisplay.setValue(this.inputUrl.getValue());
                 }
+                this.isTextChanged = true;
             }
         },
 
         onSelectItem: function(picker, item, record, e){
             this.btnOk.setDisabled(record.get('level')==0 && record.get('index')>0);
-            this.isAutoUpdate && this.inputDisplay.setValue((record.get('level') || record.get('index')==0) ? record.get('name') : '');
+            if (this.isAutoUpdate) {
+                this.inputDisplay.setValue((record.get('level') || record.get('index')==0) ? record.get('name') : '');
+                this.isTextChanged = true;
+            }
         },
 
         show: function() {
@@ -336,7 +343,7 @@ define([
                 if (props.get_Text() !== null) {
                     me.inputDisplay.setValue(props.get_Text());
                     me.inputDisplay.setDisabled(false);
-                    me.isAutoUpdate = (me.inputDisplay.getValue()=='');
+                    me.isAutoUpdate = (me.inputDisplay.getValue()=='' || type == c_oHyperlinkType.WebLink && me.inputUrl.getValue()==me.inputDisplay.getValue());
                 } else {
                     me.inputDisplay.setValue(this.textDefault);
                     me.inputDisplay.setDisabled(true);
@@ -352,9 +359,10 @@ define([
         getSettings: function () {
             var me      = this,
                 props   = new Asc.CHyperlinkProperty(),
-                display = '';
+                display = '',
+                type = this.btnExternal.isActive() ? c_oHyperlinkType.WebLink : c_oHyperlinkType.InternalLink;
 
-            if (this.btnExternal.isActive()) {//WebLink
+            if (type==c_oHyperlinkType.WebLink) {//WebLink
                 var url     = $.trim(me.inputUrl.getValue());
 
                 if (! /(((^https?)|(^ftp)):\/\/)|(^mailto:)/i.test(url) )
@@ -377,8 +385,8 @@ define([
                 }
             }
 
-            if (!me.inputDisplay.isDisabled() && ( this.isTextChanged || _.isEmpty(me.inputDisplay.getValue()))) {
-                if (_.isEmpty(me.inputDisplay.getValue()))
+            if (!me.inputDisplay.isDisabled() && ( me.isTextChanged || _.isEmpty(me.inputDisplay.getValue()))) {
+                if (_.isEmpty(me.inputDisplay.getValue()) || type==c_oHyperlinkType.WebLink && me.isAutoUpdate)
                     me.inputDisplay.setValue(display);
                 props.put_Text(me.inputDisplay.getValue());
             } else {
diff --git a/apps/presentationeditor/main/app/view/HyperlinkSettingsDialog.js b/apps/presentationeditor/main/app/view/HyperlinkSettingsDialog.js
index 3c50a2b31..b06c3a42f 100644
--- a/apps/presentationeditor/main/app/view/HyperlinkSettingsDialog.js
+++ b/apps/presentationeditor/main/app/view/HyperlinkSettingsDialog.js
@@ -143,7 +143,10 @@ define([
                 me.isInputFirstChange && me.inputUrl.showError();
                 me.isInputFirstChange = false;
                 var val = $(e.target).val();
-                me.isAutoUpdate && me.inputDisplay.setValue(val);
+                if (me.isAutoUpdate) {
+                    me.inputDisplay.setValue(val);
+                    me.isTextChanged = true;
+                }
                 me.btnOk.setDisabled($.trim(val)=='');
             });
 
@@ -194,7 +197,7 @@ define([
                 if (props.get_Text()!==null) {
                     me.inputDisplay.setValue(props.get_Text());
                     me.inputDisplay.setDisabled(false);
-                    me.isAutoUpdate = (me.inputDisplay.getValue()=='');
+                    me.isAutoUpdate = (me.inputDisplay.getValue()=='' || type == c_oHyperlinkType.WebLink && me.inputUrl.getValue()==me.inputDisplay.getValue());
                 } else {
                     this.inputDisplay.setValue(this.textDefault);
                     this.inputDisplay.setDisabled(true);
@@ -213,8 +216,9 @@ define([
         getSettings: function () {
             var me      = this,
                 props   = new Asc.CHyperlinkProperty();
-            var def_display = '';
-            if (this.btnInternal.isActive()) {//InternalLink
+            var def_display = '',
+                type = this.btnExternal.isActive() ? c_oHyperlinkType.WebLink : c_oHyperlinkType.InternalLink;
+            if (type==c_oHyperlinkType.InternalLink) {//InternalLink
                 var url = "ppaction://hlink";
                 var tip = '';
                 var txttip = me.inputTip.getValue();
@@ -237,7 +241,7 @@ define([
             }
 
             if (!me.inputDisplay.isDisabled() && (me.isTextChanged || _.isEmpty(me.inputDisplay.getValue()))) {
-                if (_.isEmpty(me.inputDisplay.getValue()))
+                if (_.isEmpty(me.inputDisplay.getValue()) || type==c_oHyperlinkType.WebLink && me.isAutoUpdate)
                     me.inputDisplay.setValue(def_display);
                 props.put_Text(me.inputDisplay.getValue());
             }
@@ -380,6 +384,7 @@ define([
                 } else {
                     this.inputDisplay.setValue(this.inputUrl.getValue());
                 }
+                this.isTextChanged = true;
             }
         },
 
@@ -399,7 +404,10 @@ define([
 
         onSelectItem: function(picker, item, record, e){
             this.btnOk.setDisabled(record.get('index')==4);
-            this.isAutoUpdate && this.inputDisplay.setValue((record.get('level') || record.get('index')<4) ? record.get('name') : '');
+            if (this.isAutoUpdate) {
+                this.inputDisplay.setValue((record.get('level') || record.get('index')<4) ? record.get('name') : '');
+                this.isTextChanged = true;
+            }
         },
 
         textTitle:          'Hyperlink Settings',
diff --git a/apps/spreadsheeteditor/main/app/view/HyperlinkSettingsDialog.js b/apps/spreadsheeteditor/main/app/view/HyperlinkSettingsDialog.js
index 3873b34b8..606833b04 100644
--- a/apps/spreadsheeteditor/main/app/view/HyperlinkSettingsDialog.js
+++ b/apps/spreadsheeteditor/main/app/view/HyperlinkSettingsDialog.js
@@ -243,16 +243,17 @@ define([
                     this.inputTip.setValue(settings.props.asc_getTooltip());
                 }
                 this.inputDisplay.setDisabled(settings.isLock);
-                !settings.isLock && (this.isAutoUpdate = (this.inputDisplay.getValue()==''));
+                !settings.isLock && (this.isAutoUpdate = (this.inputDisplay.getValue()=='' || type == Asc.c_oAscHyperlinkType.WebLink && me.inputUrl.getValue()==me.inputDisplay.getValue()));
             }
         },
 
         getSettings: function() {
             var props = new Asc.asc_CHyperlink(),
-                def_display = "";
-            props.asc_setType(this.btnInternal.isActive() ? Asc.c_oAscHyperlinkType.RangeLink : Asc.c_oAscHyperlinkType.WebLink);
+                def_display = "",
+                type = this.btnInternal.isActive() ? Asc.c_oAscHyperlinkType.RangeLink : Asc.c_oAscHyperlinkType.WebLink;
+            props.asc_setType(type);
 
-            if (this.btnInternal.isActive()) {
+            if (type==Asc.c_oAscHyperlinkType.RangeLink) {
                 var rec = this.internalList.getSelectedRec();
                 if (rec && rec.get('level')>0) {
                     if (rec.get('type')) {// named range
@@ -277,7 +278,7 @@ define([
             if (this.inputDisplay.isDisabled())
                 props.asc_setText(null);
             else {
-                if (_.isEmpty(this.inputDisplay.getValue()))
+                if (_.isEmpty(this.inputDisplay.getValue()) || type==Asc.c_oAscHyperlinkType.WebLink && this.isAutoUpdate)
                     this.inputDisplay.setValue(def_display);
                 props.asc_setText(this.inputDisplay.getValue());
             }

From 9c1a70cf3cb6fde0e249841476bc4d5816c16e01 Mon Sep 17 00:00:00 2001
From: Julia Radzhabova <Julia.Radzhabova@onlyoffice.com>
Date: Wed, 11 Mar 2020 17:07:40 +0300
Subject: [PATCH 12/12] [SSE] Bug 44386: internal link is equal to display
 field

---
 .../main/app/view/HyperlinkSettingsDialog.js                | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/apps/spreadsheeteditor/main/app/view/HyperlinkSettingsDialog.js b/apps/spreadsheeteditor/main/app/view/HyperlinkSettingsDialog.js
index 606833b04..48c0e40df 100644
--- a/apps/spreadsheeteditor/main/app/view/HyperlinkSettingsDialog.js
+++ b/apps/spreadsheeteditor/main/app/view/HyperlinkSettingsDialog.js
@@ -223,6 +223,7 @@ define([
                 me.btnInternal.setDisabled(!settings.allowInternal && (type == Asc.c_oAscHyperlinkType.WebLink));
                 me.btnExternal.setDisabled(!settings.allowInternal && (type == Asc.c_oAscHyperlinkType.RangeLink));
 
+                var defrange = '';
                 if (!settings.props) {
                     this.inputDisplay.setValue(settings.isLock ? this.textDefault : settings.text);
                     this.focusedInput = this.inputUrl.cmpEl.find('input');
@@ -231,8 +232,10 @@ define([
                         if (settings.props.asc_getSheet()) {
                             this.inputRange.setValue(settings.props.asc_getRange());
                             this.focusedInput = this.inputRange.cmpEl.find('input');
+                            defrange = settings.props.asc_getSheet() + '!' +  settings.props.asc_getRange();
                         } else {// named range
                             this.inputRange.setDisabled(true);
+                            defrange = settings.props.asc_getLocation();
                         }
                     } else {
                         this.inputUrl.setValue(settings.props.asc_getHyperlinkUrl().replace(new RegExp(" ",'g'), "%20"));
@@ -243,7 +246,8 @@ define([
                     this.inputTip.setValue(settings.props.asc_getTooltip());
                 }
                 this.inputDisplay.setDisabled(settings.isLock);
-                !settings.isLock && (this.isAutoUpdate = (this.inputDisplay.getValue()=='' || type == Asc.c_oAscHyperlinkType.WebLink && me.inputUrl.getValue()==me.inputDisplay.getValue()));
+                !settings.isLock && (this.isAutoUpdate = (this.inputDisplay.getValue()=='' || type == Asc.c_oAscHyperlinkType.WebLink && me.inputUrl.getValue()==me.inputDisplay.getValue()) ||
+                                                                                              type == Asc.c_oAscHyperlinkType.RangeLink && defrange==me.inputDisplay.getValue());
             }
         },