From b713a7fe09d9d18776066e631464f6a04e71de6c Mon Sep 17 00:00:00 2001 From: Julia Radzhabova Date: Fri, 18 Jun 2021 13:50:43 +0300 Subject: [PATCH 1/8] [SSE] Fix Bug 50788 --- apps/spreadsheeteditor/main/app/controller/Main.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/spreadsheeteditor/main/app/controller/Main.js b/apps/spreadsheeteditor/main/app/controller/Main.js index 1c151ad97..b4a7ff145 100644 --- a/apps/spreadsheeteditor/main/app/controller/Main.js +++ b/apps/spreadsheeteditor/main/app/controller/Main.js @@ -1739,7 +1739,7 @@ define([ } if (!Common.Utils.ModalWindow.isVisible() || $('.asc-window.modal.alert[data-value=' + id + ']').length<1) - Common.UI.alert(config).$window.attr('data-value', id); + setTimeout(function() {Common.UI.alert(config).$window.attr('data-value', id);}, 1); (id!==undefined) && Common.component.Analytics.trackEvent('Internal Error', id.toString()); }, From f39449e57d2bd2ea8aab59f510755e70a51007e5 Mon Sep 17 00:00:00 2001 From: Julia Radzhabova Date: Fri, 18 Jun 2021 14:33:57 +0300 Subject: [PATCH 2/8] [SSE] Fix Bug 50762 --- apps/spreadsheeteditor/main/app/view/ChartSettingsDlg.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/apps/spreadsheeteditor/main/app/view/ChartSettingsDlg.js b/apps/spreadsheeteditor/main/app/view/ChartSettingsDlg.js index ad14d1b3b..687f68387 100644 --- a/apps/spreadsheeteditor/main/app/view/ChartSettingsDlg.js +++ b/apps/spreadsheeteditor/main/app/view/ChartSettingsDlg.js @@ -1419,6 +1419,8 @@ define([ 'text!spreadsheeteditor/main/app/template/ChartSettingsDlg.template' this.cmbLegendPos.setValue(props.getLegendPos()); this.updateDataLabels(this._state.ChartType, props.getDataLabelsPos()); + this.cmbDataLabels.setDisabled(this._state.ChartType==Asc.c_oAscChartTypeSettings.surfaceNormal || + this._state.ChartType == Asc.c_oAscChartTypeSettings.surfaceWireframe); this.chSeriesName.setValue(this.chartSettings.getShowSerName(), true); this.chCategoryName.setValue(this.chartSettings.getShowCatName(), true); From 67397c762d4b351a95c00720591b5edbc8505d77 Mon Sep 17 00:00:00 2001 From: Julia Radzhabova Date: Fri, 18 Jun 2021 14:34:26 +0300 Subject: [PATCH 3/8] [SSE] Fix icons for surface and contour chart types --- .../main/app/view/ChartTypeDialog.js | 21 +++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/apps/spreadsheeteditor/main/app/view/ChartTypeDialog.js b/apps/spreadsheeteditor/main/app/view/ChartTypeDialog.js index ba3f190ee..a7708b77c 100644 --- a/apps/spreadsheeteditor/main/app/view/ChartTypeDialog.js +++ b/apps/spreadsheeteditor/main/app/view/ChartTypeDialog.js @@ -232,8 +232,25 @@ define([ this.mnuChartTypePicker.selectRecord(record, true); if (record) { this.btnChartType.setIconCls('svgicon ' + 'chart-' + record.get('iconCls')); - } else - this.btnChartType.setIconCls('svgicon'); + } else { + var iconcls = ''; + switch (this.currentChartType) { + case Asc.c_oAscChartTypeSettings.surfaceNormal: + iconcls = 'chart-surface-normal'; + break; + case Asc.c_oAscChartTypeSettings.surfaceWireframe: + iconcls = 'chart-surface-wireframe'; + break; + case Asc.c_oAscChartTypeSettings.contourNormal: + iconcls = 'chart-contour-wireframe'; + break; + case Asc.c_oAscChartTypeSettings.contourWireframe: + iconcls = 'chart-contour-wireframe'; + break; + + } + this.btnChartType.setIconCls('svgicon ' + iconcls); + } this.seriesList.on('item:add', _.bind(this.addControls, this)); this.seriesList.on('item:change', _.bind(this.addControls, this)); this.ShowHideSettings(this.currentChartType); From bd3629838e0d205b9c34acddfb2018391a749948 Mon Sep 17 00:00:00 2001 From: Julia Radzhabova Date: Fri, 18 Jun 2021 15:24:44 +0300 Subject: [PATCH 4/8] [DE] Fix Bug 50920 --- apps/documenteditor/main/app/controller/Toolbar.js | 6 +++++- apps/documenteditor/main/app/view/Toolbar.js | 5 ----- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/apps/documenteditor/main/app/controller/Toolbar.js b/apps/documenteditor/main/app/controller/Toolbar.js index 8a36cc75b..a48fe02ad 100644 --- a/apps/documenteditor/main/app/controller/Toolbar.js +++ b/apps/documenteditor/main/app/controller/Toolbar.js @@ -1227,8 +1227,12 @@ define([ onHorizontalAlign: function(type, btn, e) { this._state.pralign = undefined; - if (this.api) + if (this.api) { + if (!btn.pressed) { + type = (type==1) ? 3 : 1; + } this.api.put_PrAlign(type); + } Common.NotificationCenter.trigger('edit:complete', this.toolbar); Common.component.Analytics.trackEvent('ToolBar', 'Align'); diff --git a/apps/documenteditor/main/app/view/Toolbar.js b/apps/documenteditor/main/app/view/Toolbar.js index 3b3ebca59..534b5fad1 100644 --- a/apps/documenteditor/main/app/view/Toolbar.js +++ b/apps/documenteditor/main/app/view/Toolbar.js @@ -311,7 +311,6 @@ define([ cls: 'btn-toolbar', iconCls: 'toolbar__icon btn-align-left', enableToggle: true, - allowDepress: false, toggleGroup: 'alignGroup' }); this.paragraphControls.push(this.btnAlignLeft); @@ -321,7 +320,6 @@ define([ cls: 'btn-toolbar', iconCls: 'toolbar__icon btn-align-center', enableToggle: true, - allowDepress: false, toggleGroup: 'alignGroup' }); this.paragraphControls.push(this.btnAlignCenter); @@ -331,7 +329,6 @@ define([ cls: 'btn-toolbar', iconCls: 'toolbar__icon btn-align-right', enableToggle: true, - allowDepress: false, toggleGroup: 'alignGroup' }); this.paragraphControls.push(this.btnAlignRight); @@ -341,12 +338,10 @@ define([ cls: 'btn-toolbar', iconCls: 'toolbar__icon btn-align-just', enableToggle: true, - allowDepress: false, toggleGroup: 'alignGroup' }); this.paragraphControls.push(this.btnAlignJust); - this.btnDecLeftOffset = new Common.UI.Button({ id: 'id-toolbar-btn-decoffset', cls: 'btn-toolbar', From 1fd322493f0aab7f5466fed1a58993dfd8bab0ad Mon Sep 17 00:00:00 2001 From: Julia Radzhabova Date: Fri, 18 Jun 2021 16:08:47 +0300 Subject: [PATCH 5/8] Refactoring --- apps/api/documents/api.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/api/documents/api.js b/apps/api/documents/api.js index 52503867a..1ad4fc5c1 100644 --- a/apps/api/documents/api.js +++ b/apps/api/documents/api.js @@ -866,7 +866,7 @@ path += app + "/"; path += (config.type === "mobile" || isSafari_mobile) ? "mobile" - : (config.type === "embedded" || (app=='documenteditor') && config.document.permissions && (config.document.permissions.fillForms===true) && (config.document.permissions.edit === false) && (config.editorConfig.mode !== 'view')) + : (config.type === "embedded" || (app=='documenteditor') && config.document && config.document.permissions && (config.document.permissions.fillForms===true) && (config.document.permissions.edit === false) && (config.editorConfig.mode !== 'view')) ? "embed" : "main"; From 41d95920a7170943c5e38d923e0a0e62bbf76a7b Mon Sep 17 00:00:00 2001 From: Julia Radzhabova Date: Fri, 18 Jun 2021 16:53:50 +0300 Subject: [PATCH 6/8] Fix loading mask on document opening --- apps/common/main/lib/util/utils.js | 8 ++++++++ apps/common/main/resources/less/loadmask.less | 1 + apps/documenteditor/main/app/controller/Main.js | 4 ++-- apps/presentationeditor/main/app/controller/Main.js | 4 ++-- apps/spreadsheeteditor/main/app/controller/Main.js | 4 ++-- 5 files changed, 15 insertions(+), 6 deletions(-) diff --git a/apps/common/main/lib/util/utils.js b/apps/common/main/lib/util/utils.js index 7d41f09ff..e230a013d 100644 --- a/apps/common/main/lib/util/utils.js +++ b/apps/common/main/lib/util/utils.js @@ -641,6 +641,14 @@ Common.Utils.String = new (function() { var nTrailingChar = 0xDC00 | (nUnicode & 0x3FF); return String.fromCharCode(nLeadingChar) + String.fromCharCode(nTrailingChar); } + }, + + fixedDigits: function(num, digits, fill) { + (fill===undefined) && (fill = '0'); + var strfill = "", + str = num.toString(); + for (var i=str.length; i Date: Fri, 18 Jun 2021 17:17:55 +0300 Subject: [PATCH 7/8] Fix Bug 50924 --- apps/api/documents/api.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/apps/api/documents/api.js b/apps/api/documents/api.js index 1ad4fc5c1..1dfdf981b 100644 --- a/apps/api/documents/api.js +++ b/apps/api/documents/api.js @@ -866,7 +866,8 @@ path += app + "/"; path += (config.type === "mobile" || isSafari_mobile) ? "mobile" - : (config.type === "embedded" || (app=='documenteditor') && config.document && config.document.permissions && (config.document.permissions.fillForms===true) && (config.document.permissions.edit === false) && (config.editorConfig.mode !== 'view')) + : (config.type === "embedded" || (app=='documenteditor') && config.document && config.document.permissions && (config.document.permissions.fillForms===true) && + (config.document.permissions.edit === false) && (config.document.permissions.review !== true) && (config.editorConfig.mode !== 'view')) ? "embed" : "main"; From 177a4dd5ecd933c326b6b1d1b0109e047116f47b Mon Sep 17 00:00:00 2001 From: Julia Radzhabova Date: Fri, 18 Jun 2021 17:22:38 +0300 Subject: [PATCH 8/8] Fix layout for tt lang --- apps/common/main/lib/view/SearchDialog.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/common/main/lib/view/SearchDialog.js b/apps/common/main/lib/view/SearchDialog.js index cd18d12f0..3a6039a56 100644 --- a/apps/common/main/lib/view/SearchDialog.js +++ b/apps/common/main/lib/view/SearchDialog.js @@ -99,7 +99,7 @@ '
', ''