From 1d253d5eb3636d2c84dc22aff7b2c968cbc48eab Mon Sep 17 00:00:00 2001 From: minenice55 Date: Mon, 8 Apr 2024 20:24:08 -0400 Subject: [PATCH] let mis-packed games load from res timing display tweak --- Assets/Scripts/GameManager.cs | 5 ----- Assets/Scripts/UI/Overlays/TimingAccuracyDisplay.cs | 9 ++------- 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/Assets/Scripts/GameManager.cs b/Assets/Scripts/GameManager.cs index f381ffbdc..673a98f32 100644 --- a/Assets/Scripts/GameManager.cs +++ b/Assets/Scripts/GameManager.cs @@ -1246,11 +1246,6 @@ namespace HeavenStudio try { Debug.LogWarning($"Game prefab wasn't cached, loading from assetbundle for game {name}"); - if (gameInfo.LoadingPrefab) - { - Debug.LogWarning($"Game {name} is already loading, using noGame"); - return Resources.Load($"Games/noGame"); - } return gameInfo.LoadGamePrefab(); } catch (Exception e) diff --git a/Assets/Scripts/UI/Overlays/TimingAccuracyDisplay.cs b/Assets/Scripts/UI/Overlays/TimingAccuracyDisplay.cs index 0487d077c..473415231 100644 --- a/Assets/Scripts/UI/Overlays/TimingAccuracyDisplay.cs +++ b/Assets/Scripts/UI/Overlays/TimingAccuracyDisplay.cs @@ -155,6 +155,8 @@ namespace HeavenStudio.Common { case Rating.OK: it = OK; + // makes the explosion smaller with less accurate inputs + it.transform.localScale = Vector3.one * (1f - (frac / 2f)); break; case Rating.Just: it = Just; @@ -165,13 +167,6 @@ namespace HeavenStudio.Common } } - // makes the explosion smaller with less accurate inputs - if (it == OK) - { - float okScalar = 1 - (frac / 2); - it.transform.localScale = new Vector3(okScalar, okScalar, it.transform.localScale.z); - } - it.transform.position = barTransform.position + new Vector3(0, barTransform.localScale.y * y, 0); it.GetComponent().Play(); }