From 1ac1875a8654ef5f5059eaf8f2f8d52bc4c11233 Mon Sep 17 00:00:00 2001
From: derrod <xlnedder@gmail.com>
Date: Sat, 23 May 2020 16:55:18 +0200
Subject: [PATCH] [models/utils] Catch and log exception when opening file
 fails

---
 legendary/models/game.py |  1 +
 legendary/utils/lfs.py   | 22 +++++++++++++---------
 2 files changed, 14 insertions(+), 9 deletions(-)

diff --git a/legendary/models/game.py b/legendary/models/game.py
index 36b2b03..14afae0 100644
--- a/legendary/models/game.py
+++ b/legendary/models/game.py
@@ -137,3 +137,4 @@ class VerifyResult(Enum):
     HASH_MATCH = 0
     HASH_MISMATCH = 1
     FILE_MISSING = 2
+    OTHER_ERROR = 3
diff --git a/legendary/utils/lfs.py b/legendary/utils/lfs.py
index ad73420..e293ac3 100644
--- a/legendary/utils/lfs.py
+++ b/legendary/utils/lfs.py
@@ -50,16 +50,20 @@ def validate_files(base_path: str, filelist: List[tuple], hash_type='sha1') -> I
             yield VerifyResult.FILE_MISSING, file_path, ''
             continue
 
-        with open(full_path, 'rb') as f:
-            real_file_hash = hashlib.new(hash_type)
-            while chunk := f.read(8192):
-                real_file_hash.update(chunk)
+        try:
+            with open(full_path, 'rb') as f:
+                real_file_hash = hashlib.new(hash_type)
+                while chunk := f.read(1024*1024):
+                    real_file_hash.update(chunk)
 
-            result_hash = real_file_hash.hexdigest()
-            if file_hash != result_hash:
-                yield VerifyResult.HASH_MISMATCH, file_path, result_hash
-            else:
-                yield VerifyResult.HASH_MATCH, file_path, result_hash
+                result_hash = real_file_hash.hexdigest()
+                if file_hash != result_hash:
+                    yield VerifyResult.HASH_MISMATCH, file_path, result_hash
+                else:
+                    yield VerifyResult.HASH_MATCH, file_path, result_hash
+        except Exception as e:
+            logger.fatal(f'Could not verify "{file_path}"; opening failed with: {e!r}')
+            yield VerifyResult.OTHER_ERROR, file_path, ''
 
 
 def clean_filename(filename):