From 47fb450bebbbbfbba7c3416e575233d84823e005 Mon Sep 17 00:00:00 2001 From: Sam Lantinga Date: Fri, 2 Nov 2018 17:18:03 -0700 Subject: [PATCH] Fixed bug 4315 - little Warning in Android_JNI_CaptureAudioBuffer Sylvain SDL_android.c src/core/android/SDL_android.c:1302:5: warning: variable 'br' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized] default: ^~~~~~~ src/core/android/SDL_android.c:1306:12: note: uninitialized use occurs here return br; ^~ src/core/android/SDL_android.c:1270:12: note: initialize the variable 'br' to silence this warning jint br; ^ Maybe we could add some basics warning flags, not to see all warnings, but so that new warnings are caught sooner. I would go for -Wall -Wextra, and some -Wno-warning for the allowed warnings. --- Android.mk | 16 ++++++++++++++++ src/core/android/SDL_android.c | 2 +- 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/Android.mk b/Android.mk index 9ce879a11..043576c1a 100644 --- a/Android.mk +++ b/Android.mk @@ -53,6 +53,22 @@ LOCAL_SRC_FILES := \ LOCAL_SHARED_LIBRARIES := hidapi LOCAL_CFLAGS += -DGL_GLEXT_PROTOTYPES +LOCAL_CFLAGS += \ + -Wall -Wextra \ + -Wdocumentation \ + -Wdocumentation-unknown-command \ + -Wmissing-prototypes \ + -Wunreachable-code-break \ + -Wunneeded-internal-declaration \ + -Wmissing-variable-declarations \ + -Wfloat-conversion \ + -Wshorten-64-to-32 \ + -Wunreachable-code-return + +# Warnings we haven't fixed (yet) +LOCAL_CFLAGS += -Wno-unused-parameter -Wno-sign-compare + + LOCAL_LDLIBS := -ldl -lGLESv1_CM -lGLESv2 -llog -landroid ifeq ($(NDK_DEBUG),1) diff --git a/src/core/android/SDL_android.c b/src/core/android/SDL_android.c index 2c6115fd9..1ccfe6776 100644 --- a/src/core/android/SDL_android.c +++ b/src/core/android/SDL_android.c @@ -1261,7 +1261,7 @@ int Android_JNI_CaptureAudioBuffer(void *buffer, int buflen) { JNIEnv *env = Android_JNI_GetEnv(); jboolean isCopy = JNI_FALSE; - jint br; + jint br = -1; switch (captureBufferFormat) { case ENCODING_PCM_8BIT: