From b30e396ba1139d79d432f1c9887b29d212910da6 Mon Sep 17 00:00:00 2001 From: Sam Lantinga Date: Sun, 10 Nov 2013 17:56:07 -0800 Subject: [PATCH] Fixed bug 1965 - Mac: dead code for supporting OS 10.4 Alex Szpakowski The new patch removes all the truly obsolete code I could find. I tested on OS 10.8 and OS 10.5. --- src/joystick/darwin/SDL_sysjoystick.c | 5 --- src/video/cocoa/SDL_cocoakeyboard.m | 49 +-------------------------- 2 files changed, 1 insertion(+), 53 deletions(-) diff --git a/src/joystick/darwin/SDL_sysjoystick.c b/src/joystick/darwin/SDL_sysjoystick.c index 55ec41ed8..125fdc0e2 100644 --- a/src/joystick/darwin/SDL_sysjoystick.c +++ b/src/joystick/darwin/SDL_sysjoystick.c @@ -32,12 +32,7 @@ #include #include #include -#ifdef MACOS_10_0_4 -#include -#else -/* The header was moved here in Mac OS X 10.1 */ #include -#endif #include #include #include diff --git a/src/video/cocoa/SDL_cocoakeyboard.m b/src/video/cocoa/SDL_cocoakeyboard.m index 8a6b87422..f8764fb25 100644 --- a/src/video/cocoa/SDL_cocoakeyboard.m +++ b/src/video/cocoa/SDL_cocoakeyboard.m @@ -198,45 +198,6 @@ @end -/* This is the original behavior, before support was added for - * differentiating between left and right versions of the keys. - */ -static void -DoUnsidedModifiers(unsigned short scancode, - unsigned int oldMods, unsigned int newMods) -{ - const int mapping[] = { - SDL_SCANCODE_CAPSLOCK, - SDL_SCANCODE_LSHIFT, - SDL_SCANCODE_LCTRL, - SDL_SCANCODE_LALT, - SDL_SCANCODE_LGUI - }; - unsigned int i, bit; - - /* Iterate through the bits, testing each against the current modifiers */ - for (i = 0, bit = NSAlphaShiftKeyMask; bit <= NSCommandKeyMask; bit <<= 1, ++i) { - unsigned int oldMask, newMask; - - oldMask = oldMods & bit; - newMask = newMods & bit; - - if (oldMask && oldMask != newMask) { /* modifier up event */ - /* If this was Caps Lock, we need some additional voodoo to make SDL happy */ - if (bit == NSAlphaShiftKeyMask) { - SDL_SendKeyboardKey(SDL_PRESSED, mapping[i]); - } - SDL_SendKeyboardKey(SDL_RELEASED, mapping[i]); - } else if (newMask && oldMask != newMask) { /* modifier down event */ - SDL_SendKeyboardKey(SDL_PRESSED, mapping[i]); - /* If this was Caps Lock, we need some additional voodoo to make SDL happy */ - if (bit == NSAlphaShiftKeyMask) { - SDL_SendKeyboardKey(SDL_RELEASED, mapping[i]); - } - } - } -} - /* This is a helper function for HandleModifierSide. This * function reverts back to behavior before the distinction between * sides was made. @@ -458,15 +419,7 @@ HandleModifiers(_THIS, unsigned short scancode, unsigned int modifierFlags) return; } - /* - * Starting with Panther (10.3.0), the ability to distinguish between - * left side and right side modifiers is available. - */ - if (data->osversion >= 0x1030) { - DoSidedModifiers(scancode, data->modifierFlags, modifierFlags); - } else { - DoUnsidedModifiers(scancode, data->modifierFlags, modifierFlags); - } + DoSidedModifiers(scancode, data->modifierFlags, modifierFlags); data->modifierFlags = modifierFlags; }