From ddbbef88e3e86d40783bf87ff53f7b93f75cdf7e Mon Sep 17 00:00:00 2001 From: "Ryan C. Gordon" Date: Wed, 23 Aug 2023 16:11:08 -0400 Subject: [PATCH] emscriptenaudio: Don't bother undefining things about to be unreachable. Since the top-level table is getting undefined, all the things in it will be unreachable and eligible for garbage collection without explicitly nulling them out. (cherry picked from commit 5191b20541fce0e3b3071124ced69c31fcaeb783) --- src/audio/emscripten/SDL_emscriptenaudio.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/audio/emscripten/SDL_emscriptenaudio.c b/src/audio/emscripten/SDL_emscriptenaudio.c index 9623d4aaa..7d5fad3b6 100644 --- a/src/audio/emscripten/SDL_emscriptenaudio.c +++ b/src/audio/emscripten/SDL_emscriptenaudio.c @@ -163,32 +163,22 @@ static void EMSCRIPTENAUDIO_CloseDevice(_THIS) for (var i = 0; i < tracks.length; i++) { SDL2.capture.stream.removeTrack(tracks[i]); } - SDL2.capture.stream = undefined; } if (SDL2.capture.scriptProcessorNode !== undefined) { SDL2.capture.scriptProcessorNode.onaudioprocess = function(audioProcessingEvent) {}; SDL2.capture.scriptProcessorNode.disconnect(); - SDL2.capture.scriptProcessorNode = undefined; } if (SDL2.capture.mediaStreamNode !== undefined) { SDL2.capture.mediaStreamNode.disconnect(); - SDL2.capture.mediaStreamNode = undefined; - } - if (SDL2.capture.silenceBuffer !== undefined) { - SDL2.capture.silenceBuffer = undefined } SDL2.capture = undefined; } else { if (SDL2.audio.scriptProcessorNode != undefined) { SDL2.audio.scriptProcessorNode.disconnect(); - SDL2.audio.scriptProcessorNode = undefined; } if (SDL2.audio.silenceTimer !== undefined) { clearInterval(SDL2.audio.silenceTimer); } - if (SDL2.audio.silenceBuffer !== undefined) { - SDL2.audio.silenceBuffer = undefined - } SDL2.audio = undefined; } if ((SDL2.audioContext !== undefined) && (SDL2.audio === undefined) && (SDL2.capture === undefined)) {