From e7c4575719ba104ee7173640f9f82e37b9446f90 Mon Sep 17 00:00:00 2001 From: Lukas Senionis Date: Thu, 21 Dec 2023 15:11:32 +0200 Subject: [PATCH] Use crc16 return value when calculating GUID Fixes the regression introduced by 919cd56b20c59249bdde3bb005aeeb8f6550f3e3 (cherry picked from commit a2e05480d63cac530269c846422e7de3b44e830f) --- src/joystick/SDL_joystick.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/joystick/SDL_joystick.c b/src/joystick/SDL_joystick.c index ec335e4cf..a4951f258 100644 --- a/src/joystick/SDL_joystick.c +++ b/src/joystick/SDL_joystick.c @@ -2458,11 +2458,11 @@ SDL_JoystickGUID SDL_CreateJoystickGUID(Uint16 bus, Uint16 vendor, Uint16 produc SDL_zero(guid); if (vendor_name && *vendor_name && product_name && *product_name) { - SDL_crc16(crc, vendor_name, SDL_strlen(vendor_name)); - SDL_crc16(crc, " ", 1); - SDL_crc16(crc, product_name, SDL_strlen(product_name)); + crc = SDL_crc16(crc, vendor_name, SDL_strlen(vendor_name)); + crc = SDL_crc16(crc, " ", 1); + crc = SDL_crc16(crc, product_name, SDL_strlen(product_name)); } else if (product_name) { - SDL_crc16(crc, product_name, SDL_strlen(product_name)); + crc = SDL_crc16(crc, product_name, SDL_strlen(product_name)); } /* We only need 16 bits for each of these; space them out to fill 128. */