From 20583f05605d203fbaf231e6bf1229a58a11a260 Mon Sep 17 00:00:00 2001 From: "pbos@chromium.org" Date: Wed, 4 Jun 2014 08:54:07 +0000 Subject: [PATCH] Add virtual dtor to LibcurlWrapper. LibcurlWrapper is deleted but contains no virtual destructor, triggering warnings with -Wdelete-non-virtual-dtor in clang++. R=ivanpe@chromium.org Review URL: https://breakpad.appspot.com/7664002 git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1337 4c0a9323-5329-0410-9bdc-e9ce6186880e --- src/common/linux/libcurl_wrapper.cc | 2 ++ src/common/linux/libcurl_wrapper.h | 1 + 2 files changed, 3 insertions(+) diff --git a/src/common/linux/libcurl_wrapper.cc b/src/common/linux/libcurl_wrapper.cc index 08307f02..4ff9bb01 100644 --- a/src/common/linux/libcurl_wrapper.cc +++ b/src/common/linux/libcurl_wrapper.cc @@ -57,6 +57,8 @@ LibcurlWrapper::LibcurlWrapper() return; } +LibcurlWrapper::~LibcurlWrapper() {} + bool LibcurlWrapper::SetProxy(const string& proxy_host, const string& proxy_userpwd) { if (!init_ok_) { diff --git a/src/common/linux/libcurl_wrapper.h b/src/common/linux/libcurl_wrapper.h index 3b72b5e7..3d46c2e6 100644 --- a/src/common/linux/libcurl_wrapper.h +++ b/src/common/linux/libcurl_wrapper.h @@ -40,6 +40,7 @@ namespace google_breakpad { class LibcurlWrapper { public: LibcurlWrapper(); + ~LibcurlWrapper(); virtual bool Init(); virtual bool SetProxy(const string& proxy_host, const string& proxy_userpwd);