From 7f05071e8b91f640308abe30c837bfe6d1f47db0 Mon Sep 17 00:00:00 2001 From: "thestig@chromium.org" Date: Tue, 10 Dec 2013 21:17:12 +0000 Subject: [PATCH] Address additional comments from r1248. Fix the register to check and fix some style nits. BUG=495 R=mark@chromium.org Review URL: https://breakpad.appspot.com/834003 git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1254 4c0a9323-5329-0410-9bdc-e9ce6186880e --- .../linux/minidump_writer/linux_ptrace_dumper.cc | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/client/linux/minidump_writer/linux_ptrace_dumper.cc b/src/client/linux/minidump_writer/linux_ptrace_dumper.cc index f1582573..5ea3bd54 100644 --- a/src/client/linux/minidump_writer/linux_ptrace_dumper.cc +++ b/src/client/linux/minidump_writer/linux_ptrace_dumper.cc @@ -195,15 +195,15 @@ bool LinuxPtraceDumper::GetThreadInfoByIndex(size_t index, ThreadInfo* info) { } #if defined(__i386) - // Detect if the CPU supports the MMX instructions - int eax,ebx,ecx,edx; - __cpuid(1,eax,ebx,ecx,edx); - if (edx & bit_MMX) { + // Detect if the CPU supports the FXSAVE/FXRSTOR instructions + int eax, ebx, ecx, edx; + __cpuid(1, eax, ebx, ecx, edx); + if (edx & bit_FXSAVE) { if (sys_ptrace(PTRACE_GETFPXREGS, tid, NULL, &info->fpxregs) == -1) { return false; } } else { - memset( &info->fpxregs, 0, sizeof(info->fpxregs) ); + memset(&info->fpxregs, 0, sizeof(info->fpxregs)); } #endif