From c7acbcef042cd3c7bc49efc8da879da8e2ef2f00 Mon Sep 17 00:00:00 2001 From: Nelson Billing Date: Fri, 18 Nov 2022 10:48:12 -0800 Subject: [PATCH] Fix Windows native symbol uploads. - We were appending a CRLF to uploaded files, which is okay for Breakpad symbols but breaks binaries (PE/PDB). - Removed the CRLF after files in the request body to fix issue. Tested with Breakpad, PE, and PDB uploads. Change-Id: I95ee7c51bf981cdb2e55cc720a7813cf7afa21ce Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/4038506 Reviewed-by: Joshua Peraza Reviewed-by: Zequan Wu --- src/common/windows/http_upload.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/src/common/windows/http_upload.cc b/src/common/windows/http_upload.cc index 093cd71d..088a5e54 100644 --- a/src/common/windows/http_upload.cc +++ b/src/common/windows/http_upload.cc @@ -390,7 +390,6 @@ namespace { if (!contents.empty()) { request_body->append(&(contents[0]), contents.size()); } - request_body->append("\r\n"); return true; }