mirror of
https://github.com/yuzu-emu/breakpad.git
synced 2025-11-14 08:55:00 +00:00
8819ab0844
More specifically: - Detect corrupt symbols during minidump processing and provide the list of modules with corrupt symbols in the ProcessState. This will allow listing the corrupt symbol files in the final crash report. - Skip and recover from symbol data parse errors - don't give up until 100 parse errors are seen. - In order to recover from '\0' (null terminator) in the middle of a symbol file, a couple of methods have to be updated to require both buffer pointer and length. Previously they required only a buffer pointer (char *) and the size of the buffer was evaluated using strlen which is not reliable when the data is corrupt. Most of the changes are due to these signature updates. - Added and updated unittests. Also, updated minidump_stackwalk to show a WARNING for corrupt symbols. Output looks like this: ... Loaded modules: 0x000da000 - 0x000dafff Google Chrome Canary ??? (main) 0x000e0000 - 0x0417dfff Google Chrome Framework 0.1500.0.3 (WARNING: Corrupt symbols, Google Chrome Framework, 4682A6B4136436C4BFECEB62D498020E0) 0x044a8000 - 0x04571fff IOBluetooth 0.1.0.0 ... Review URL: https://breakpad.appspot.com/613002 git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1200 4c0a9323-5329-0410-9bdc-e9ce6186880e
100 lines
4.4 KiB
C++
100 lines
4.4 KiB
C++
// Copyright (c) 2006, Google Inc.
|
|
// All rights reserved.
|
|
//
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are
|
|
// met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright
|
|
// notice, this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above
|
|
// copyright notice, this list of conditions and the following disclaimer
|
|
// in the documentation and/or other materials provided with the
|
|
// distribution.
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
// contributors may be used to endorse or promote products derived from
|
|
// this software without specific prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
// The caller may implement the SymbolSupplier abstract base class
|
|
// to provide symbols for a given module.
|
|
|
|
#ifndef GOOGLE_BREAKPAD_PROCESSOR_SYMBOL_SUPPLIER_H__
|
|
#define GOOGLE_BREAKPAD_PROCESSOR_SYMBOL_SUPPLIER_H__
|
|
|
|
#include <string>
|
|
#include "common/using_std_string.h"
|
|
|
|
namespace google_breakpad {
|
|
|
|
class CodeModule;
|
|
struct SystemInfo;
|
|
|
|
class SymbolSupplier {
|
|
public:
|
|
// Result type for GetSymbolFile
|
|
enum SymbolResult {
|
|
// no symbols were found, but continue processing
|
|
NOT_FOUND,
|
|
|
|
// symbols were found, and the path has been placed in symbol_file
|
|
FOUND,
|
|
|
|
// stops processing the minidump immediately
|
|
INTERRUPT
|
|
};
|
|
|
|
virtual ~SymbolSupplier() {}
|
|
|
|
// Retrieves the symbol file for the given CodeModule, placing the
|
|
// path in symbol_file if successful. system_info contains strings
|
|
// identifying the operating system and CPU; SymbolSupplier may use
|
|
// to help locate the symbol file. system_info may be NULL or its
|
|
// fields may be empty if these values are unknown. symbol_file
|
|
// must be a pointer to a valid string
|
|
virtual SymbolResult GetSymbolFile(const CodeModule *module,
|
|
const SystemInfo *system_info,
|
|
string *symbol_file) = 0;
|
|
// Same as above, except also places symbol data into symbol_data.
|
|
// If symbol_data is NULL, the data is not returned.
|
|
// TODO(nealsid) Once we have symbol data caching behavior implemented
|
|
// investigate making all symbol suppliers implement all methods,
|
|
// and make this pure virtual
|
|
virtual SymbolResult GetSymbolFile(const CodeModule *module,
|
|
const SystemInfo *system_info,
|
|
string *symbol_file,
|
|
string *symbol_data) = 0;
|
|
|
|
// Same as above, except allocates data buffer on heap and then places the
|
|
// symbol data into the buffer as C-string.
|
|
// SymbolSupplier is responsible for deleting the data buffer. After the call
|
|
// to GetCStringSymbolData(), the caller should call FreeSymbolData(const
|
|
// Module *module) once the data buffer is no longer needed.
|
|
// If symbol_data is not NULL, symbol supplier won't return FOUND unless it
|
|
// returns a valid buffer in symbol_data, e.g., returns INTERRUPT on memory
|
|
// allocation failure.
|
|
virtual SymbolResult GetCStringSymbolData(const CodeModule *module,
|
|
const SystemInfo *system_info,
|
|
string *symbol_file,
|
|
char **symbol_data,
|
|
size_t *symbol_data_size) = 0;
|
|
|
|
// Frees the data buffer allocated for the module in GetCStringSymbolData.
|
|
virtual void FreeSymbolData(const CodeModule *module) = 0;
|
|
};
|
|
|
|
} // namespace google_breakpad
|
|
|
|
#endif // GOOGLE_BREAKPAD_PROCESSOR_SYMBOL_SUPPLIER_H__
|