From 4a5ed0231d077ca028c28e5b14018eb611b90888 Mon Sep 17 00:00:00 2001 From: Steven Cooreman Date: Thu, 11 Mar 2021 13:18:29 +0100 Subject: [PATCH 1/3] Add missing parenthesis Signed-off-by: Steven Cooreman --- library/ecp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/library/ecp.c b/library/ecp.c index fe41b4128..2168981af 100644 --- a/library/ecp.c +++ b/library/ecp.c @@ -2505,7 +2505,7 @@ static int ecp_randomize_mxz( const mbedtls_ecp_group *grp, mbedtls_ecp_point *P #if defined(MBEDTLS_ECP_RANDOMIZE_MXZ_ALT) if( mbedtls_internal_ecp_grp_capable( grp ) ) - return( mbedtls_internal_ecp_randomize_mxz( grp, P, f_rng, p_rng ); + return( mbedtls_internal_ecp_randomize_mxz( grp, P, f_rng, p_rng ) ); #endif /* MBEDTLS_ECP_RANDOMIZE_MXZ_ALT */ p_size = ( grp->pbits + 7 ) / 8; From 22092e483ec55166c8564be0cabd78af1af60901 Mon Sep 17 00:00:00 2001 From: Steven Cooreman Date: Mon, 29 Mar 2021 15:46:55 +0200 Subject: [PATCH 2/3] Add changelog entry for #4217 Signed-off-by: Steven Cooreman --- ChangeLog.d/add-missing-parenthesis.txt | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 ChangeLog.d/add-missing-parenthesis.txt diff --git a/ChangeLog.d/add-missing-parenthesis.txt b/ChangeLog.d/add-missing-parenthesis.txt new file mode 100644 index 000000000..ec01985e9 --- /dev/null +++ b/ChangeLog.d/add-missing-parenthesis.txt @@ -0,0 +1,4 @@ +Bugfix + * Add a parenthesis that was missing from ecp.c when + MBEDTLS_ECP_RANDOMIZE_MXZ_ALT is defined. Found and reported by + mbeniamino in #4217. From 91edd1e701850d5307a536e9c50a1392c726d15f Mon Sep 17 00:00:00 2001 From: Dave Rodgman Date: Tue, 27 Apr 2021 17:01:24 +0100 Subject: [PATCH 3/3] Improve changelog entry for #4217 Signed-off-by: Dave Rodgman --- ChangeLog.d/add-missing-parenthesis.txt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ChangeLog.d/add-missing-parenthesis.txt b/ChangeLog.d/add-missing-parenthesis.txt index ec01985e9..9576ff379 100644 --- a/ChangeLog.d/add-missing-parenthesis.txt +++ b/ChangeLog.d/add-missing-parenthesis.txt @@ -1,4 +1,3 @@ Bugfix - * Add a parenthesis that was missing from ecp.c when - MBEDTLS_ECP_RANDOMIZE_MXZ_ALT is defined. Found and reported by - mbeniamino in #4217. + * Fix a compilation error when MBEDTLS_ECP_RANDOMIZE_MXZ_ALT is + defined. Fixes #4217.