From afd5a08e33b51b8f86d4ecf980a92238daeecce7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Manuel=20P=C3=A9gouri=C3=A9-Gonnard?= Date: Wed, 28 May 2014 21:52:59 +0200 Subject: [PATCH] Minor tune-up in aes code un-duplicate a check, and remove useless default case, mainly so that these lines don't appear as uncovered --- library/aes.c | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/library/aes.c b/library/aes.c index ca5c90692..c03cbbe83 100644 --- a/library/aes.c +++ b/library/aes.c @@ -565,10 +565,6 @@ int aes_setkey_enc( aes_context *ctx, const unsigned char *key, RK[15] = RK[7] ^ RK[14]; } break; - - default: - - break; } return( 0 ); @@ -586,14 +582,6 @@ int aes_setkey_dec( aes_context *ctx, const unsigned char *key, uint32_t *SK; int ret; - switch( keysize ) - { - case 128: ctx->nr = 10; break; - case 192: ctx->nr = 12; break; - case 256: ctx->nr = 14; break; - default : return( POLARSSL_ERR_AES_INVALID_KEY_LENGTH ); - } - #if defined(POLARSSL_PADLOCK_C) && defined(PADLOCK_ALIGN16) if( aes_padlock_ace == -1 ) aes_padlock_ace = padlock_supports( PADLOCK_ACE ); @@ -604,10 +592,12 @@ int aes_setkey_dec( aes_context *ctx, const unsigned char *key, #endif ctx->rk = RK = ctx->buf; - ret = aes_setkey_enc( &cty, key, keysize ); - if( ret != 0 ) + /* Also checks keysize */ + if( ( ret = aes_setkey_enc( &cty, key, keysize ) ) != 0 ) return( ret ); + ctx->nr = cty.nr; + #if defined(POLARSSL_AESNI_C) && defined(POLARSSL_HAVE_X86_64) if( aesni_supports( POLARSSL_AESNI_AES ) ) {