From c00cceaa3f4cb953ab6fb73ed5a5f5e3cedabe85 Mon Sep 17 00:00:00 2001 From: Hanno Becker Date: Fri, 7 Jun 2019 17:03:40 +0100 Subject: [PATCH] Move def'n of X.509 time-verif funcs to hdr if no time available --- include/mbedtls/x509.h | 16 ++++++++++++++++ library/x509.c | 16 +--------------- 2 files changed, 17 insertions(+), 15 deletions(-) diff --git a/include/mbedtls/x509.h b/include/mbedtls/x509.h index b69dd71ad..c31847d92 100644 --- a/include/mbedtls/x509.h +++ b/include/mbedtls/x509.h @@ -250,6 +250,7 @@ int mbedtls_x509_dn_gets( char *buf, size_t size, const mbedtls_x509_name *dn ); */ int mbedtls_x509_serial_gets( char *buf, size_t size, const mbedtls_x509_buf *serial ); +#if defined(MBEDTLS_HAVE_TIME_DATE) /** * \brief Check a given mbedtls_x509_time against the system time * and tell if it's in the past. @@ -277,6 +278,7 @@ int mbedtls_x509_time_is_past( const mbedtls_x509_time *to ); * 0 otherwise. */ int mbedtls_x509_time_is_future( const mbedtls_x509_time *from ); +#endif /* MBEDTLS_HAVE_TIME_DATE */ /** * \brief Free a dynamic linked list presentation of an X.509 name @@ -301,6 +303,20 @@ static inline void mbedtls_x509_sequence_free( mbedtls_x509_sequence *seq ) mbedtls_asn1_sequence_free( (mbedtls_asn1_sequence*) seq ); } +#if !defined(MBEDTLS_HAVE_TIME_DATE) +static inline int mbedtls_x509_time_is_past( const mbedtls_x509_time *to ) +{ + ((void) to); + return( 0 ); +} + +static inline int mbedtls_x509_time_is_future( const mbedtls_x509_time *from ) +{ + ((void) from); + return( 0 ); +} +#endif /* !MBEDTLS_HAVE_TIME_DATE */ + #if defined(MBEDTLS_SELF_TEST) /** diff --git a/library/x509.c b/library/x509.c index 0d2b9efab..a6c658479 100644 --- a/library/x509.c +++ b/library/x509.c @@ -1192,21 +1192,7 @@ int mbedtls_x509_time_is_future( const mbedtls_x509_time *from ) return( x509_check_time( from, &now ) ); } - -#else /* MBEDTLS_HAVE_TIME_DATE */ - -int mbedtls_x509_time_is_past( const mbedtls_x509_time *to ) -{ - ((void) to); - return( 0 ); -} - -int mbedtls_x509_time_is_future( const mbedtls_x509_time *from ) -{ - ((void) from); - return( 0 ); -} -#endif /* MBEDTLS_HAVE_TIME_DATE */ +#endif /* MBEDTLS_HAVE_TIME_DATE */ void mbedtls_x509_name_free( mbedtls_x509_name *name ) {