From d4efa8d0ac41a20baa346c634154fc1c6eb75d16 Mon Sep 17 00:00:00 2001 From: John Durkop Date: Tue, 8 Sep 2020 05:58:28 -0700 Subject: [PATCH] Fix pk_ec_test_vec() to use MBEDTLS_MD_NONE The pk_ec_test_vec() was incorrectly using MBEDTLS_MD_SHA1 for the parameter to mbedtls_pk_verify(). It should use MBEDTLS_MD_NONE since that parameter is ignored for this test case. Signed-off-by: John Durkop --- tests/suites/test_suite_pk.function | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/suites/test_suite_pk.function b/tests/suites/test_suite_pk.function index 43b491473..c6041b249 100644 --- a/tests/suites/test_suite_pk.function +++ b/tests/suites/test_suite_pk.function @@ -775,8 +775,8 @@ void pk_ec_test_vec( int type, int id, data_t * key, data_t * hash, TEST_ASSERT( mbedtls_ecp_point_read_binary( &eckey->grp, &eckey->Q, key->x, key->len ) == 0 ); - // MBEDTLS_MD_SHA1 is a dummy - it is ignored, but has to be other than MBEDTLS_MD_NONE. - TEST_ASSERT( mbedtls_pk_verify( &pk, MBEDTLS_MD_SHA1, + // MBEDTLS_MD_NONE is used since it will be ignored. + TEST_ASSERT( mbedtls_pk_verify( &pk, MBEDTLS_MD_NONE, hash->x, hash->len, sig->x, sig->len ) == ret ); exit: