diff --git a/ChangeLog b/ChangeLog index 4d22cf5d0..af97da69b 100644 --- a/ChangeLog +++ b/ChangeLog @@ -6,6 +6,8 @@ Bugfix * Fix bug in certificate validation that caused valid chains to be rejected when the first intermediate certificate has pathLenConstraint=0. Found by Nicholas Wilson. Introduced in mbed TLS 1.3.15. #280 + * Removed potential leak in rsa_rsassa_pkcs1_v15_sign(), found by + JayaraghavendranK. #372 = Version 1.2.18 released 2015-11-04 diff --git a/library/rsa.c b/library/rsa.c index 9fe62d103..deade5c2f 100644 --- a/library/rsa.c +++ b/library/rsa.c @@ -1034,10 +1034,16 @@ int rsa_rsassa_pkcs1_v15_sign( rsa_context *ctx, * temporary buffer and check it before returning it. */ sig_try = malloc( ctx->len ); - verif = malloc( ctx->len ); - if( sig_try == NULL || verif == NULL ) + if( sig_try == NULL ) return( POLARSSL_ERR_MPI_MALLOC_FAILED ); + verif = malloc( ctx->len ); + if( verif == NULL ) + { + free( sig_try ); + return( POLARSSL_ERR_MPI_MALLOC_FAILED ); + } + MPI_CHK( rsa_private( ctx, f_rng, p_rng, sig, sig_try ) ); MPI_CHK( rsa_public( ctx, sig_try, verif ) );