From ea38a926c16ea217f2af6b6bedb96aa5d62c76c8 Mon Sep 17 00:00:00 2001 From: Gilles Peskine Date: Sat, 13 Feb 2021 00:05:16 +0100 Subject: [PATCH] Remove a redundant export step in import_export exercise_export_key() exports the key and does sanity checks on the result. Here we've already just exported the key, so just run the sanity checks. Signed-off-by: Gilles Peskine --- tests/suites/test_suite_psa_crypto.function | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/suites/test_suite_psa_crypto.function b/tests/suites/test_suite_psa_crypto.function index b172da6a9..37cc5514a 100644 --- a/tests/suites/test_suite_psa_crypto.function +++ b/tests/suites/test_suite_psa_crypto.function @@ -1607,7 +1607,11 @@ void import_export( data_t *data, goto destroy; } - if( ! exercise_export_key( key, usage_arg ) ) + /* Run sanity checks on the exported key. For non-canonical inputs, + * this validates the canonical representations. For canonical inputs, + * this doesn't directly validate the implementation, but it still helps + * by cross-validating the test data with the sanity check code. */ + if( ! mbedtls_test_psa_exercise_key( key, usage_arg, 0 ) ) goto exit; if( canonical_input )