From f02eeb87620acb20d93e2ccd5189f499369de7f4 Mon Sep 17 00:00:00 2001 From: Gilles Peskine Date: Mon, 1 Mar 2021 11:39:21 +0100 Subject: [PATCH] Fix sloppy wording around stricly less-than vs less or equal Signed-off-by: Gilles Peskine --- include/mbedtls/net_sockets.h | 2 +- library/net_sockets.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/mbedtls/net_sockets.h b/include/mbedtls/net_sockets.h index 67fe1e9f2..bca35839f 100644 --- a/include/mbedtls/net_sockets.h +++ b/include/mbedtls/net_sockets.h @@ -221,7 +221,7 @@ int mbedtls_net_send( void *ctx, const unsigned char *buf, size_t len ); * * \note The current implementation of this function uses * select() and returns an error if the file descriptor - * is beyond \c FD_SETSIZE. + * is \c FD_SETSIZE or greater. * * \param ctx Socket * \param buf The buffer to write to diff --git a/library/net_sockets.c b/library/net_sockets.c index e19d84a29..fa27603c1 100644 --- a/library/net_sockets.c +++ b/library/net_sockets.c @@ -536,9 +536,9 @@ int mbedtls_net_recv_timeout( void *ctx, unsigned char *buf, size_t len, return( MBEDTLS_ERR_NET_INVALID_CONTEXT ); /* A limitation of select() is that it only works with file descriptors - * up to FD_SETSIZE. This is a limitation of the fd_set type. Error out - * early, because attempting to call FD_SET on a large file descriptor - * is a buffer overflow on typical platforms. */ + * that are strictly less than FD_SETSIZE. This is a limitation of the + * fd_set type. Error out early, because attempting to call FD_SET on a + * large file descriptor is a buffer overflow on typical platforms. */ if( fd >= FD_SETSIZE ) return( MBEDTLS_ERR_NET_RECV_FAILED );