From 1496dddeabe1bcbb250c11e01ef85599fd34fbb0 Mon Sep 17 00:00:00 2001 From: Markus Armbruster Date: Thu, 8 Mar 2018 08:50:04 -0500 Subject: [PATCH] Include qapi/qmp/qlist.h exactly where needed This cleanup makes the number of objects depending on qapi/qmp/qlist.h drop from 4551 (out of 4743) to 16 in my "build everything" tree. While there, separate #include from file comment with a blank line. Backports commit 47e6b297e76007c04a1e9c492006fe093d932cd9 from qemu --- qemu/include/qapi/qmp/qdict.h | 1 - qemu/qapi/qobject-output-visitor.c | 4 ++-- qemu/qobject/qdict.c | 1 + 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/qemu/include/qapi/qmp/qdict.h b/qemu/include/qapi/qmp/qdict.h index 0538318f..9c96f79e 100644 --- a/qemu/include/qapi/qmp/qdict.h +++ b/qemu/include/qapi/qmp/qdict.h @@ -14,7 +14,6 @@ #define QDICT_H #include "qapi/qmp/qobject.h" -#include "qapi/qmp/qlist.h" #include "qemu/queue.h" #include "unicorn/platform.h" diff --git a/qemu/qapi/qobject-output-visitor.c b/qemu/qapi/qobject-output-visitor.c index c1d3e673..ba1bac73 100644 --- a/qemu/qapi/qobject-output-visitor.c +++ b/qemu/qapi/qobject-output-visitor.c @@ -18,10 +18,10 @@ #include "qemu/queue.h" #include "qemu-common.h" #include "qapi/qmp/qbool.h" -#include "qapi/qmp/qnull.h" -#include "qapi/qmp/qnum.h" #include "qapi/qmp/qdict.h" #include "qapi/qmp/qlist.h" +#include "qapi/qmp/qnull.h" +#include "qapi/qmp/qnum.h" #include "qapi/qmp/qstring.h" #include "qapi/qmp/qerror.h" diff --git a/qemu/qobject/qdict.c b/qemu/qobject/qdict.c index 9e546f94..ea9e9652 100644 --- a/qemu/qobject/qdict.c +++ b/qemu/qobject/qdict.c @@ -14,6 +14,7 @@ #include "qapi/qmp/qnum.h" #include "qapi/qmp/qdict.h" #include "qapi/qmp/qbool.h" +#include "qapi/qmp/qlist.h" #include "qapi/qmp/qnull.h" #include "qapi/qmp/qstring.h" #include "qapi/error.h"