From 2e3bd010a8e37bee22634ec770bafc5939b9e593 Mon Sep 17 00:00:00 2001 From: Peter Maydell Date: Wed, 3 Mar 2021 18:00:25 -0500 Subject: [PATCH] target/arm: Implement CLRM instruction In v8.1M the new CLRM instruction allows zeroing an arbitrary set of the general-purpose registers and APSR. Implement this. The encoding is a subset of the LDMIA T2 encoding, using what would be Rn=0b1111 (which UNDEFs for LDMIA). Backports 6e21a013fbdf54960a079dccc90772bb622e28e8 --- qemu/target/arm/t32.decode | 6 +++++- qemu/target/arm/translate.c | 39 +++++++++++++++++++++++++++++++++++++ 2 files changed, 44 insertions(+), 1 deletion(-) diff --git a/qemu/target/arm/t32.decode b/qemu/target/arm/t32.decode index cfcc71bf..f045eb62 100644 --- a/qemu/target/arm/t32.decode +++ b/qemu/target/arm/t32.decode @@ -609,7 +609,11 @@ UXTAB 1111 1010 0101 .... 1111 .... 10.. .... @rrr_rot STM_t32 1110 1000 10.0 .... ................ @ldstm i=1 b=0 STM_t32 1110 1001 00.0 .... ................ @ldstm i=0 b=1 -LDM_t32 1110 1000 10.1 .... ................ @ldstm i=1 b=0 +{ + # Rn=15 UNDEFs for LDM; M-profile CLRM uses that encoding + CLRM 1110 1000 1001 1111 list:16 + LDM_t32 1110 1000 10.1 .... ................ @ldstm i=1 b=0 +} LDM_t32 1110 1001 00.1 .... ................ @ldstm i=0 b=1 &rfe !extern rn w pu diff --git a/qemu/target/arm/translate.c b/qemu/target/arm/translate.c index 09ccf0b3..8c0c2414 100644 --- a/qemu/target/arm/translate.c +++ b/qemu/target/arm/translate.c @@ -8220,6 +8220,45 @@ static bool trans_LDM_t16(DisasContext *s, arg_ldst_block *a) return do_ldm(s, a, 1); } +static bool trans_CLRM(DisasContext *s, arg_CLRM *a) +{ + TCGContext *tcg_ctx = s->uc->tcg_ctx; + int i; + TCGv_i32 zero; + + if (!dc_isar_feature(aa32_m_sec_state, s)) { + return false; + } + + if (extract32(a->list, 13, 1)) { + return false; + } + + if (!a->list) { + /* UNPREDICTABLE; we choose to UNDEF */ + return false; + } + + zero = tcg_const_i32(tcg_ctx, 0); + for (i = 0; i < 15; i++) { + if (extract32(a->list, i, 1)) { + /* Clear R[i] */ + tcg_gen_mov_i32(tcg_ctx, tcg_ctx->cpu_R[i], zero); + } + } + if (extract32(a->list, 15, 1)) { + /* + * Clear APSR (by calling the MSR helper with the same argument + * as for "MSR APSR_nzcvqg, Rn": mask = 0b1100, SYSM=0) + */ + TCGv_i32 maskreg = tcg_const_i32(tcg_ctx, 0xc << 8); + gen_helper_v7m_msr(tcg_ctx, tcg_ctx->cpu_env, maskreg, zero); + tcg_temp_free_i32(tcg_ctx, maskreg); + } + tcg_temp_free_i32(tcg_ctx, zero); + return true; +} + /* * Branch, branch with link */