From 2fbf4d24c95e1f27115f3967e84324fd5c064a36 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alex=20Benn=C3=A9e?= Date: Thu, 5 Jul 2018 17:35:38 -0400 Subject: [PATCH] Revert "Makefile: Rename TARGET_DIRS to TARGET_LIST" This reverts commit 208ecb3e1acc8d55dab49fdf721a86d513691688. This was causing problems by making DEF_TARGET_LIST pointless and having to jump through hoops to build on mingw with a dully enabled config. This includes a change to fix the per-guest TCG test probe which was added after 208ecb3 and used TARGET_LIST. Backports commit 2b1f35b9a85cf0232615a67e7ff523137a58795e from qemu --- qemu/Makefile | 14 +++++++------- qemu/configure | 2 +- qemu/scripts/create_config | 2 +- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/qemu/Makefile b/qemu/Makefile index 6d940d59..42d9124d 100644 --- a/qemu/Makefile +++ b/qemu/Makefile @@ -19,8 +19,8 @@ seems to have been used for an in-tree build. You can fix this by running \ endif endif -CONFIG_SOFTMMU := $(if $(filter %-softmmu,$(TARGET_LIST)),y) -CONFIG_USER_ONLY := $(if $(filter %-user,$(TARGET_LIST)),y) +CONFIG_SOFTMMU := $(if $(filter %-softmmu,$(TARGET_DIRS)),y) +CONFIG_USER_ONLY := $(if $(filter %-user,$(TARGET_DIRS)),y) CONFIG_ALL=y -include config-all-devices.mak @@ -66,8 +66,8 @@ $(call set-vpath, $(SRC_PATH)) LIBS+=-lz $(LIBS_TOOLS) SUBDIR_MAKEFLAGS=$(if $(V),,--no-print-directory --quiet) BUILD_DIR=$(BUILD_DIR) -SUBDIR_DEVICES_MAK=$(patsubst %, %/config-devices.mak, $(TARGET_LIST)) -SUBDIR_DEVICES_MAK_DEP=$(patsubst %, %-config-devices.mak.d, $(TARGET_LIST)) +SUBDIR_DEVICES_MAK=$(patsubst %, %/config-devices.mak, $(TARGET_DIRS)) +SUBDIR_DEVICES_MAK_DEP=$(patsubst %, %-config-devices.mak.d, $(TARGET_DIRS)) ifeq ($(SUBDIR_DEVICES_MAK),) config-all-devices.mak: @@ -123,7 +123,7 @@ all: $(TOOLS) $(HELPERS-y) recurse-all modules config-host.h: config-host.h-timestamp config-host.h-timestamp: config-host.mak -SUBDIR_RULES=$(patsubst %,subdir-%, $(TARGET_LIST)) +SUBDIR_RULES=$(patsubst %,subdir-%, $(TARGET_DIRS)) SOFTMMU_SUBDIR_RULES=$(filter %-softmmu,$(SUBDIR_RULES)) $(SOFTMMU_SUBDIR_RULES): $(block-obj-y) @@ -135,7 +135,7 @@ subdir-%: $(SUBDIR_RULES): qapi/qapi-types.c qapi/qapi-types.h qapi/qapi-visit.c qapi/qapi-visit.h $(common-obj-y) $(util-obj-y) -ALL_SUBDIRS=$(TARGET_LIST) +ALL_SUBDIRS=$(TARGET_DIRS) recurse-all: $(SUBDIR_RULES) @@ -192,7 +192,7 @@ distclean: clean rm -f config-host.mak config-host.h* config-host.ld qemu-img-cmds.texi qemu-monitor.texi rm -f config-all-devices.mak config-all-disas.mak rm -f config.log - for d in $(TARGET_LIST); do \ + for d in $(TARGET_DIRS); do \ rm -rf $$d || exit 1 ; \ done rm -Rf .sdk diff --git a/qemu/configure b/qemu/configure index 4a4251cc..69b620c4 100755 --- a/qemu/configure +++ b/qemu/configure @@ -1459,7 +1459,7 @@ if test "$static" = "yes" ; then echo "CONFIG_STATIC=y" >> $config_host_mak fi echo "SRC_PATH=$source_path" >> $config_host_mak -echo "TARGET_LIST=$target_list" >> $config_host_mak +echo "TARGET_DIRS=$target_list" >> $config_host_mak if test "$byteswap_h" = "yes" ; then echo "CONFIG_BYTESWAP_H=y" >> $config_host_mak fi diff --git a/qemu/scripts/create_config b/qemu/scripts/create_config index 69229b24..a2860021 100755 --- a/qemu/scripts/create_config +++ b/qemu/scripts/create_config @@ -59,7 +59,7 @@ case $line in target_name=${line#*=} echo "#define TARGET_NAME \"$target_name\"" ;; - TARGET_LIST=*) + TARGET_DIRS=*) # do nothing ;; TARGET_*=y) # configuration