From 452891c5307b521b70d2f223a1fad65b2b30b852 Mon Sep 17 00:00:00 2001 From: Richard Henderson Date: Tue, 30 Mar 2021 14:33:28 -0400 Subject: [PATCH] target/arm: Update find_last_active for PREDDESC Since b64ee454a4a0, all predicate operations should be using these field macros for predicates. Backports 2acbfbe4313daf43b6653ee5d82bcaeaa155e895 --- qemu/target/arm/sve_helper.c | 6 +++--- qemu/target/arm/translate-sve.c | 7 +++---- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/qemu/target/arm/sve_helper.c b/qemu/target/arm/sve_helper.c index 8d34b69e..087d56cb 100644 --- a/qemu/target/arm/sve_helper.c +++ b/qemu/target/arm/sve_helper.c @@ -2236,10 +2236,10 @@ void HELPER(sve_compact_d)(void *vd, void *vn, void *vg, uint32_t desc) */ int32_t HELPER(sve_last_active_element)(void *vg, uint32_t pred_desc) { - intptr_t oprsz = extract32(pred_desc, 0, SIMD_OPRSZ_BITS) + 2; - intptr_t esz = extract32(pred_desc, SIMD_DATA_SHIFT, 2); + intptr_t words = DIV_ROUND_UP(FIELD_EX32(pred_desc, PREDDESC, OPRSZ), 8); + intptr_t esz = FIELD_EX32(pred_desc, PREDDESC, ESZ); - return last_active_element(vg, DIV_ROUND_UP(oprsz, 8), esz); + return last_active_element(vg, words, esz); } void HELPER(sve_splice)(void *vd, void *vn, void *vm, void *vg, uint32_t desc) diff --git a/qemu/target/arm/translate-sve.c b/qemu/target/arm/translate-sve.c index e93161fc..5acbe412 100644 --- a/qemu/target/arm/translate-sve.c +++ b/qemu/target/arm/translate-sve.c @@ -2377,11 +2377,10 @@ static void find_last_active(DisasContext *s, TCGv_i32 ret, int esz, int pg) TCGContext *tcg_ctx = s->uc->tcg_ctx; TCGv_ptr t_p = tcg_temp_new_ptr(tcg_ctx); TCGv_i32 t_desc; - unsigned vsz = pred_full_reg_size(s); - unsigned desc; + unsigned desc = 0; - desc = vsz - 2; - desc = deposit32(desc, SIMD_DATA_SHIFT, 2, esz); + desc = FIELD_DP32(desc, PREDDESC, OPRSZ, pred_full_reg_size(s)); + desc = FIELD_DP32(desc, PREDDESC, ESZ, esz); tcg_gen_addi_ptr(tcg_ctx, t_p, tcg_ctx->cpu_env, pred_full_reg_offset(s, pg)); t_desc = tcg_const_i32(tcg_ctx, desc);