From 54ce4b3f00004070a70f97adaeda366909011883 Mon Sep 17 00:00:00 2001 From: Markus Armbruster Date: Mon, 19 Feb 2018 16:17:35 -0500 Subject: [PATCH] qapi-visit: Replace list implicit_structs by set Use set because that's what it is. While there, rename to implicit_structs_seen. Backports commit 8c07eddc619d618965fdd7a96bfe3b5c59f42b52 from qemu --- qemu/scripts/qapi-visit.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/qemu/scripts/qapi-visit.py b/qemu/scripts/qapi-visit.py index 51f3640d..1544f554 100644 --- a/qemu/scripts/qapi-visit.py +++ b/qemu/scripts/qapi-visit.py @@ -16,14 +16,13 @@ from ordereddict import OrderedDict from qapi import * import re -implicit_structs = [] +implicit_structs_seen = set() struct_fields_seen = set() def generate_visit_implicit_struct(type): - global implicit_structs - if type in implicit_structs: + if type in implicit_structs_seen: return '' - implicit_structs.append(type) + implicit_structs_seen.add(type) ret = '' if type not in struct_fields_seen: # Need a forward declaration