From 805c803298ad765882a18e5e1fc030eb34e6dc2f Mon Sep 17 00:00:00 2001 From: Eric Blake Date: Mon, 19 Feb 2018 21:41:48 -0500 Subject: [PATCH] qobject: Rename qtype_code to QType The name QType matches our CODING_STYLE conventions for type names in CamelCase. It also matches the fact that we are already naming all the enum members with a prefix of QTYPE, not QTYPE_CODE. And doing the rename will also make it easier for the next patch to use QAPI for providing the enum, which also wants CamelCase type names. Backports commit 1310a3d3bd9301ff5a825287638cfab24c2c6689 from qemu --- qemu/include/qapi/qmp/qobject.h | 8 ++++---- qemu/qobject/qdict.c | 3 +-- qemu/scripts/qapi.py | 2 +- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/qemu/include/qapi/qmp/qobject.h b/qemu/include/qapi/qmp/qobject.h index 0643cde2..ce85c906 100644 --- a/qemu/include/qapi/qmp/qobject.h +++ b/qemu/include/qapi/qmp/qobject.h @@ -46,10 +46,10 @@ typedef enum { QTYPE_QBOOL, QTYPE_QERROR, QTYPE_MAX, -} qtype_code; +} QType; typedef struct QObject { - qtype_code type; + QType type; size_t refcnt; } QObject; @@ -69,7 +69,7 @@ typedef struct QObject { qobject_decref(obj ? QOBJECT(obj) : NULL) /* Initialize an object to default values */ -static inline void qobject_init(QObject *obj, qtype_code type) +static inline void qobject_init(QObject *obj, QType type) { assert(QTYPE_NONE < type && type < QTYPE_MAX); obj->refcnt = 1; @@ -105,7 +105,7 @@ static inline void qobject_decref(QObject *obj) /** * qobject_type(): Return the QObject's type */ -static inline qtype_code qobject_type(const QObject *obj) +static inline QType qobject_type(const QObject *obj) { assert(QTYPE_NONE < obj->type && obj->type < QTYPE_MAX); return obj->type; diff --git a/qemu/qobject/qdict.c b/qemu/qobject/qdict.c index 58b1b314..0dcbab96 100644 --- a/qemu/qobject/qdict.c +++ b/qemu/qobject/qdict.c @@ -178,8 +178,7 @@ size_t qdict_size(const QDict *qdict) /** * qdict_get_obj(): Get a QObject of a specific type */ -static QObject *qdict_get_obj(const QDict *qdict, const char *key, - qtype_code type) +static QObject *qdict_get_obj(const QDict *qdict, const char *key, QType type) { QObject *obj; diff --git a/qemu/scripts/qapi.py b/qemu/scripts/qapi.py index 2dc8296a..a2acf89a 100644 --- a/qemu/scripts/qapi.py +++ b/qemu/scripts/qapi.py @@ -33,7 +33,7 @@ builtin_types = { 'uint32': 'QTYPE_QINT', 'uint64': 'QTYPE_QINT', 'size': 'QTYPE_QINT', - 'any': None, # any qtype_code possible, actually + 'any': None, # any QType possible, actually } # Whitelist of commands allowed to return a non-dictionary