From bffa25cc0775731345344e65e37e48c7df36f930 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alex=20Benn=C3=A9e?= Date: Sat, 3 Mar 2018 22:36:22 -0500 Subject: [PATCH] target/arm/translate.h: expand comment on DISAS_EXIT We already have an exit condition, DISAS_UPDATE which will exit the run-loop. Expand on the difference with DISAS_EXIT in the comments Backports commit abd1fb0ee2c58b99f4b2d15718f1825fe4984e12 from qemu --- qemu/target/arm/translate.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/qemu/target/arm/translate.h b/qemu/target/arm/translate.h index 9fa246a9..780d48de 100644 --- a/qemu/target/arm/translate.h +++ b/qemu/target/arm/translate.h @@ -139,7 +139,10 @@ static void disas_set_insn_syndrome(DisasContext *s, uint32_t syn) */ #define DISAS_BX_EXCRET 11 /* For instructions which want an immediate exit to the main loop, - * as opposed to attempting to use lookup_and_goto_ptr. + * as opposed to attempting to use lookup_and_goto_ptr. Unlike + * DISAS_UPDATE this doesn't write the PC on exiting the translation + * loop so you need to ensure something (gen_a64_set_pc_im or runtime + * helper) has done so before we reach return from cpu_tb_exec. */ #define DISAS_EXIT 12