From fb1988190eb2290a222acb1d5ffe679a2e753d67 Mon Sep 17 00:00:00 2001 From: Richard Henderson Date: Sat, 21 Mar 2020 11:32:58 -0400 Subject: [PATCH] target/arm: Fix sign-extension for SMLAL* The 32-bit product should be sign-extended, not zero-extended. Fixes: ea96b37 Backports commit 1ab170865202aab8301131f31bffd87ea0f60d16 from qemu --- qemu/target/arm/translate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qemu/target/arm/translate.c b/qemu/target/arm/translate.c index bc0c9ca7..19aebd46 100644 --- a/qemu/target/arm/translate.c +++ b/qemu/target/arm/translate.c @@ -8335,7 +8335,8 @@ static bool op_smlaxxx(DisasContext *s, arg_rrrr *a, case 2: tl = load_reg(s, a->ra); th = load_reg(s, a->rd); - t1 = tcg_const_i32(tcg_ctx, 0); + t1 = tcg_temp_new_i32(tcg_ctx); + tcg_gen_sari_i32(tcg_ctx, t1, t0, 31); tcg_gen_add2_i32(tcg_ctx, tl, th, tl, th, t0, t1); tcg_temp_free_i32(tcg_ctx, t0); tcg_temp_free_i32(tcg_ctx, t1);