From 1e1f1fb15049377f0ef2e12b54daeebc3aa81d35 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C3=ADas=20Locatti?= <42481638+goldenx86@users.noreply.github.com> Date: Tue, 11 Jan 2022 03:01:45 -0300 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Schplee <24275329+Schplee@users.noreply.github.com> --- site/content/entry/yuzu-progress-report-dec-2021/index.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/site/content/entry/yuzu-progress-report-dec-2021/index.md b/site/content/entry/yuzu-progress-report-dec-2021/index.md index 09f61a9c..a82821fe 100644 --- a/site/content/entry/yuzu-progress-report-dec-2021/index.md +++ b/site/content/entry/yuzu-progress-report-dec-2021/index.md @@ -36,12 +36,12 @@ Back in August, [we mentioned how Intel had issues in Vulkan](https://yuzu-emu.org/entry/yuzu-progress-report-aug-2021/#another-terrible-implementation-and-other-graphical-fixes) affecting Mario’s legendary moustache. -`GetAttribute` returns a float value, so a conversion is needed when working with integer ones. +`GetAttribute` returns a float value, so a conversion is needed when working with integer values. The same issue that affected Intel GPUs now happens here on the “greener” side, but inverted. When using `instance_id`, old drivers accepted a float to unsigned integer conversion without issue, and you could do this conversion multiple times without losing the correct value. -The current drivers on the other hand can return zero. +The current drivers, on the other hand, can sometimes return zero. Interpreting the value directly as unsigned integers now solves this issue in both GLSL and [GLASM](https://github.com/yuzu-emu/yuzu/pull/7630). Since this counts as an optimization, we now apply it to all APIs.