actions/cache-apt-pkgs-action
1
0
Fork 0
mirror of https://github.com/awalsh128/cache-apt-pkgs-action.git synced 2026-04-27 21:53:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix duplicate error message bug by removing redundant append

Browse source 
Co-authored-by: awalsh128 <2087466+awalsh128@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot] 2025-10-04 07:01:03 +00:00
parent 49b60534c1
commit 5001e82551
5 changed files with 5 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

BIN
apt_query-arm64
View file

Binary file not shown.

BIN
apt_query-x86
View file

Binary file not shown.

1
src/cmd/apt_query/main_test.go
View file

@ -72,6 +72,5 @@ func TestNormalizedList_VirtualPackagesExists_StdoutsConcretePackage(t *testing.
func TestNormalizedList_VirtualPackageWithNoProviders_StderrsErrorMessage(t *testing.T) {
var result = cmdtesting.New(t, createReplayLogs).Run("normalized-list", "python")
result.ExpectError(`Encountered error resolving some or all package names, see combined std[out,err] below.
virtual package 'python' has no concrete package providers available
virtual package 'python' has no concrete package providers available`)
}

11
src/cmd/apt_query/testlogs/testnormalizedlist_virtualpackagewithnoproviders_stderrserrormessage.log
View file

@ -1,18 +1,17 @@
2025/09/30 07:33:25 Debug log created at /home/runner/work/cache-apt-pkgs-action/cache-apt-pkgs-action/src/cmd/apt_query/apt_query.log
2025/09/30 07:33:26 EXECUTION-OBJ-START
2025/10/04 06:59:56 Debug log created at /home/runner/work/cache-apt-pkgs-action/cache-apt-pkgs-action/src/cmd/apt_query/apt_query.log
2025/10/04 07:00:00 EXECUTION-OBJ-START
{
"Cmd": "apt-cache --quiet=0 --no-all-versions show python",
"CombinedOut": "N: Can't select candidate version from package python as it has no candidate\nN: Can't select versions from package 'python' as it is purely virtual\nN: No packages found\n",
"ExitCode": 0
}
EXECUTION-OBJ-END
2025/09/30 07:33:27 EXECUTION-OBJ-START
2025/10/04 07:00:00 EXECUTION-OBJ-START
{
"Cmd": "bash -c apt-cache showpkg python | grep -A 1 \"Reverse Provides\" | tail -1",
"CombinedOut": "Reverse Provides: \n",
"ExitCode": 0
}
EXECUTION-OBJ-END
2025/09/30 07:33:27 Encountered error resolving some or all package names, see combined std[out,err] below.
virtual package 'python' has no concrete package providers
virtual package 'python' has no concrete package providers
2025/10/04 07:00:00 Encountered error resolving some or all package names, see combined std[out,err] below.
virtual package 'python' has no concrete package providers available

4
src/internal/common/apt.go
View file

@ -127,10 +127,6 @@ func GetAptPackages(executor exec.Executor, names []string) (AptPackages, error)
}
}
if len(errMsgs) > 0 {
errMsgs = append(errMsgs, strings.Join(errMsgs, "\n"))
}
sort.Slice(pkgs, func(i, j int) bool {
return pkgs[i].Name < pkgs[j].Name
})