Commit graph

15 commits

Author SHA1 Message Date
awalsh128 2e2e59d334 Merge remote-tracking branch 'origin/master' into fix/fail-on-install-errors 2026-11-04 17:14:54 -08:00
Andrew Walsh 0e7f5cdc6b
Remove dependency on cache-apt-pkgs-action-ci repo (#223)
* Remove dependency on cache-apt-pkgs-action-ci repo

The action's own workflows (action-tests.yml) already run the same test
jobs as the -ci repo, against the local checkout before merge, so the
separate CI repo is redundant.

- Remove the pub_{master,dev,staging}_push_event.yml workflows that
  dispatched events to the -ci repo (PUBLISH_PUSH_TOKEN secret can be
  deleted from repository settings).
- Point the README test badges at action-tests.yml.
- Port the release-tag tooling (moves the v1 and latest tags) from the
  -ci repo into scripts/release/ and add an update_release_tags
  workflow. Scripts now operate on the current clone instead of
  assuming a sibling checkout, run non-interactively when CI=true, and
  fix the target-tag validation bug in copy_tag.sh.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0112vpMFQJc7Nz7FwE71r5do

* Upgrade golangci-lint to v2 for golangci-lint-action v9

golangci-lint-action >= v7 rejects golangci-lint v1, so the Lint step
failed before installing. Move to golangci-lint v2.14.0 and add a v2
config that keeps the default exclusions v1 applied implicitly. Fix the
one new staticcheck QF1008 finding.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Update expected gir1.2-gdkpixbuf-2.0 version in action tests

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-04 17:03:23 -08:00
awalsh128 06ebcd9b21 Fail the action on package resolution and install errors
lib.sh disables errexit, so failures from package resolution, apt-fast
install, and repository setup were ignored and an incomplete install could
be cached. Check each of these explicitly and abort with a distinct exit
code, and verify every requested package is installed before caching.

- Report virtual packages with no providers (e.g. python on 22.04) with a
  clear error instead of a mangled "Reverse=Provides:" package (#166).
- Stop reporting each apt_query error twice.
- Guard logging.Debug against an uninitialized logger.
- Add an abort helper to lib.sh and use it for all abort sites.
- Add distribute.sh build-committed-binaries / check-committed-binaries and
  apt_query.srchash so PR CI fails when the committed binaries are stale
  (#166, #218). Release and committed builds share build_apt_query.
- Rebuild the committed apt_query binaries.
- Make the expected-failure tests actually fail when the action succeeds,
  and add regression tests for #166 and #221.

Fixes #166
Fixes #221

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-04 15:50:38 -08:00
copilot-swe-agent[bot] aecf4c42e4 Fix create-release CI failure: consolidate release artifacts and restrict to workflow_dispatch only 2026-06-29 23:00:54 -07:00
awalsh128 9f817f32fd Merge branch 'master' of https://github.com/awalsh128/cache-apt-pkgs-action 2026-06-29 22:48:17 -07:00
awalsh128 c107d9850d Bump all action dependency versions and pin them 2026-06-29 22:47:54 -07:00
copilot-swe-agent[bot] b3b266d824 fix: ensure create-release job is skipped in dry-run (workflow_call) mode 2026-06-29 22:40:59 -07:00
awalsh128 869c1d6651 Revert "add shellcheck linting"
This reverts commit e58a49f1de.
2026-06-29 22:29:52 -07:00
Mahyar McDonald e58a49f1de add shellcheck linting
- Updated variable expansions to use double quotes for better safety and to prevent word splitting.
- Replaced `ls` with `find` in cache operations to handle non-alphanumeric filenames more robustly.
- Enhanced array handling in scripts by using `${*:N}` syntax for concatenation.
- Improved readability and consistency in conditional checks by using `[[ ... ]]` instead of `[ ... ]`.
- Added comments for clarity on specific operations and shellcheck directives.
2026-06-13 16:54:54 -07:00
Copilot cd5ee21d96
[WIP] Fix test workflows for actions (#184)
* Initial plan

* Fix test workflows to download artifacts and use local action

- Add needs: [build_binaries] to all test jobs that use the action
- Replace remote action references with local (uses: ./)
- Add checkout step where missing
- Add artifact download and distribute directory setup before action usage
- This ensures binaries built by build_binaries job are available when tests run

Co-authored-by: awalsh128 <2087466+awalsh128@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: awalsh128 <2087466+awalsh128@users.noreply.github.com>
2026-06-13 16:46:15 -07:00
Andrew Walsh 6460a33c29
First version of a Golang version for APT package querying. (#118) (#119)
* Pull dev upstream to staging. (#112)

* Use awk to enclose filename in single quotes tar #99

* Add null field separator so filenames don't get broken up.

* Move upload logs up in the action sequence so it captures data before it gets deleted.

* Fix awk (#109)

---------

Co-authored-by: sn-o-w <cristian.silaghi@mozilla.ro>

* Fix awk delimiter.

Pull in fix by @sn-o-w in d0ee83b497 mentioned in issue #99

* Swap out Bash based APT query logic for Golang version. (#117)

* First version of a Golang version of command handling in general. (#118)

---------

Co-authored-by: sn-o-w <cristian.silaghi@mozilla.ro>
2023-12-22 10:28:03 -08:00
awalsh128 b61cf9a6f1 Copy from staging to dev. 2022-07-19 20:42:48 -07:00
awalsh128 1372e9e2e7 Publish push event for master too. 2021-10-17 13:06:35 -07:00
awalsh128 7c507492e5 Update publish conditions. 2021-10-16 10:19:02 -07:00
awalsh128 b07ee5cce8 Initial commit. 2021-10-13 21:11:27 -07:00