mirror of
https://github.com/awalsh128/cache-apt-pkgs-action.git
synced 2026-11-13 21:36:56 +00:00
06ebcd9b21
lib.sh disables errexit, so failures from package resolution, apt-fast install, and repository setup were ignored and an incomplete install could be cached. Check each of these explicitly and abort with a distinct exit code, and verify every requested package is installed before caching. - Report virtual packages with no providers (e.g. python on 22.04) with a clear error instead of a mangled "Reverse=Provides:" package (#166). - Stop reporting each apt_query error twice. - Guard logging.Debug against an uninitialized logger. - Add an abort helper to lib.sh and use it for all abort sites. - Add distribute.sh build-committed-binaries / check-committed-binaries and apt_query.srchash so PR CI fails when the committed binaries are stale (#166, #218). Release and committed builds share build_apt_query. - Rebuild the committed apt_query binaries. - Make the expected-failure tests actually fail when the action succeeds, and add regression tests for #166 and #221. Fixes #166 Fixes #221 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
125 lines
3.2 KiB
Bash
Executable file
125 lines
3.2 KiB
Bash
Executable file
#!/bin/bash
|
|
|
|
set -e
|
|
|
|
# Include library.
|
|
script_dir="$(dirname -- "$(realpath -- "${0}")")"
|
|
source "${script_dir}/lib.sh"
|
|
|
|
# Debug mode for diagnosing issues.
|
|
# Setup first before other operations.
|
|
debug="${4}"
|
|
validate_bool "${debug}" debug 1
|
|
test ${debug} == "true" && set -x
|
|
|
|
# Directory that holds the cached packages.
|
|
cache_dir="${1}"
|
|
|
|
# Version of the cache to create or load.
|
|
version="${2}"
|
|
|
|
# Execute post-installation script.
|
|
execute_install_scripts="${3}"
|
|
|
|
# Debug mode for diagnosing issues.
|
|
debug="${4}"
|
|
|
|
# Repositories to add before installing packages.
|
|
add_repository="${5}"
|
|
|
|
# List of the packages to use.
|
|
input_packages="${@:6}"
|
|
|
|
# Trim commas, excess spaces, and sort.
|
|
log "Normalizing package list..."
|
|
|
|
# Ensure APT package lists are updated if stale (for nektos/act compatibility)
|
|
update_apt_lists_if_stale
|
|
|
|
if ! packages="$(get_normalized_package_list "${input_packages}")"; then
|
|
abort 7 "Unable to resolve the package list; see the error above."
|
|
fi
|
|
log "done"
|
|
|
|
# Create cache directory so artifacts can be saved.
|
|
mkdir -p ${cache_dir}
|
|
|
|
log "Validating action arguments (version='${version}', packages='${packages}')...";
|
|
if grep -q " " <<< "${version}"; then
|
|
abort 2 "Version value '${version}' cannot contain spaces."
|
|
fi
|
|
|
|
# Is length of string zero?
|
|
if test -z "${packages}"; then
|
|
case "$EMPTY_PACKAGES_BEHAVIOR" in
|
|
ignore)
|
|
exit 0
|
|
;;
|
|
warn)
|
|
echo "::warning::Packages argument is empty."
|
|
exit 0
|
|
;;
|
|
*)
|
|
abort 3 "Packages argument is empty."
|
|
;;
|
|
esac
|
|
fi
|
|
|
|
validate_bool "${execute_install_scripts}" execute_install_scripts 4
|
|
|
|
# Basic validation for repository parameter
|
|
if [ -n "${add_repository}" ]; then
|
|
log "Validating repository parameter..."
|
|
for repository in ${add_repository}; do
|
|
# Check if repository format looks valid (basic check)
|
|
if [[ "${repository}" =~ [^a-zA-Z0-9:\/.-] ]]; then
|
|
abort 6 \
|
|
"Repository '${repository}' contains invalid characters." \
|
|
"Supported formats: 'ppa:user/repo', 'deb http://...', 'http://...', 'multiverse', etc."
|
|
fi
|
|
done
|
|
log "done"
|
|
fi
|
|
|
|
log "done"
|
|
|
|
log_empty_line
|
|
|
|
# Abort on any failure at this point.
|
|
set -e
|
|
|
|
log "Creating cache key..."
|
|
|
|
# Forces an update in cases where an accidental breaking change was introduced
|
|
# and a global cache reset is required, or change in cache action requiring reload.
|
|
force_update_inc="3"
|
|
|
|
# Force a different cache key for different architectures (currently x86_64 and aarch64 are available on GitHub)
|
|
cpu_arch="$(arch)"
|
|
log "- CPU architecture is '${cpu_arch}'."
|
|
|
|
value="${packages} @ ${version} ${force_update_inc}"
|
|
|
|
# Include repositories in cache key to ensure different repos get different caches
|
|
if [ -n "${add_repository}" ]; then
|
|
value="${value} ${add_repository}"
|
|
log "- Repositories '${add_repository}' added to value."
|
|
fi
|
|
|
|
# Don't invalidate existing caches for the standard Ubuntu runners
|
|
if [ "${cpu_arch}" != "x86_64" ]; then
|
|
value="${value} ${cpu_arch}"
|
|
log "- Architecture '${cpu_arch}' added to value."
|
|
fi
|
|
|
|
log "- Value to hash is '${value}'."
|
|
|
|
key="$(echo "${value}" | md5sum | cut -f1 -d' ')"
|
|
log "- Value hashed as '${key}'."
|
|
|
|
log "done"
|
|
|
|
key_filepath="${cache_dir}/cache_key.md5"
|
|
echo ${key} > ${key_filepath}
|
|
log "Hash value written to ${key_filepath}"
|