actions/docker-metadata-action
1
0
Fork 0
mirror of https://github.com/docker/metadata-action.git synced 2024-12-22 22:45:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #198 from crazy-max/refactor-default-banch

Browse source 
don't handle default branch global exp for pr events
This commit is contained in:
CrazyMax 2022-04-26 17:15:45 +02:00 committed by GitHub
parent 72fe50e2af 0a72be43da
commit be6d2cc1df
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 7 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
README.md
View file

@ -693,9 +693,6 @@ workflow run. Will be empty for a branch reference:
Returns `true` if the branch that triggered the workflow run is the default Returns `true` if the branch that triggered the workflow run is the default
one, otherwise `false`. one, otherwise `false`.
Will compare against the branch name that triggered the workflow run or the
base ref for a pull request.
#### `{{date '<format>'}}` #### `{{date '<format>'}}`
Returns the current date rendered by its [moment format](https://momentjs.com/docs/#/displaying/format/). Returns the current date rendered by its [moment format](https://momentjs.com/docs/#/displaying/format/).

14
__tests__/meta.test.ts
View file

@ -2327,14 +2327,11 @@ describe('pr', () => {
} as Inputs, } as Inputs,
{ {
main: 'mytag-master', main: 'mytag-master',
partial: [ partial: [],
'mytag-defbranch'
],
latest: false latest: false
} as Version, } as Version,
[ [
'org/app:mytag-master', 'org/app:mytag-master'
'org/app:mytag-defbranch'
], ],
[ [
"org.opencontainers.image.title=Hello-World", "org.opencontainers.image.title=Hello-World",
@ -2359,14 +2356,11 @@ describe('pr', () => {
} as Inputs, } as Inputs,
{ {
main: 'mytag-master', main: 'mytag-master',
partial: [ partial: [],
'mytag-defbranch'
],
latest: false latest: false
} as Version, } as Version,
[ [
'org/app:mytag-master', 'org/app:mytag-master'
'org/app:mytag-defbranch'
], ],
[ [
"org.opencontainers.image.title=Hello-World", "org.opencontainers.image.title=Hello-World",

2
dist/index.js generated vendored
View file

File diff suppressed because one or more lines are too long

2
dist/index.js.map generated vendored
View file

File diff suppressed because one or more lines are too long

5
src/meta.ts
View file

@ -377,7 +377,7 @@ export class Meta {
return ''; return '';
}, },
is_default_branch: function () { is_default_branch: function () {
let branch = ctx.ref.replace(/^refs\/heads\//g, ''); const branch = ctx.ref.replace(/^refs\/heads\//g, '');
// TODO: "base_ref" is available in the push payload but doesn't always seem to // TODO: "base_ref" is available in the push payload but doesn't always seem to
// return the expected branch when the push tag event occurs. It's also not // return the expected branch when the push tag event occurs. It's also not
// documented in GitHub docs: https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#push // documented in GitHub docs: https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#push
@ -385,9 +385,6 @@ export class Meta {
// if (/^refs\/tags\//.test(ctx.ref) && ctx.payload?.base_ref != undefined) { // if (/^refs\/tags\//.test(ctx.ref) && ctx.payload?.base_ref != undefined) {
// branch = ctx.payload.base_ref.replace(/^refs\/heads\//g, ''); // branch = ctx.payload.base_ref.replace(/^refs\/heads\//g, '');
// } // }
if (/^refs\/pull\//.test(ctx.ref) && ctx.payload?.pull_request?.base?.ref != undefined) {
branch = ctx.payload.pull_request.base.ref;
}
if (branch == undefined || branch.length == 0) { if (branch == undefined || branch.length == 0) {
return 'false'; return 'false';
} }