citra/citra-nightly
1
0
Fork 0
mirror of https://github.com/citra-emu/citra-nightly.git synced 2024-12-26 10:25:38 +00:00
Code Issues Packages Projects Releases Wiki Activity
8604 commits 2 branches 2112 tags 51 MiB
Commit graph

7220 commits

Author SHA1 Message Date
Marshall Mohror 996f1546b2
core: Remove outdated MSVC workarounds (#5099) 
* core/hw/gpu: Remove outdated MSVC workarounds

* core/hle/service/hid: Remove MSVC workaround
 2020-02-20 13:40:21 -06:00
zhupengfei a487016cb4
core, citra_qt: Implement a save states file format and slot UI 
10 slots are offered along with 'Save to Oldest Slot' and 'Load from Newest Slot'.

The savestate format is similar to the movie file format. It is called CST (Citra SavesTate), and is basically a 0x100 byte header (consisting of magic, revision, creation time and title ID) followed by Zstd compressed raw savestate data.

The savestate files are saved to the `states` folder in Citra's user folder. The files are named like `<Title ID>.<Slot ID>.cst`.
 2020-02-18 13:19:52 +08:00
zhupengfei 7d880f94db
Add simple zstd compression 
Just a simple default compression is able to shrink savestate file size from ~160MB to ~20MB.
 2020-02-16 23:25:30 +08:00
Vitor K 4991c0121a
Remove duplicate code from the migration of frame limit to gene… (#5091) 2020-02-15 14:38:20 +01:00
zhupengfei 57efc41973
service/cecd: Add missing SessionData serialization 2020-02-14 17:15:08 +08:00
zhupengfei 7e8041df28
kernel/timer: Add missing base object 2020-02-14 17:13:53 +08:00
Hamish Milne 246ae84a52 Pretty sure ARM/Thread serialization works now 2020-02-13 17:42:12 +08:00
Hamish Milne c983528862 Reworked DSP serialization 2020-02-13 17:42:12 +08:00
James Rowe 55c75b5e3e Add ClearAll to rasterizer cache for fully wiping the cache on save/load 2020-02-13 17:42:11 +08:00
James Rowe 3e34ad6890 Hack: Workaround crash when loading state and gyro is used 2020-02-13 17:42:11 +08:00
Hamish Milne 0effb229cd Fix geometry pipeline; attempt to fix motion controls 2020-02-13 17:42:10 +08:00
Hamish Milne 35c3ca995c Fixed a bug (??) in arm_dynarmic where PageTableChanged could reset the CPU context 2020-02-13 17:42:10 +08:00
Hamish Milne b2370ea353 Fixed setting the right DSP service on deserialization 2020-02-13 17:42:10 +08:00
Hamish Milne 2217b3558d Fixed file services serialization 2020-02-13 17:42:10 +08:00
Hamish Milne c24ea0f0ee Serialize core timing 2020-02-13 17:42:09 +08:00
Hamish Milne 8abc5525be Added Signals; more runtime fixes 2020-02-13 17:42:09 +08:00
Hamish Milne e4f05884c3 Fixed serialization runtime exceptions 2020-02-13 17:42:08 +08:00
Hamish Milne ca971ff31f Serialize file/directory services 2020-02-13 17:42:08 +08:00
Hamish Milne 9525d81344 More base-derived fixes 2020-02-13 17:42:07 +08:00
Hamish Milne 996aba39fe Correct exports; add some file serialization; fix service base object serialization 2020-02-13 17:42:07 +08:00
Hamish Milne f2de70c3fb Fix crash bugs 2020-02-13 17:42:06 +08:00
Hamish Milne 116d22d562 Refactor out the wakeup_callback function pointer 2020-02-13 17:42:05 +08:00
Hamish Milne 7019561fd5 Bind NWM_UDS service in the constructor 2020-02-13 17:42:05 +08:00
Hamish Milne 96432589bd Use shared_ptr for PageTable 2020-02-13 17:42:04 +08:00
Hamish Milne e4afa8e512 Make the tests pass 2020-02-13 17:42:04 +08:00
Hamish Milne 65d96bf6c1 Changed u8* to MemoryRef 2020-02-13 17:42:00 +08:00
Hamish Milne cf985631e0 Minor tidying up 2020-02-13 17:41:27 +08:00
Hamish Milne 26e90a99cd Added basic UI; misc memory fixes 2020-02-13 17:41:27 +08:00
Hamish Milne 558e710e17 Finished archives; remove pod.h 2020-02-13 17:41:26 +08:00
Hamish Milne 2bf5b46460 Basic archive backend serialization 2020-02-13 17:41:26 +08:00
Hamish Milne 2d2c7218ef Serialize CECD, CFG services 2020-02-13 17:41:25 +08:00
Hamish Milne ef2e503281 Serialize QTM, Y2R services 2020-02-13 17:41:24 +08:00
Hamish Milne 92857efca4 Serialize PTM service 2020-02-13 17:41:24 +08:00
Hamish Milne f5e2f873b0 Serialize NWM service 2020-02-13 17:41:24 +08:00
Hamish Milne 571b1062f0 Serialize NIM, PS, PXI, SOC, SSL services 2020-02-13 17:41:23 +08:00
Hamish Milne 2409ee39cb Serialize IR, MVD, NDM, NEWS, NFC 2020-02-13 17:41:23 +08:00
Hamish Milne 3d6e372f96 More clang format fixes. Really need to standardise the version of this 2020-02-13 17:41:23 +08:00
Hamish Milne 01ec2e8a67 Serialize MIC service 2020-02-13 17:41:22 +08:00
Hamish Milne e3c0211b74 Fix clang format 2020-02-13 17:41:22 +08:00
Hamish Milne eb67167b7c Serialize IR service 2020-02-13 17:41:22 +08:00
Hamish Milne 8bd3e8cd27 Serialize HTTP service 2020-02-13 17:41:22 +08:00
Hamish Milne 74361fa3fb Serialize HID service 2020-02-13 17:41:21 +08:00
Hamish Milne 30494c06a4 Serialize GSP service 2020-02-13 17:41:21 +08:00
Hamish Milne 9877bf7d48 Change how the boost target works; disable external warnings in MSVC 2020-02-13 17:41:20 +08:00
Hamish Milne d041901a30 Some more CI fixes 2020-02-13 17:41:20 +08:00
Hamish Milne c7106e232f Fix a bug on mingw 2020-02-13 17:41:16 +08:00
Hamish Milne d6862c2fca Some CI fixes 2020-02-13 17:40:52 +08:00
Hamish Milne 7b846ffa98 clang-format fixes 2020-02-13 17:39:15 +08:00
Hamish Milne d482fb359c Attempting to fix mingw on windows 2020-02-13 17:38:25 +08:00
Hamish Milne 6917eaf53b Use load_construct_data for kernel objects 2020-02-13 17:38:25 +08:00
Hamish Milne 3ed8d95866 Serialize FS service; some compiler fixes 2020-02-13 17:38:24 +08:00
Hamish Milne d1096de245 Added FRD service serialization 2020-02-13 17:38:24 +08:00
Hamish Milne 4354179156 Added ERR service serialization 2020-02-13 17:38:23 +08:00
Hamish Milne 452ae2e371 Added DSP service serialization 2020-02-13 17:38:23 +08:00
Hamish Milne 30fe2bfe38 Added DLP service serialization 2020-02-13 17:38:23 +08:00
Hamish Milne a0c3b91785 Added CSND serialization 2020-02-13 17:38:23 +08:00
Hamish Milne 17b9cbefef CAM service serialization 2020-02-13 17:38:22 +08:00
Hamish Milne 1185d62792 BOSS service serialization 2020-02-13 17:38:22 +08:00
Hamish Milne 5265c79056 APT service serialization 2020-02-13 17:38:21 +08:00
Hamish Milne 3e752002c4 Replace g_kernel with Core::Global etc. 2020-02-13 17:38:21 +08:00
Hamish Milne e707685c2a Serialize AM services 2020-02-13 17:38:20 +08:00
Hamish Milne 89e4e49a63 Finished AC and ACT service serialization 2020-02-13 17:38:20 +08:00
Hamish Milne 3fd5c431f1 Service serialization framework; done AC 2020-02-13 17:38:20 +08:00
Hamish Milne ac0337d8df Started IPC services serialization 2020-02-13 17:38:19 +08:00
Hamish Milne 7a5bde0b44 Serialize service manager, server prt 2020-02-13 17:38:19 +08:00
Hamish Milne 4f95575d41 Serialize some more kernel objects 2020-02-13 17:38:18 +08:00
Hamish Milne 8c81500dee Serialize kernel/hle/memory 2020-02-13 17:38:18 +08:00
Hamish Milne 050c3bdee5 Serialize primitive_assembly 2020-02-13 17:38:18 +08:00
Hamish Milne c284192a87 Serialize geometry_pipeline 2020-02-13 17:38:17 +08:00
Hamish Milne acc89b2251 Fixed an include 2020-02-13 17:38:17 +08:00
Hamish Milne dc0d1ebc95 Added a TODO 2020-02-13 17:38:17 +08:00
Hamish Milne f557d26b40 Added CPU, mutex, process, thread, timer 2020-02-13 17:38:16 +08:00
Hamish Milne 06891d9454 Added client/server objects 2020-02-13 17:38:16 +08:00
Hamish Milne 5035e68dad Added derived kernel objects 2020-02-13 17:38:15 +08:00
Hamish Milne f79c9668a3 Added shader state; WIP kernel objects 2020-02-13 17:38:10 +08:00
Hamish Milne 45788b9c82 Added shader state serialization 2020-02-13 17:34:16 +08:00
Hamish Milne 6f00976ab5 video_core serialization 2020-02-13 17:34:16 +08:00
Hamish Milne ee2cae2093 Added core serialization 2020-02-13 17:34:13 +08:00
Hamish Milne dc04774ece Added POD serialization 2020-02-13 17:27:51 +08:00
Hamish Milne 6940c99ed6 Added boost serialization 2020-02-13 17:27:50 +08:00
Tobias f106e76132
Port yuzu commit: "yuzu/CMakeLists: Disable implicit QString co… (#5074) 
* yuzu/CMakeLists: Disable implicit QString conversions

Now that all of our code is compilable with implicit QString
conversions, we can enforce it at compile-time by disabling them.

Co-Authored-By: Mat M. <lioncash@users.noreply.github.com>

* citra_qt: Remove lots of implicit QString conversions

Co-authored-by: Mat M. <mathew1800@gmail.com>
 2020-02-11 13:12:09 +01:00
zhupengfei 4273b967b5
core/file_sys: Do not apply the same mods to DLCs 
Now you can apply separate mods to DLCs and mods for the original title won't be applied.
 2020-02-11 14:03:07 +08:00
FearlessTobi 4c2c27046d Fix compilation 2020-02-10 12:10:42 +01:00
Pengfei Zhu b53b4bfb17 Merge pull request #5062 from FearlessTobi/port-3173 
Port yuzu-emu/yuzu#3173: "common: SPSCQueue: Notify after incrementing queue size."
 2020-02-10 12:10:45 +08:00
zhupengfei b81c9bd738
fix clang format 2020-02-10 07:41:31 +08:00
Lioncash 7362fe48ac input_common/udp: Add missing override specifiers 
Prevents trivial warnings and ensures interfaces are properly
maintained between the base class.
 2020-02-09 23:00:02 +01:00
Lioncash 575ab92a76 input_common/udp: std::move SocketCallback instances where applicable 
std::function is allowed to heap allocate if the size of the captures
associated with each lambda exceed a certain threshold. This prevents
potentially unnecessary reallocations from occurring.
 2020-02-09 23:00:02 +01:00
Lioncash fcdc191107 input_common/udp: std::move shared_ptr within Client constructor 
Gets rid of a trivially avoidable atomic reference count increment and
decrement.
 2020-02-09 23:00:02 +01:00
Lioncash 8a0f8c3a4f udp/client: Replace deprecated from_string() call with make_address_v4() 
Future-proofs code if boost is ever updated.
 2020-02-09 23:00:02 +01:00
Lioncash 7d45fdc1df input_common/udp: Silence -Wreorder warning for Socket 
Amends the constructor initializer list to specify the order of its
elements in the same order that initialization would occur.
 2020-02-09 23:00:01 +01:00
Lioncash d7a58fe24d input_common/udp: Remove unnecessary inclusions 2020-02-09 23:00:01 +01:00
Lioncash b39a611a3d input_common/udp: Add missing header guard 2020-02-09 23:00:01 +01:00
zhupengfei d9ae4c332d
layered_fs: Do not open all replacement files on load 
Instead open them when we want to read them. This is because the standard library has a limit on the number of opened files.
 2020-02-09 21:48:42 +08:00
zhupengfei b87bc5d351
citra_qt: Add 'Dump RomFS' menu action 
A progress dialog will be displayed. However no progress is reported and the user also cannot cancel it.
 2020-02-09 21:01:56 +08:00
zhupengfei 13e2d534e9
core: Add dump RomFS support 
This is added to LayeredFS, then the NCCH container and then the loader interface.
 2020-02-09 20:59:31 +08:00
James Rowe 03cde53cb6 Merge pull request #5077 from FearlessTobi/port-3339 
Port yuzu-emu/yuzu#3339: "GUI: fix minor issues with dark themes + rename and reorder themes"
 2020-02-08 12:49:15 -07:00
James Rowe 17e9522921
Merge pull request #5069 from vitor-k/min-window2 
Update minimum window size based on current layout
 2020-02-08 12:46:20 -07:00
zhupengfei db18f6c79a
Address review 
simplify code
 2020-02-07 23:53:00 +08:00
zhupengfei 2ec99b83aa
core: Reset archive_manager on shutdown. 
This holds the archives which include the SelfNCCH archive which holds the RomFS files. If we don't reset it the LayeredFS class can't get destructed and mods files won't be released.
 2020-02-07 23:45:02 +08:00
zhupengfei 6e0afbaa19
Fix build 
Explicitly use `std::min<std::size_t>`

Added virtual destructor
 2020-02-07 16:26:33 +08:00
zhupengfei eed9de2336
core/file_sys: Allow exheader replacement to be read from mods path 
The previous method (filename.exheader) can still be used.
 2020-02-07 15:55:35 +08:00
zhupengfei 53d0c618a0
core/file_sys: Read mods for the original title for updates 
Updates can override RomFS and ExeFS, therefore we should apply the mods to them as well.
 2020-02-07 15:20:20 +08:00
zhupengfei 7c652a0479
citra_qt: Add 'Open Mods Location' 2020-02-07 15:20:20 +08:00
zhupengfei 91e5a39a08
core/file_sys: Allow exefs mods to be read from mods path 
The original path (file_name.exefsdir) is still supported, but alternatively users can choose to put exefs patches in the same place as LayeredFS files (`load/mods/<Title ID>/exefs`).
 2020-02-07 15:20:19 +08:00
zhupengfei 8a570bf00c
core: Use LayeredFS while reading RomFS 
Only enabled for NCCHs that do not have an override romfs.

LayeredFS files should be put in the `load` directory in User Directory. The directory structure is similar to yuzu's but currently does not allow named mods yet. Replacement files should be put in `load/mods/<Title ID>/romfs` while patches/stubs should be put in `load/mods/<Title ID>/romfs_ext`.
 2020-02-07 15:20:18 +08:00
zhupengfei 890405bb7c
core/file_sys: LayeredFS implementation 
This implementation is different from Luma3DS's which directly hooks the SDK functions. Instead, we read the RomFS's metadata and figure out the directory and file structure. Then, relocations (i.e. replacements/deletions/patches) are applied. Afterwards, we rebuild the metadata, and assign 'fake' data offsets to the files. When we want to read file data from this rebuilt RomFS, we use binary search to find the last data offset smaller or equal to the given offset and read from that file  (either from the original RomFS, or from replacement files, or from buffered data with patches applied) and any later files when length is not enough.

The code that rebuilds the metadata is pretty complex and uses quite a few variables to keep track of necessary information like metadata offsets. According to my tests, it is able to build RomFS-es identical to the original (but without trailing garbage data) when no relocations are applied.
 2020-02-07 15:19:57 +08:00
zhupengfei 83e0cc45f4
core/file_sys: Make RomFSReader an abstract interface 
The original RomFSReader is renamed to DirectRomFSReader that directly reads the RomFS.
 2020-02-07 15:19:53 +08:00
zhupengfei 05a82b15e6
swkbd: Fix digit filter 
The DIGIT filter was incorrectly implemented as preventing all digits. It actually limits the maximum digit count to max_digits, according to ctrulib and hardware testing.
 2020-02-04 16:56:30 +08:00
Tobias eb0364dd5f
citra_qt: config: Move audio to its own tab. (#5079) 
- We have some important audio settings, makes them more discoverable.

Co-Authored-By: bunnei <bunneidev@gmail.com>

Co-authored-by: bunnei <bunneidev@gmail.com>
 2020-02-01 16:04:48 +01:00
BreadFish64 e7a073e15f logging/backend: Change type of filename from string to const char* 
This was suggested by degasus in https://github.com/yuzu-emu/yuzu/pull/3326 in order to avoid an unnecessary copy.
 2020-01-28 14:29:26 +01:00
Bartosz Kaszubowski ff66f723bb GUI: fix minor issues with dark themes 
GUI: rename and reorder themes
 2020-01-28 14:24:52 +01:00
FearlessTobi 4b7a45ccc7 yuzu/main: Specify string conversions explicitly 2020-01-23 22:45:13 +01:00
James Rowe 5f20bf0e10
Merge pull request #5073 from vitor-k/log-shader-cache-option 
Log disk shader cache setting
 2020-01-22 21:25:17 -07:00
James Rowe f3e6c4f841
Merge pull request #5071 from jroweboy/loading-bar 
QT Frontend: Add disk shader loading progress bar
 2020-01-22 21:24:43 -07:00
Vitor Kiguchi 2035207dde log disk shader cache setting 2020-01-23 00:49:17 -03:00
James Rowe 426e214c25 Loading Screen: Vertically Center everything 2020-01-22 17:26:27 -07:00
James Rowe 961a7b59c9 QT Frontend: Add disk shader loading progress bar 
Until we get a on screen display or async shader loading, we should at
least have some measure of progress in the meantime. This is 90% a port
from the loading screen I made for yuzu, but with a slightly different
changed detection for when to display the ETA. Now we keep track of a
rolling estimate for shader load ETA and only display a ETA if its going
to take longer than 10 seconds.
 2020-01-22 17:18:00 -07:00
James Rowe 5fb456f17f Frontend: Prevent DiskShader option from being selected if HW Shaders are disabled 2020-01-22 09:50:31 -07:00
James Rowe bd29261e0a Frontend: Only load disk resources if hw shader is enabled 2020-01-22 09:47:53 -07:00
Vitor Kiguchi b713fe3329 Address review comments 2020-01-22 12:51:04 -03:00
Vitor Kiguchi 157f82141d Make a separate function for getting minimum size based on layout 2020-01-21 19:31:39 -03:00
James Rowe 5fd1ff08d7
Merge pull request #5024 from jroweboy/temp-hle-audio-fix 
Prevent out of memory errors when the game passes in an improper length value
 2020-01-21 15:30:20 -07:00
Vitor Kiguchi 0dcb886ef2 clang format 2020-01-21 14:24:16 -03:00
Vitor Kiguchi 718f04af6d Correctly treat cases when current size is smaller than the minimum defined by the layout 2020-01-21 13:32:51 -03:00
Vitor Kiguchi 5d0353c391 correct ProcessConfigurationChanges 2020-01-20 23:00:33 -03:00
Vitor Kiguchi 6e1a873e57 use the defined constants instead of magic numbers for screen dimensions 2020-01-20 23:00:33 -03:00
Vitor Kiguchi 64737afdbc Change min_client_area_size based on layout 2020-01-20 23:00:21 -03:00
James Rowe a0f9c795c8
Merge pull request #5043 from vitor-k/screen-rotate 
Implement Upright/Book-style layout
 2020-01-20 18:38:06 -07:00
Vitor Kiguchi c2179a1dd0 log the upright screen setting 2020-01-20 22:32:16 -03:00
Vitor Kiguchi 5eb9a5b3bc Set hotkey for screen rotation 2020-01-20 22:32:15 -03:00
Vitor Kiguchi be88d2a59a implement upright orientation for side and large frame layouts 2020-01-20 22:32:15 -03:00
vitor-k 89cab445d4 Implementation of screen rotation without use of additional layouts. 
This is based on what was done using additional layouts, but modified
to have a variable to control rotation and making it so Single Screen
Layout behaves like Upright Single would, and Default Layout behaves
like Upright Double would, when the new variable is used.

Large Layout and Side Layout currently ignore the new variable.
New variable still currently doesn't have a hotkey.
 2020-01-20 22:31:51 -03:00
bunnei 591c6a64d7 common: SPSCQueue: Notify after incrementing queue size. 2020-01-19 13:35:49 +01:00
TotalCaesar659 df6cf6bbb6 Add headbar icon on Linux 2020-01-19 13:29:53 +01:00
James Rowe e4285097f4
Merge pull request #5021 from ccawley2011/cpu_detect 
common/cpu_detect: Remove unused functionality
 2020-01-17 20:30:29 -07:00
James Rowe e74a402c69
Merge pull request #4923 from jroweboy/diskcachelul 
Disk Shader Caching
 2020-01-17 18:15:50 -07:00
iwubcode 43f8aadd52 renderer_opengl: Allow usage of interlaced 3D 2020-01-16 22:12:50 -06:00
iwubcode 6f269c375f citra, citra_qt, settings.h, default_ini.h: Add option for interlaced 3D 2020-01-16 22:12:50 -06:00
James Rowe e95bc52b3d Only check for sanitize_mul if theres a shader in the cache 2020-01-16 08:35:52 -07:00
James Rowe 43c9695bf9 Fix title bar 2020-01-15 23:52:41 -07:00
James Rowe cf4125a6a5 Only load precompiled shaders if their sanitize_mul setting matches 2020-01-15 21:10:37 -07:00
James Rowe 6945b6539f Address review and update zstd 2020-01-15 19:58:34 -07:00
James Rowe 936094dd27 Log the number of entries in each cache 2020-01-15 19:58:34 -07:00
James Rowe 45bc5b465e Add a error log for unsupported configurations for disk cache 2020-01-15 19:58:34 -07:00
James Rowe 2d86bc6db5 Rename InvalidateTransferable to InvalidateAll to match what it does 2020-01-15 19:58:34 -07:00
James Rowe 7092ba8480 Only add shaders to precompiled cache if they are new 2020-01-15 19:58:34 -07:00
James Rowe 061a33477f Properly bind the shader sampler and uniform bindings 2020-01-15 19:58:34 -07:00
James Rowe a20c81d593 Change VFS vector to regular vector 2020-01-15 19:58:34 -07:00
James Rowe 6f2756089d citra-sdl: Add Load Disk Resources 2020-01-15 19:58:34 -07:00
James Rowe d418f0438d citra-qt: Load Disk Resources 2020-01-15 19:58:34 -07:00
James Rowe d03d201482 Add GetRenderer to core 2020-01-15 19:58:34 -07:00
James Rowe be52d3a7d0 Add missing changes from yuzu file_util 2020-01-15 19:58:34 -07:00
James Rowe 4e9ec4efd0 Add shader disk caching 2020-01-15 19:58:33 -07:00
James Rowe ce3f8bf94e Add frontend settings 2020-01-15 19:58:33 -07:00
James Rowe b5b6ce5fdc Add shader cache version generation 2020-01-15 19:58:33 -07:00
James Rowe b5bc05738c Add settings for disk shader cache 2020-01-15 19:58:33 -07:00
James Rowe 8f67d6a444 Add ZSTD compression for precompiled cache 2020-01-15 19:58:33 -07:00
James Rowe cd86c9b043
Merge pull request #5036 from leoetlino/bps 
file_sys: Add support for BPS patching
 2020-01-15 12:04:54 -07:00
James Rowe 45bff6ab58
Merge pull request #5033 from BreadFish64/fix_game_list 
qt: do not use an invalid update smdh
 2020-01-15 11:51:35 -07:00
James Rowe 01686f78fe
Merge pull request #5037 from leoetlino/thin-archives 
CMake: Create thin archives on Linux
 2020-01-01 14:29:43 -05:00
BreadFish64 b3beff0f4c common/logging: don't use regex for path trimming 2019-12-24 14:19:18 -06:00
Léo Lam 756d231ff9 file_sys: Add support for BPS patches 
The BPS format allows distributing patches that are smaller and that do
not contain copyrighted content if data is relocated
(unlike non-trivial IPS patches).

This is essential for games such as MM3D that have three barely
different code revisions. Supporting all three versions would
demand an unreasonable amount of work; with BPS patches only one
version has to be supported.
 2019-12-22 10:46:47 +01:00
Léo Lam 3140086c60 file_sys: Handle patch applying failures 
This changes ApplyCodePatch to return a ResultStatus, which makes it
possible to determine whether patch applying has failed. Previously,
only a boolean was returned, and false was returned when no patch
was found OR when a patch was found but applying it failed.

This also changes AppLoader_NCCH to return an error if patching fails
because the executable is likely to be left in an inconsistent state
and we should not proceed booting in that case.
 2019-12-22 10:46:47 +01:00
Léo Lam 1377be9902 file_sys: Move IPS patching code into separate source file 
In anticipation of a new BPS patcher.
 2019-12-22 10:46:47 +01:00
Léo Lam 72a081c617 CMake: Create thin archives on Linux 
This significantly reduces unnecessary disk writes and space usage
when building Citra.

libcore.a is now only ~1MB rather than several hundred megabytes.
 2019-12-22 10:12:00 +01:00
BreadFish64 cadfd6834d qt: do not use an invalid update smdh 2019-12-18 21:51:06 -06:00
James Rowe 020cd56ad8
Merge pull request #5030 from jroweboy/reorder-queue-acquire 
Remove wait for free buffer
 2019-12-18 16:07:52 -07:00
James Rowe dd258acfaf
Merge pull request #5027 from jroweboy/ffmpeg-fix 
Reenable AAC FFMPEG decoding
 2019-12-17 08:49:35 -07:00
James Rowe f9421eedcc
Merge pull request #5028 from jroweboy/missing-vsync-telemetry 
Add missing vsync telemetry field
 2019-12-17 08:49:08 -07:00
James Rowe 1d14b98f81 Remove accidentally pushed debugging logs (#5029) 2019-12-17 11:13:47 +01:00
James Rowe f369196c9f Remove wait for free buffer 
Previously we would first attempt to use any buffer that was free,
meaning whichever buffer has already been displayed. This has poor
interactions when the operating system throttles the update rate of the
window, so if there isn't any free buffers available, just reuse the
oldest frame instead.
 2019-12-16 20:02:01 -07:00
James Rowe b559d1a495 Add missing vsync telemetry field 
Was removed as part of #4940 but readded again.
 2019-12-16 19:30:28 -07:00
James Rowe e53a2ac411 Reenable AAC FFMPEG decoding 
Simple cut/paste issue where initialized is only set to true when the
emulation attempts to init the Binary Pipe, but we used it to test if
the FFMPEG decoder was valid and disabled it if it wasn't. Just return
the value of have_ffmpeg_dl instead so when dynamic loading is added
it'll still work.
 2019-12-16 19:23:43 -07:00
James Rowe 439d550850
Merge pull request #4940 from jroweboy/presentation-thread 
Split Presentation thread from Render thread
 2019-12-15 20:25:34 -07:00
James Rowe 408e225048 Destroy GLWindow on exit to prevent issues closing the app while in fullscreen 2019-12-15 16:20:59 -07:00
James Rowe 36c5058d66 Reintroduce a vsync option for people with really bad drivers 2019-12-15 15:42:05 -07:00
James Rowe 87facaa2e2 Prevent out of memory errors when the game passes in an improper length value 
HACK

In Luigi's Mansion Dark Moon in HLE audio, the game mysteriously passes
in an extremely large value for length, which without any checks, causes
HLE audio to allocate an extremely large buffer.

This value seemingly is caused by some other HLE audio feature is missing,
and Luigi's Mansion subtracts two values to get a length, without
checking for overflow first. This appears to be caused by an incorrect
HLE audio emulation, as its fixed entirely by only changing to LLE. As
such, further investigation is required, but in the meantime, completely
eating up our users RAM is unacceptable.
 2019-12-14 18:18:59 -07:00
James Rowe ddb7ead3e4
Merge pull request #5020 from jroweboy/dynamic-mf 
Runtime Load MediaFoundation dlls on Windows
 2019-12-14 10:13:54 -07:00
James Rowe 30dfe1fcb8 Use the correct register length for index_array 
The index_array can't possible be 31 bits long as that would index
out of bounds memory. According to 3dbrew, this should be 28
 2019-12-13 18:08:07 -07:00
Cameron Cawley 9a45d32a5f common/cpu_detect: Remove Common::CPUVendor 
It's only used by telemetry, where the information it provides can be gained from the brand string.
 2019-12-09 22:39:56 +00:00
Cameron Cawley bc5ad137c0 common/cpu_detect: Remove unused functionality 2019-12-09 22:36:32 +00:00
James Rowe 337ac73915 Improve aac decoder selection 2019-12-08 16:18:39 -07:00
James Rowe b395efe804 Dynamically load Media Foundation 2019-12-08 13:54:27 -07:00
James Rowe 65613cce81 Add microprofile scopes for presentation 2019-12-02 18:59:12 -07:00
James Rowe 9ae3eb4a30 Remove high dpi scaling flag as it needs more work first 2019-12-02 18:34:11 -07:00
zhupengfei 17ba846a3f
applets/swkbd: Remove text memory clearing 
The text shared memory wasn't supposed to be cleared according to my comparison with the LLE swkbd. This can cause issues in certain games such as Harvest Moon.

A null terminator is added to the text copied to mark the end of the string.
 2019-12-01 23:01:07 +08:00
James Rowe 866df2644b
Merge pull request #4982 from vvanelslande/mic-device 
service/mic: actually use the specified device
 2019-11-28 21:23:36 -07:00
James Rowe de17fe31fb clang-format 2019-11-28 20:47:33 -07:00
James Rowe ea40eb0994 Use the proper parent window 
Fixes an issue where the touch point is incorrect in OpenGLWindow when the render
target is initialized for the first time with single window mode disabled.
 2019-11-28 20:35:50 -07:00
James Rowe 123c0212ef Fix window resizing bug 2019-11-28 11:20:42 -07:00
James Rowe 782eae7f65 Fix drag and drop 2019-11-28 10:56:58 -07:00
James Rowe 15ed600c91
Merge pull request #4956 from vitor-k/game-sorting 
Fixes to game list sorting
 2019-11-20 09:48:08 -07:00
James Rowe e6c7f84dc6
Merge pull request #4964 from citra-emu/wwylele-patch-1 
unfold UNREACHABLE implementation for dumb compilers
 2019-11-20 09:43:48 -07:00
Weiyi Wang 6d0189b4b1
Merge pull request #4992 from FearlessTobi/port-2513 
yuzu/game_list&multiplayer: Specify string conversions explicitly
 2019-11-20 10:45:21 -05:00
Weiyi Wang 85f2e577b5
Merge pull request #5006 from FearlessTobi/port-3123 
Port yuzu-emu/yuzu#3123: "common/logging: Silence no return value warnings"
 2019-11-20 10:34:47 -05:00
James Rowe 0acacc4e1a
Merge pull request #5002 from vvanelslande/username-fix 
Fix moderation by room host in dedicated rooms
 2019-11-19 23:51:21 -07:00
ReinUsesLisp 30be149f87 common/logging: Silence no return value warnings 2019-11-19 16:47:35 +01:00
BreadFish64 e38b4f6707 video_core: get rid of MSVC hack comment 2019-11-17 17:42:19 -06:00
vvanelslande d16d34203a Fix moderation by room host in dedicated rooms 2019-11-17 09:59:54 -05:00
vvanelslande e1e136d72f service/mic: actually use the specified device 2019-11-11 17:15:10 -05:00
Weiyi Wang 5fa71d425b
Merge pull request #4998 from vvanelslande/count 
dedicated_room: fix crash (count != 0) when closing the room
 2019-11-11 15:54:44 -05:00
Pengfei Zhu 060119d333
Merge pull request #4987 from vvanelslande/room-logging 
network/room (server): add message/join/leave/kick/ban/unban/game name logging
 2019-11-11 20:29:33 +08:00
Pengfei Zhu 1c6a8e995a
Merge pull request #4953 from vvanelslande/qt-ui-unused 
citra_qt/main.ui: remove unused actions "Load Symbol Map..." and "Select Game Directory..."
 2019-11-11 20:27:48 +08:00
Weiyi Wang 98c396f179
Merge pull request #4995 from vvanelslande/rename-profile 
settings, configure_input: fix rename input profile
 2019-11-10 21:25:01 -05:00
vvanelslande bb48d2491d citra_qt/configuration: add missing Read/SaveUtilityValues 2019-11-10 19:26:03 -05:00
vvanelslande 62014e8f34 dedicated_room: fix crash (count != 0) when closing the room 2019-11-10 17:07:00 -05:00
vvanelslande 1f708e8bad settings, configure_input: fix rename input profile 2019-11-09 16:55:03 -05:00
James Rowe 86f203e6e8 Add missing key events and also try to glFinish after swapping 2019-11-09 13:12:30 -07:00
James Rowe 68052de8a0 Workaround Qt bug that causes events to forward to the parent incorrectly 2019-11-09 13:12:30 -07:00
James Rowe 586b8e8b46 Change from QOpenGLWidget to QWindow 
While QOpenGLWidget sounds like a good idea, it has issues which are
harder to debug due to how Qt manages the context behind the scenes. We
could probably work around any of these issues over time, but its
probably easier to do it ourselves with a QWindow directly.

Plus using QWindow + createWindowContainer is the easiest to use
configuration for Qt + Vulkan so this is probably much better in the
long run.
 2019-11-09 13:12:30 -07:00
James Rowe 66f5278f52 Delete core_context before shutting down SDL 2019-11-09 13:12:30 -07:00
James Rowe 29c12058c7 Add minimum window size back to citra-qt 2019-11-09 13:12:29 -07:00
James Rowe 26d828fb4c Prevent softlock on shutdown and various cleanup 2019-11-09 13:12:29 -07:00
James Rowe 9c32c0b98b Change from render to texture to render to renderbuffer 2019-11-09 13:12:29 -07:00
James Rowe 52d7676831 recreate mailbox to use a queue instead 2019-11-09 13:12:29 -07:00
James Rowe ac90cd0378 Change Present to finish only after swap 2019-11-09 13:12:29 -07:00
James Rowe 6fff8e3921 Remove screen change detection since it breaks make changing screen. (Still need to test windows) 2019-11-09 13:12:29 -07:00
James Rowe 5d97e44279 Fix macOS pixel ratio detection 2019-11-09 13:12:29 -07:00
James Rowe 045eec282a rename GGLContext to just GLContext 2019-11-09 13:12:29 -07:00
James Rowe db94c017bf Change to a constructor that exists in qt 5.9 2019-11-09 13:12:29 -07:00
James Rowe 3b14bb44b9 QOffscreensurface 2019-11-09 13:12:29 -07:00
James Rowe 8d17aa40fd Remove vsync setting 2019-11-09 13:12:26 -07:00
James Rowe fcbe5e1acd Add a separate thread for rendering and add texture mailbox and shared context to SDL 2019-11-09 13:10:18 -07:00
James Rowe 91255b8802 Change Qt to use QOpenGLWidget and support shared context and texture mailbox 2019-11-09 13:10:18 -07:00
James Rowe 27d0fc64d0 Add texture mailbox support to opengl renderer. 2019-11-09 13:10:17 -07:00
James Rowe c2e7903825 Split graphics out of EmuWindow in preparation of shared contexts 2019-11-09 13:10:17 -07:00
James Rowe db7a627a2e Add scope acquire context to simplify MakeCurrent and DoneCurrent calls 2019-11-09 13:10:17 -07:00
Khangaroo df99d98240 specify size of buffer and use openglstate in getteximageoes 2019-11-09 12:58:17 -07:00
khang06 a458155f99 texture dump hotkey (ctrl+d) 
address more comments
 2019-11-09 12:56:30 -07:00
Khangaroo 5450d4980d crash hotfix (no clang-format because on phone) 
hotfix 2: check if the texture is custom before dumping

hotfix 4: fix custom texture conflict detection
 2019-11-09 12:56:28 -07:00
Khangaroo ae4aaf2fc1 nested folder support + refuse to load incompatibly sized textures + general cleanups 2019-11-09 12:56:27 -07:00
Khangaroo 8a98310a16 address more comments, fix dumping textures that already got dumped 2019-11-09 12:56:27 -07:00
Khangaroo c2a32e942b address more comments 2019-11-09 12:56:27 -07:00
Khangaroo 3534ad0835 reorder graphics tab, move speed to general 2019-11-09 12:56:27 -07:00
Khangaroo da83430a68 add enhancements tab files 2019-11-09 12:56:27 -07:00
Khangaroo 650fe6447d generate mipmaps (for now) 2019-11-09 12:56:27 -07:00
Khangaroo f09489475a fix texture dumping on opengl es, create load folder if none exists if custom textures is enabled 2019-11-09 12:56:27 -07:00
Khangaroo 254f8a4643 fix inverted texture dump error message path 2019-11-09 12:56:27 -07:00
Khangaroo 8b881ac1fc fix preload textures being enabled when it shouldn't 
address more comments
 2019-11-09 12:56:25 -07:00
Khangaroo 391e552927 qimageinterface fixes, remove old lodepng, address more comments 2019-11-09 12:56:24 -07:00
Khangaroo b81c15941e add image interface, remove lodepng from video_core/core, address more comments, fix comments 
remove unnecessary conversion
 2019-11-09 12:56:21 -07:00
Khangaroo 5940361b81 new-line that clang-format didn't fix 
address some comments
 2019-11-09 12:56:17 -07:00
Khangaroo 59b475a4b9 implement custom texture preload 2019-11-09 12:56:17 -07:00
Khangaroo 657a129b60 handle upscaling and offsets (fixes oot3d) 2019-11-09 12:54:43 -07:00
Khangaroo 6d90c42a79 fix crashes, add custom texture cache, load textures from load directory 2019-11-09 12:54:40 -07:00
Khangaroo f866b2a917 texture replacement (also messy) 2019-11-09 12:53:16 -07:00
khang06 deff865ac9 initial sloppy texture dumping implementation (opengl only) 2019-11-09 12:53:16 -07:00
khang06 94b3c63bf9 add dump dir to user paths 2019-11-09 12:53:16 -07:00
khang06 e0d63bd21b add texture dumping as a config entry 2019-11-09 12:53:12 -07:00
khang06 2b92065d2a add lodepng as an external, have video_core depend on it 2019-11-09 12:48:23 -07:00