Ryujinx/Ryujinx.Graphics.Texture/Region.cs

namespace Ryujinx.Graphics.Texture
{
    public readonly struct Region
    {
        public int Offset { get; }
        public int Size { get; }

        public Region(int offset, int size)
        {
            Offset = offset;
            Size = size;
        }
    }
}
-												Avoid deleting textures when their data does not overlap. (#2601)

* Avoid deleting textures when their data does not overlap.

It's possible that while two textures start and end addresses indicate an overlap, that the actual data contained within them is sparse due to a layer stride. One such possibility is array slices of a cubemap at different mip levels - they overlap on a whole, but the actual texture data fills the gaps between each other's layers rather than actually overlapping.

This fixes issues with UE4 games having incorrect lighting (solid white screen or really dark shadows). There are still remaining issues with games that use the 3D texture prebaked lighting, such as THPS1+2.

This PR also fixes a bug with TexturePool's resized texture handling where the base level in the descriptor was not considered.

* AllRegions granularity for 3d textures is now by level rather than by slice.

* Address feedback
											
										
										
											2021-08-29 19:22:13 +00:00
+								namespace Ryujinx.Graphics.Texture
 								{
-												Make structs readonly when applicable (#4002)

* Make all structs readonly when applicable. It should reduce amount of needless defensive copies

* Make structs with trivial boilerplate equality code record structs

* Remove unnecessary readonly modifiers from TextureCreateInfo

* Make BitMap structs readonly too
											
										
										
											2022-12-05 13:47:39 +00:00
+								    public readonly struct Region
-												Avoid deleting textures when their data does not overlap. (#2601)

* Avoid deleting textures when their data does not overlap.

It's possible that while two textures start and end addresses indicate an overlap, that the actual data contained within them is sparse due to a layer stride. One such possibility is array slices of a cubemap at different mip levels - they overlap on a whole, but the actual texture data fills the gaps between each other's layers rather than actually overlapping.

This fixes issues with UE4 games having incorrect lighting (solid white screen or really dark shadows). There are still remaining issues with games that use the 3D texture prebaked lighting, such as THPS1+2.

This PR also fixes a bug with TexturePool's resized texture handling where the base level in the descriptor was not considered.

* AllRegions granularity for 3d textures is now by level rather than by slice.

* Address feedback
											
										
										
											2021-08-29 19:22:13 +00:00
+								    {
 								        public int Offset { get; }
 								        public int Size { get; }
 								        public Region(int offset, int size)
 								        {
 								            Offset = offset;
 								            Size = size;
 								        }
 								    }
 								}