Ryujinx/Ryujinx.Graphics.GAL/BufferAssignment.cs

namespace Ryujinx.Graphics.GAL
{
    public readonly struct BufferAssignment
    {
        public readonly int Binding;
        public readonly BufferRange Range;

        public BufferAssignment(int binding, BufferRange range)
        {
            Binding = binding;
            Range = range;
        }
    }
}
-												GAL: Send all buffer assignments at once rather than individually (#3881)

* GAL: Send all buffer assignments at once rather than individually

The `(int first, BufferRange[] ranges)` method call has very significant performance implications when the bindings are spread out, which they generally always are in Vulkan. This change makes it so that these methods are only called a maximum of one time per draw.

Significantly improves GPU thread performance in Pokemon Scarlet/Violet.

* Address Feedback

Removed SetUniformBuffers(int first, ReadOnlySpan<BufferRange> buffers)
											
										
										
											2022-11-24 07:50:59 +00:00
+								namespace Ryujinx.Graphics.GAL
 								{
-												Make structs readonly when applicable (#4002)

* Make all structs readonly when applicable. It should reduce amount of needless defensive copies

* Make structs with trivial boilerplate equality code record structs

* Remove unnecessary readonly modifiers from TextureCreateInfo

* Make BitMap structs readonly too
											
										
										
											2022-12-05 13:47:39 +00:00
+								    public readonly struct BufferAssignment
-												GAL: Send all buffer assignments at once rather than individually (#3881)

* GAL: Send all buffer assignments at once rather than individually

The `(int first, BufferRange[] ranges)` method call has very significant performance implications when the bindings are spread out, which they generally always are in Vulkan. This change makes it so that these methods are only called a maximum of one time per draw.

Significantly improves GPU thread performance in Pokemon Scarlet/Violet.

* Address Feedback

Removed SetUniformBuffers(int first, ReadOnlySpan<BufferRange> buffers)
											
										
										
											2022-11-24 07:50:59 +00:00
+								    {
 								        public readonly int Binding;
 								        public readonly BufferRange Range;
 								        public BufferAssignment(int binding, BufferRange range)
 								        {
 								            Binding = binding;
 								            Range = range;
 								        }
 								    }
 								}