ryujinx/SDL
1
0
Fork 0
mirror of https://github.com/Ryujinx/SDL.git synced 2024-12-26 07:05:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed bug 2860 - SetProp must be paired with RemoveProp especially for properties added to external windows

Browse source 
Coriiander

Upon creating a window, a window property is added to it through the Win32-function "SetProp". This is done in the SDL-function "SetupWindowData" in file "src\video\windows\SDL_windowswindow.c".

Whenever you call "SetProp" to add a property to a Win32-window, you should also call the Win32-function "RemoveProp" to remove it before destroying that Win32-window.

While you might think that it's ok and that Windows will clean up nicely itself, it is not ok. It is against all Win32-API guidelines and is mostlikely a leak. Especially on external windows (CreateWindowFrom) you want to have things done right, not messy and leaky, affecting some other module. Even if SDL gets shutdown entirely that external window will now forever still have the "SDL_WindowData" prop attached to it.
This commit is contained in:
Sam Lantinga 2015-05-28 08:41:07 -07:00
parent 84ce000670
commit 0669a224f5
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/video/windows/SDL_windowswindow.c
View file

@ -615,6 +615,7 @@ WIN_DestroyWindow(_THIS, SDL_Window * window)
if (data) { if (data) {
ReleaseDC(data->hwnd, data->hdc); ReleaseDC(data->hwnd, data->hdc);
ReleaseProp(data->hwnd, TEXT("SDL_WindowData"));
if (data->created) { if (data->created) {
DestroyWindow(data->hwnd); DestroyWindow(data->hwnd);
} else { } else {