ryujinx/SDL
1
0
Fork 0
mirror of https://github.com/Ryujinx/SDL.git synced 2025-03-23 21:55:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

audio: pipewire: Remove redundant locks

Browse source 
The io_list_check_add() and io_list_remove() functions are only ever called from within the Pipewire thread loop, so the locks are redundant.  io_list_sort() is called from within a lock in the device detection function, so those additional locks are redundant as well.
This commit is contained in:
Frank Praznik 2022-02-08 12:30:28 -05:00 committed by Ethan Lee
parent 48b4d1c412
commit 5b36a527ed
1 changed files with 0 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/audio/pipewire/SDL_pipewire.c
View file

@ -275,8 +275,6 @@ io_list_check_add(struct io_node *node)
struct io_node *n; struct io_node *n;
SDL_bool ret = SDL_TRUE; SDL_bool ret = SDL_TRUE;
PIPEWIRE_pw_thread_loop_lock(hotplug_loop);
/* See if the node is already in the list */ /* See if the node is already in the list */
spa_list_for_each (n, &hotplug_io_list, link) { spa_list_for_each (n, &hotplug_io_list, link) {
if (n->id == node->id) { if (n->id == node->id) {
@ -294,8 +292,6 @@ io_list_check_add(struct io_node *node)
dup_found: dup_found:
PIPEWIRE_pw_thread_loop_unlock(hotplug_loop);
return ret; return ret;
} }
@ -304,8 +300,6 @@ io_list_remove(Uint32 id)
{ {
struct io_node *n, *temp; struct io_node *n, *temp;
PIPEWIRE_pw_thread_loop_lock(hotplug_loop);
/* Find and remove the node from the list */ /* Find and remove the node from the list */
spa_list_for_each_safe (n, temp, &hotplug_io_list, link) { spa_list_for_each_safe (n, temp, &hotplug_io_list, link) {
if (n->id == id) { if (n->id == id) {
@ -320,8 +314,6 @@ io_list_remove(Uint32 id)
break; break;
} }
} }
PIPEWIRE_pw_thread_loop_unlock(hotplug_loop);
} }
static void static void
@ -330,8 +322,6 @@ io_list_sort()
struct io_node *default_sink = NULL, *default_source = NULL; struct io_node *default_sink = NULL, *default_source = NULL;
struct io_node *n, *temp; struct io_node *n, *temp;
PIPEWIRE_pw_thread_loop_lock(hotplug_loop);
/* Find and move the default nodes to the beginning of the list */ /* Find and move the default nodes to the beginning of the list */
spa_list_for_each_safe (n, temp, &hotplug_io_list, link) { spa_list_for_each_safe (n, temp, &hotplug_io_list, link) {
if (n->id == pipewire_default_sink_id) { if (n->id == pipewire_default_sink_id) {
@ -350,8 +340,6 @@ io_list_sort()
if (default_sink) { if (default_sink) {
spa_list_prepend(&hotplug_io_list, &default_sink->link); spa_list_prepend(&hotplug_io_list, &default_sink->link);
} }
PIPEWIRE_pw_thread_loop_unlock(hotplug_loop);
} }
static void static void