ryujinx/SDL
1
0
Fork 0
mirror of https://github.com/Ryujinx/SDL.git synced 2024-12-25 07:55:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove the RaiseWindow call from OnWindowRestored for now.

Browse source 
It seems like a net improvement in all the scenarios Sam and I could
think of, and looking at hg history it was added for fullscreen
window management specifically. Much of that code has changed since
then, but maybe it needs to stay there for that and simply be moved
to a fullscreen condition check.

It would solve this issue:

https://bugzilla.libsdl.org/show_bug.cgi?id=2439

As well as cases where on SteamOS, we hide/show specific Steam
overlay windows while expecting them to stay in the background, since
changing the window stacking order really angers the NVIDIA driver.

CR: Sam.
This commit is contained in:
Pierre-Loup A. Griffais 2014-03-26 12:54:51 -07:00
parent 8938c2b5db
commit 833cfe534a
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/video/SDL_video.c
View file

@ -2129,7 +2129,13 @@ SDL_OnWindowMinimized(SDL_Window * window)
void void
SDL_OnWindowRestored(SDL_Window * window) SDL_OnWindowRestored(SDL_Window * window)
{ {
SDL_RaiseWindow(window); /*
* FIXME: Is this fine to just remove this, or should it be preserved just
* for the fullscreen case? In principle it seems like just hiding/showing
* windows shouldn't affect the stacking order; maybe the right fix is to
* re-decouple OnWindowShown and OnWindowRestored.
*/
//SDL_RaiseWindow(window);
if (FULLSCREEN_VISIBLE(window)) { if (FULLSCREEN_VISIBLE(window)) {
SDL_UpdateFullscreenMode(window, SDL_TRUE); SDL_UpdateFullscreenMode(window, SDL_TRUE);