ryujinx/SDL
1
0
Fork 0
mirror of https://github.com/Ryujinx/SDL.git synced 2024-12-25 21:25:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed stack overflow in X11_CreateWindow() (thanks, rapha and Brad!).

Browse source 
This should be a "long" which on a 64-bit system is likely to be > 32-bits,
 causing XGetICValues() to write past the end of the variable (and stack).

Fixes Bugzilla #2513.
This commit is contained in:
Ryan C. Gordon 2014-05-24 21:06:40 -04:00
parent 4db368e625
commit dd5277d65c
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/video/x11/SDL_x11window.c
View file

@ -361,7 +361,7 @@ X11_CreateWindow(_THIS, SDL_Window * window)
Atom _NET_WM_WINDOW_TYPE_NORMAL; Atom _NET_WM_WINDOW_TYPE_NORMAL;
Atom _NET_WM_PID; Atom _NET_WM_PID;
Atom XdndAware, xdnd_version = 5; Atom XdndAware, xdnd_version = 5;
Uint32 fevent = 0; long fevent = 0;
#if SDL_VIDEO_OPENGL_GLX || SDL_VIDEO_OPENGL_EGL #if SDL_VIDEO_OPENGL_GLX || SDL_VIDEO_OPENGL_EGL
if ((window->flags & SDL_WINDOW_OPENGL) && if ((window->flags & SDL_WINDOW_OPENGL) &&