6 commits

Author	SHA1	Message	Date
Cameron Gutman	5dccffd7e4	Allow usage of the new Condition Variable code with Critical Sections ... Vista and later provide the SleepConditionVariableCS() function for this. Since SDL_syscond_srw.c doesn't require SRW locks anymore, rename it to SDL_syscond_cv.c which better reflects the implementation of condition variables rather than the implementation of mutexes. Fixes #4051.	2021-09-17 19:38:09 -04:00
Cameron Gutman	f70e197363	Fix waiting on condition variables with the SRW lock implmentation ... When SleepConditionVariableSRW() releases the SRW lock internally, it causes our SDL_mutex_srw state to become inconsistent. The lock is unowned yet inside, the owner is still the sleeping thread and more importantly the owner count is still 1. The next time someone acquires the lock, they will bump the owner count from 1 to 2. At that point, the lock is hosed. From the internal lock state, it looks to us like that owner has acquired the lock recursively, even though they have not. When they call SDL_UnlockMutex(), it will see the owner count > 0 and not call ReleaseSRWLockExclusive(). Now when someone calls SDL_CondSignal(), SleepConditionVariableSRW() will start the wakeup process by attempting to re-acquire the SRW lock. This will deadlock because the lock was never released after the other thread had used it. The thread waiting on the condition variable will never be able to wake up, even if the SDL_CondWaitTimeout() function is used and the timeout expires.	2021-02-10 10:22:20 -05:00
Ozkan Sezer	01a2f27679	consistently use TEXT() macro with LoadLibrary() and GetModuleHandle() ... cf. bug #5435.	2021-01-04 01:23:50 +03:00
Sam Lantinga	9130f7c377	Updated copyright for 2021	2021-01-02 10:25:38 -08:00
Joel Linn	8fc0baad98	Add SDL_cond implementation using Windows Condition Variables ... Is automatically used when the SRW SDL_mutex implementation is active. Otherwise falls back to the generic implementation. v2: - Rebase onto master fa3ea1051a4b	2020-12-28 11:43:11 -08:00
Joel Linn	2443e51e0e	Add optional suffix _generic to generic SDL_cond impl ... Allows for runtime selectable implementation	2020-12-28 11:42:49 -08:00