mirror of
https://github.com/Ryujinx/SDL.git
synced 2024-12-26 19:45:30 +00:00
ae8ca7c54d
ny00 Unfortunately, simply checking the return codes of "onNativePadDown/Up" as previously done has its own issue: If an SDL joystick is connected *and* opened, then a proper KeyEvent, say with keycode KEYCODE_BUTTON_1, should lead to an SDL joystick button event as expected. If, however, the joystick was *not* opened, then "onNativePadDown/Up" will return a negative value, so before the commit from bug 3426, you could unexpectedly get a keyboard event. (In practice, you'll just get a log message, since KEYCODE_BUTTON_1 has no mapping to a proper SDL_ScanCode value, but it's still an problem). What should still be done, though, is checking the key code itself. We do have the KeyEvent.isGamepadButton method, but according my test, it returns "true" exactly (and only) for the KEYCODE_BUTTON* values, and not for KEYCODE_DPAD* or any other key code. Here is a possible solution: - Do check the return codes of "onNativePadDown/Up" as previously done. - In addition, in "Android_OnPadDown/Up" from src/joystick/android/SDL_sysjoystick.c, 0 should *always* be returned in case the key code can be translated to an SDL_joystick button; Even if no matching joystick can be found. |
||
|---|---|---|
| .. | ||
| android | ||
| bsd | ||
| darwin | ||
| dummy | ||
| emscripten | ||
| haiku | ||
| iphoneos | ||
| linux | ||
| psp | ||
| windows | ||
| SDL_gamecontroller.c | ||
| SDL_gamecontrollerdb.h | ||
| SDL_joystick.c | ||
| SDL_joystick_c.h | ||
| SDL_sysjoystick.h | ||
| sort_controllers.py | ||