WASAPI: Correctly handle no input or output devices instead of crashing.

This commit is contained in:
Jacques Heunis 2016-06-04 14:38:11 +02:00
parent cdc4e2fd2a
commit 4b95b79f27
2 changed files with 36 additions and 26 deletions

View file

@ -666,40 +666,48 @@ static int refresh_devices(struct SoundIoPrivate *si) {
if (FAILED(hr = IMMDeviceEnumerator_GetDefaultAudioEndpoint(siw->device_enumerator, eRender, if (FAILED(hr = IMMDeviceEnumerator_GetDefaultAudioEndpoint(siw->device_enumerator, eRender,
eMultimedia, &rd.default_render_device))) eMultimedia, &rd.default_render_device)))
{ {
deinit_refresh_devices(&rd); if(hr != E_NOTFOUND) {
return SoundIoErrorOpeningDevice; deinit_refresh_devices(&rd);
return SoundIoErrorOpeningDevice;
}
} }
if (rd.lpwstr) { if(rd.default_render_device) {
CoTaskMemFree(rd.lpwstr); if (rd.lpwstr) {
rd.lpwstr = NULL; CoTaskMemFree(rd.lpwstr);
} rd.lpwstr = NULL;
if (FAILED(hr = IMMDevice_GetId(rd.default_render_device, &rd.lpwstr))) { }
deinit_refresh_devices(&rd); if (FAILED(hr = IMMDevice_GetId(rd.default_render_device, &rd.lpwstr))) {
return SoundIoErrorOpeningDevice; deinit_refresh_devices(&rd);
} return SoundIoErrorOpeningDevice;
if ((err = from_lpwstr(rd.lpwstr, &rd.default_render_id, &rd.default_render_id_len))) { }
deinit_refresh_devices(&rd); if ((err = from_lpwstr(rd.lpwstr, &rd.default_render_id, &rd.default_render_id_len))) {
return err; deinit_refresh_devices(&rd);
return err;
}
} }
if (FAILED(hr = IMMDeviceEnumerator_GetDefaultAudioEndpoint(siw->device_enumerator, eCapture, if (FAILED(hr = IMMDeviceEnumerator_GetDefaultAudioEndpoint(siw->device_enumerator, eCapture,
eMultimedia, &rd.default_capture_device))) eMultimedia, &rd.default_capture_device)))
{ {
deinit_refresh_devices(&rd); if(hr != E_NOTFOUND) {
return SoundIoErrorOpeningDevice; deinit_refresh_devices(&rd);
return SoundIoErrorOpeningDevice;
}
} }
if (rd.lpwstr) { if(rd.default_capture_device) {
CoTaskMemFree(rd.lpwstr); if (rd.lpwstr) {
rd.lpwstr = NULL; CoTaskMemFree(rd.lpwstr);
} rd.lpwstr = NULL;
if (FAILED(hr = IMMDevice_GetId(rd.default_capture_device, &rd.lpwstr))) { }
deinit_refresh_devices(&rd); if (FAILED(hr = IMMDevice_GetId(rd.default_capture_device, &rd.lpwstr))) {
return SoundIoErrorOpeningDevice; deinit_refresh_devices(&rd);
} return SoundIoErrorOpeningDevice;
if ((err = from_lpwstr(rd.lpwstr, &rd.default_capture_id, &rd.default_capture_id_len))) { }
deinit_refresh_devices(&rd); if ((err = from_lpwstr(rd.lpwstr, &rd.default_capture_id, &rd.default_capture_id_len))) {
return err; deinit_refresh_devices(&rd);
return err;
}
} }

View file

@ -24,6 +24,8 @@
#include <audiosessiontypes.h> #include <audiosessiontypes.h>
#include <audiopolicy.h> #include <audiopolicy.h>
#define E_NOTFOUND 0x80070490
struct SoundIoPrivate; struct SoundIoPrivate;
int soundio_wasapi_init(struct SoundIoPrivate *si); int soundio_wasapi_init(struct SoundIoPrivate *si);