tree-wide: code clean-up ...

* remove commented-out code blocks
* remove usages of deprecated JS functions
This commit is contained in:
liushuyu 2022-11-05 16:14:10 -06:00
parent 0c3a42e5c7
commit cbfea20517
4 changed files with 4 additions and 6 deletions

View file

@ -70,7 +70,7 @@ export async function command(message: discord.Message) {
} }
} }
const game = message.content.substr(message.content.indexOf(' ') + 1); const game = message.content.substring(message.content.indexOf(' ') + 1);
// Search all games. This is only linear time, so /shrug? // Search all games. This is only linear time, so /shrug?
let bestGame: IGameDBEntry | null = null; let bestGame: IGameDBEntry | null = null;

View file

@ -4,7 +4,7 @@ export const roles = ['Admins', 'Moderators'];
export async function command (message: discord.Message, reply: string | undefined) { export async function command (message: discord.Message, reply: string | undefined) {
let replyMessage; let replyMessage;
if (reply == null) { if (reply == null) {
replyMessage = message.content.substr(message.content.indexOf(' ') + 1); replyMessage = message.content.substring(message.content.indexOf(' ') + 1);
} else { } else {
replyMessage = `${message.mentions.users.map(user => `${user.toString()}`).join(' ')} ${reply}`; replyMessage = `${message.mentions.users.map(user => `${user.toString()}`).join(' ')} ${reply}`;
} }

View file

@ -8,7 +8,7 @@ const repo = process.env.GITHUB_REPOSITORY || 'citra-emu/citra';
export const roles = ['Admins', 'Moderators', 'Developer']; export const roles = ['Admins', 'Moderators', 'Developer'];
export async function command(message: discord.Message) { export async function command(message: discord.Message) {
const prNumber = message.content.substr(message.content.indexOf(' ') + 1).replace(/\n/g, ''); const prNumber = message.content.substring(message.content.indexOf(' ') + 1).replace(/\n/g, '');
const url = `https://api.github.com/repos/${repo}/pulls/${prNumber}`; const url = `https://api.github.com/repos/${repo}/pulls/${prNumber}`;
return fetch(url, fetchOptions).then(response => response.json()).then((pr: any) => { return fetch(url, fetchOptions).then(response => response.json()).then((pr: any) => {
if (!pr || pr.documentation_url || !pr.head) throw new Error('PR not found'); if (!pr || pr.documentation_url || !pr.head) throw new Error('PR not found');

View file

@ -140,9 +140,7 @@ client.on('messageCreate', async (message) => {
if (message.author.bot && message.content.startsWith('.ban') === false) { return; } if (message.author.bot && message.content.startsWith('.ban') === false) { return; }
if (message.guild == null && state.responses.pmReply) { if (message.guild == null && state.responses.pmReply) {
// We want to log PM attempts. // We want to reply to PM attempts.
// logger.info(`${message.author.username} ${message.author} [PM]: ${message.content}`);
// state.logChannel.send(`${message.author.toString()} [PM]: ${message.content}`);
await message.reply(state.responses.pmReply); await message.reply(state.responses.pmReply);
return; return;
} }