yuzu/breakpad
1
0
Fork 0
mirror of https://github.com/yuzu-emu/breakpad.git synced 2024-12-23 11:35:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

[mac] Teach dump_syms to handle additional zerofill sections

Browse source 
This patch allows dump_syms to handle S_THREAD_LOCAL_ZEROFILL
and S_GB_ZEROFILL section in the same way as the more common
S_ZEROFILL section.  Previously, dump_syms would fail to dump
a binary containing a __DATA,__thread_bss section, because it
tried to look up its data (and failed).

R=mark@chromium.org

Review URL: https://codereview.chromium.org/1369233003 .

Patch from Pavel Labath <labath@google.com>.
This commit is contained in:
Pavel Labath 2015-09-30 08:20:42 -04:00 committed by Mark Mentovai
parent 679d70f50b
commit 01c8f7cf46
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/common/mac/macho_reader.cc
View file

@ -481,7 +481,9 @@ bool Reader::WalkSegmentSections(const Segment &segment,
reporter_->SectionsMissing(segment.name); reporter_->SectionsMissing(segment.name);
return false; return false;
} }
if ((section.flags & SECTION_TYPE) == S_ZEROFILL) { const uint32_t section_type = section.flags & SECTION_TYPE;
if (section_type == S_ZEROFILL || section_type == S_THREAD_LOCAL_ZEROFILL ||
section_type == S_GB_ZEROFILL) {
// Zero-fill sections have a size, but no contents. // Zero-fill sections have a size, but no contents.
section.contents.start = section.contents.end = NULL; section.contents.start = section.contents.end = NULL;
} else if (segment.contents.start == NULL && } else if (segment.contents.start == NULL &&