yuzu/breakpad
1
0
Fork 0
mirror of https://github.com/yuzu-emu/breakpad.git synced 2025-03-01 11:16:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix possible null pointer dereference in MinidumpModule (following #32).

Browse source 
r=waylonis

http://groups.google.com/group/airbag-dev/browse_thread/thread/b684b775078d91ca


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@76 4c0a9323-5329-0410-9bdc-e9ce6186880e
This commit is contained in:
mmentovai 2006-12-06 05:03:48 +00:00
parent daf4211942
commit 28e5990b57
1 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/processor/minidump.cc
View file

@ -1146,9 +1146,9 @@ string MinidumpModule::debug_file() const {
string file; string file;
// Prefer the CodeView record if present. // Prefer the CodeView record if present.
const MDCVInfoPDB70* cv_record_70 = if (cv_record_) {
reinterpret_cast<const MDCVInfoPDB70*>(&(*cv_record_)[0]); const MDCVInfoPDB70* cv_record_70 =
if (cv_record_70) { reinterpret_cast<const MDCVInfoPDB70*>(&(*cv_record_)[0]);
if (cv_record_70->cv_signature == MD_CVINFOPDB70_SIGNATURE) { if (cv_record_70->cv_signature == MD_CVINFOPDB70_SIGNATURE) {
// GetCVRecord guarantees pdb_file_name is null-terminated. // GetCVRecord guarantees pdb_file_name is null-terminated.
file = reinterpret_cast<const char*>(cv_record_70->pdb_file_name); file = reinterpret_cast<const char*>(cv_record_70->pdb_file_name);
@ -1169,9 +1169,9 @@ string MinidumpModule::debug_file() const {
if (file.empty()) { if (file.empty()) {
// No usable CodeView record. Try the miscellaneous debug record. // No usable CodeView record. Try the miscellaneous debug record.
const MDImageDebugMisc* misc_record = if (misc_record_) {
reinterpret_cast<const MDImageDebugMisc *>(&(*misc_record_)[0]); const MDImageDebugMisc* misc_record =
if (misc_record) { reinterpret_cast<const MDImageDebugMisc *>(&(*misc_record_)[0]);
if (!misc_record->unicode) { if (!misc_record->unicode) {
// If it's not Unicode, just stuff it into the string. It's unclear // If it's not Unicode, just stuff it into the string. It's unclear
// if misc_record->data is 0-terminated, so use an explicit size. // if misc_record->data is 0-terminated, so use an explicit size.
@ -1216,9 +1216,9 @@ string MinidumpModule::debug_identifier() const {
string identifier; string identifier;
// Use the CodeView record if present. // Use the CodeView record if present.
const MDCVInfoPDB70* cv_record_70 = if (cv_record_) {
reinterpret_cast<const MDCVInfoPDB70*>(&(*cv_record_)[0]); const MDCVInfoPDB70* cv_record_70 =
if (cv_record_70) { reinterpret_cast<const MDCVInfoPDB70*>(&(*cv_record_)[0]);
if (cv_record_70->cv_signature == MD_CVINFOPDB70_SIGNATURE) { if (cv_record_70->cv_signature == MD_CVINFOPDB70_SIGNATURE) {
char identifier_string[41]; char identifier_string[41];
snprintf(identifier_string, sizeof(identifier_string), snprintf(identifier_string, sizeof(identifier_string),