yuzu/breakpad
1
0
Fork 0
mirror of https://github.com/yuzu-emu/breakpad.git synced 2024-12-23 19:25:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

minidump: mark Read as override in derived classes

Browse source 
The base class here declares Read as virtual, so make sure it's
marked as override in the derived classes.  This fixes some build
errors with clang.

src/google_breakpad/processor/minidump.h:853:8: error:
  'Read' overrides a member function but is not marked 'override'
  [-Werror,-Winconsistent-missing-override]
  bool Read(uint32_t expected_size_);
       ^
src/google_breakpad/processor/minidump.h:153:16: note:
  overridden virtual function is here
  virtual bool Read(uint32_t expected_size) = 0;
               ^

Change-Id: Ie4e5fec097b7f37739433a9deb39e7ed60471461
Reviewed-on: https://chromium-review.googlesource.com/444385
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
This commit is contained in:
Mike Frysinger 2017-02-17 00:25:04 -05:00
parent 644e71591b
commit 4e82b6fa11
1 changed files with 10 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
src/google_breakpad/processor/minidump.h
View file

@ -350,7 +350,7 @@ class MinidumpThreadList : public MinidumpStream {
static const uint32_t kStreamType = MD_THREAD_LIST_STREAM; static const uint32_t kStreamType = MD_THREAD_LIST_STREAM;
bool Read(uint32_t aExpectedSize); bool Read(uint32_t aExpectedSize) override;
// The largest number of threads that will be read from a minidump. The // The largest number of threads that will be read from a minidump. The
// default is 256. // default is 256.
@ -592,7 +592,7 @@ class MinidumpMemoryList : public MinidumpStream {
explicit MinidumpMemoryList(Minidump* minidump); explicit MinidumpMemoryList(Minidump* minidump);
bool Read(uint32_t expected_size); bool Read(uint32_t expected_size) override;
// The largest number of memory regions that will be read from a minidump. // The largest number of memory regions that will be read from a minidump.
// The default is 256. // The default is 256.
@ -647,7 +647,7 @@ class MinidumpException : public MinidumpStream {
explicit MinidumpException(Minidump* minidump); explicit MinidumpException(Minidump* minidump);
bool Read(uint32_t expected_size); bool Read(uint32_t expected_size) override;
MDRawExceptionStream exception_; MDRawExceptionStream exception_;
MinidumpContext* context_; MinidumpContext* context_;
@ -687,7 +687,7 @@ class MinidumpAssertion : public MinidumpStream {
explicit MinidumpAssertion(Minidump* minidump); explicit MinidumpAssertion(Minidump* minidump);
bool Read(uint32_t expected_size); bool Read(uint32_t expected_size) override;
MDRawAssertionInfo assertion_; MDRawAssertionInfo assertion_;
string expression_; string expression_;
@ -744,7 +744,7 @@ class MinidumpSystemInfo : public MinidumpStream {
static const uint32_t kStreamType = MD_SYSTEM_INFO_STREAM; static const uint32_t kStreamType = MD_SYSTEM_INFO_STREAM;
bool Read(uint32_t expected_size); bool Read(uint32_t expected_size) override;
// A string identifying the CPU vendor, if known. // A string identifying the CPU vendor, if known.
const string* cpu_vendor_; const string* cpu_vendor_;
@ -849,8 +849,7 @@ class MinidumpUnloadedModuleList : public MinidumpStream,
static const uint32_t kStreamType = MD_UNLOADED_MODULE_LIST_STREAM; static const uint32_t kStreamType = MD_UNLOADED_MODULE_LIST_STREAM;
bool Read(uint32_t expected_size_) override;
bool Read(uint32_t expected_size_);
// The largest number of modules that will be read from a minidump. The // The largest number of modules that will be read from a minidump. The
// default is 1024. // default is 1024.
@ -886,7 +885,7 @@ class MinidumpMiscInfo : public MinidumpStream {
explicit MinidumpMiscInfo(Minidump* minidump_); explicit MinidumpMiscInfo(Minidump* minidump_);
bool Read(uint32_t expected_size_); bool Read(uint32_t expected_size_) override;
MDRawMiscInfo misc_info_; MDRawMiscInfo misc_info_;
@ -927,7 +926,7 @@ class MinidumpBreakpadInfo : public MinidumpStream {
explicit MinidumpBreakpadInfo(Minidump* minidump_); explicit MinidumpBreakpadInfo(Minidump* minidump_);
bool Read(uint32_t expected_size_); bool Read(uint32_t expected_size_) override;
MDRawBreakpadInfo breakpad_info_; MDRawBreakpadInfo breakpad_info_;
@ -995,7 +994,7 @@ class MinidumpMemoryInfoList : public MinidumpStream {
explicit MinidumpMemoryInfoList(Minidump* minidump_); explicit MinidumpMemoryInfoList(Minidump* minidump_);
bool Read(uint32_t expected_size); bool Read(uint32_t expected_size) override;
// Access to memory info using addresses as the key. // Access to memory info using addresses as the key.
RangeMap<uint64_t, unsigned int> *range_map_; RangeMap<uint64_t, unsigned int> *range_map_;
@ -1090,7 +1089,7 @@ class MinidumpLinuxMapsList : public MinidumpStream {
// Read and load the contents of the process mapping data. // Read and load the contents of the process mapping data.
// The stream should have data in the form of /proc/self/maps. // The stream should have data in the form of /proc/self/maps.
// This method returns whether the stream was read successfully. // This method returns whether the stream was read successfully.
bool Read(uint32_t expected_size); bool Read(uint32_t expected_size) override;
// The list of individual mappings. // The list of individual mappings.
MinidumpLinuxMappings *maps_; MinidumpLinuxMappings *maps_;